From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Platon Pronko Newsgroups: gmane.emacs.bugs Subject: bug#45792: 28.0.50; regression in commit c7c154bb, minibuffer is not closed after opening a file Date: Tue, 12 Jan 2021 13:29:23 +0300 Message-ID: References: <75aca8c3-6c8f-2a66-399e-7116d99c91d3@gmail.com> <0f37c263-a361-7360-666a-4c7054ecf329@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38656"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 Cc: Alan Mackenzie To: martin rudalics , 45792@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 12 12:17:06 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzHfe-0009wp-Aq for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 12:17:06 +0100 Original-Received: from localhost ([::1]:48390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzHfd-0005Po-8R for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 06:17:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzGw6-00019L-Ix for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 05:30:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47839) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzGw6-0006ZN-7e for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 05:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kzGw6-0006m4-2f for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 05:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Platon Pronko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jan 2021 10:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45792 X-GNU-PR-Package: emacs Original-Received: via spool by 45792-submit@debbugs.gnu.org id=B45792.161044737225952 (code B ref 45792); Tue, 12 Jan 2021 10:30:01 +0000 Original-Received: (at 45792) by debbugs.gnu.org; 12 Jan 2021 10:29:32 +0000 Original-Received: from localhost ([127.0.0.1]:59385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzGvc-0006kV-Ex for submit@debbugs.gnu.org; Tue, 12 Jan 2021 05:29:32 -0500 Original-Received: from mail-lf1-f41.google.com ([209.85.167.41]:42816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzGva-0006kD-JO for 45792@debbugs.gnu.org; Tue, 12 Jan 2021 05:29:31 -0500 Original-Received: by mail-lf1-f41.google.com with SMTP id b26so2563568lff.9 for <45792@debbugs.gnu.org>; Tue, 12 Jan 2021 02:29:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=d/7TGKjnY0Lu+2yV2ou7hNGVgDA5eMrmePSJmQfMBF0=; b=Vh3NNOB0gA6VZ2g6dRPcuYJ+XzHGqOwxtGvOE8tTuJctSiSqQER7K8e+pE9OyHU27x u06fmGA+tyzCI0NsJqWdmpja8dNX1Bj3c2Dlyx3pxIAaB5QSJ2OjiNjTyZRixa7PZPkP hrm9Dq2bvilo4aMLE9VsH9JNNyJaNAtDbCErXUC9a0dATS7neVB7nMo3wWOpIyaJn5LC mvw3EtZlVcPv3ojE9AgF5dimvfy1LzRc3QpoIUBURV8okDCfmHXg4uxKioxjBbGQrB3E CHaC2x9oOZEZyzCtcQt8LxvFun1F13tTvrDt2awynnFktOaiF2CJrj+KDg/JnwEPL3jx Jtzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d/7TGKjnY0Lu+2yV2ou7hNGVgDA5eMrmePSJmQfMBF0=; b=n0U1tihoY2fIHgX07/juwSbwJ2c6egB4OoIkg2HOn7Fbih4E1yaaUT39BX0i1U7S08 Fm1l0fHyYYgZF3yZKRajPAk8DKWrrqBPmqQ6oNildqxuajuv6u1gW99aPHSLpJHu61Ys F8Q+gkfYlsTajbhKADh/xVanhyVA41qL+/iVhe626tIBfKNvMDBDu8dhFuepax7fOA6Q 7lCyTfRyJpckqs2MC919vv2zOFFKF1ETLZnh+NJnajBRxi26/GHQDddFgUJHdTs53MGI DyNegXQOCynQFxQ4m4yRPmUVJIJZSxJtQ+ZsTykJycXxmK0wkljFT6cBBjLD9hmwd8X7 PCqg== X-Gm-Message-State: AOAM532qHX5KO/ttTNhiipZ/nG7gyQafxPCfgCsFNcgzBWqngnO0tolF PbX8S/Be7Rg4/ZZc74RqKjA= X-Google-Smtp-Source: ABdhPJx+r9Kd7fBIy3HbJ1tHNiiFYC4I/KPatgsV54iXTRXIXYQdzEuR5iV3Tq8TeR4qIJPUyq6JVg== X-Received: by 2002:a19:bd3:: with SMTP id 202mr1764566lfl.605.1610447364551; Tue, 12 Jan 2021 02:29:24 -0800 (PST) Original-Received: from [192.168.1.70] (109-252-80-63.nat.spd-mgts.ru. [109.252.80.63]) by smtp.gmail.com with ESMTPSA id b22sm337970lfp.233.2021.01.12.02.29.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jan 2021 02:29:23 -0800 (PST) In-Reply-To: <0f37c263-a361-7360-666a-4c7054ecf329@gmx.at> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197783 Archived-At: Yes, of course minibufferp is much cleaner - I just wasn't aware of its existence :) But the problem still persists if I refactor the code to use it. Here's the code I used: (define-minor-mode dvorak-minor-mode "Use english-dvorak input method." :lighter nil (if (and dvorak-minor-mode (not (minibufferp))) (activate-input-method "english-dvorak"))) (define-global-minor-mode global-dvorak-mode dvorak-minor-mode dvorak-minor-mode) (global-dvorak-mode t) Actually even removing (not (minibufferp)) altogether has no effect on the issue. Best regards, Platon Pronko