From: Dmitry Gutov <dgutov@yandex.ru>
To: "Simen Heggestøyl" <simenheg@runbox.com>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>,
41741@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#41741: [PATCH] Save project list as lisp data
Date: Sun, 7 Jun 2020 23:18:26 +0300 [thread overview]
Message-ID: <c773121e-09a0-964c-7244-6d58f8e9d6a0@yandex.ru> (raw)
In-Reply-To: <87wo4ips6d.fsf@simenheg@gmail.com>
On 07.06.2020 22:55, Simen Heggestøyl wrote:
> It is transient now, yes.
And later, it won't be?
> Just as an example I can imagine an optional feature in the future where
> you could name a project interactively the first time it's seen
> (i.e. when it's added to the project list for the first time).
And then lose all these annotations when a project root directory is
moved/renamed/etc?
But OK, maybe it won't happen too often to really worry about.
>>> - (when (file-exists-p filename)
>>> + (when (file-readable-p filename)
>>
>> What's the difference? File exists, but belongs to another account?
>> I'm not sure we'd want to silently fail in that case (kinda puzzling
>> behavior), and writing to the file is likely to fail later too.
>
> Hm, yes. I snatched that part from saveplace.el, but after you pointed
> it out I now also think it's better to get an error in that
> case. Reverted.
Perhaps we should change saveplace as well. :-)
>>> + (car (read-from-string (buffer-string))))))))
>>
>> AKA:
>>
>> (goto-char (point-min))
>> (read (current-buffer))
>>
>> Though the practical difference will be tiny.
>
> I don't mind changing it, but could you explain the difference to me? My
> understanding isn't deep enough to see anything but one line versus
> two. :)
Just an extra string allocation, I guess.
next prev parent reply other threads:[~2020-06-07 20:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <877dwkno62.fsf@simenheg@gmail.com>
2020-06-06 22:59 ` bug#41741: [PATCH] Save project list as lisp data Dmitry Gutov
2020-06-07 19:55 ` Simen Heggestøyl
[not found] ` <87wo4ips6d.fsf@simenheg@gmail.com>
2020-06-07 20:18 ` Dmitry Gutov [this message]
2020-06-08 19:00 ` Simen Heggestøyl
[not found] ` <873675jsbv.fsf@simenheg@gmail.com>
2020-06-08 20:32 ` Dmitry Gutov
2020-06-09 18:48 ` Simen Heggestøyl
2020-06-08 23:09 ` Juri Linkov
2020-06-08 23:39 ` Dmitry Gutov
2020-06-08 23:48 ` Drew Adams
2020-06-06 16:40 Simen Heggestøyl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c773121e-09a0-964c-7244-6d58f8e9d6a0@yandex.ru \
--to=dgutov@yandex.ru \
--cc=41741@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=juri@linkov.net \
--cc=simenheg@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).