From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Ponce Newsgroups: gmane.emacs.bugs Subject: bug#47819: 8.0.50; When :height/:width image attribute is specified, :scale factor is not applied Date: Fri, 16 Apr 2021 20:50:58 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31380"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 To: Alan Third , 47819@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 16 20:52:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXTZZ-00084r-Mw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Apr 2021 20:52:09 +0200 Original-Received: from localhost ([::1]:55672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXTZY-0000rj-I0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Apr 2021 14:52:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXTZR-0000rZ-VK for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 14:52:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58386) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXTZR-0007aE-Mv for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 14:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXTZR-0007jE-KO for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 14:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Apr 2021 18:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47819 X-GNU-PR-Package: emacs Original-Received: via spool by 47819-submit@debbugs.gnu.org id=B47819.161859907629653 (code B ref 47819); Fri, 16 Apr 2021 18:52:01 +0000 Original-Received: (at 47819) by debbugs.gnu.org; 16 Apr 2021 18:51:16 +0000 Original-Received: from localhost ([127.0.0.1]:41699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXTYe-0007i9-B7 for submit@debbugs.gnu.org; Fri, 16 Apr 2021 14:51:16 -0400 Original-Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:33440 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXTYY-0007ha-4s for 47819@debbugs.gnu.org; Fri, 16 Apr 2021 14:51:10 -0400 Original-Received: from [192.168.1.25] ([90.112.77.34]) by mwinf5d69 with ME id tWqy2400D0kQMCy03Wqysf; Fri, 16 Apr 2021 20:50:59 +0200 X-ME-Helo: [192.168.1.25] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Fri, 16 Apr 2021 20:50:59 +0200 X-ME-IP: 90.112.77.34 In-Reply-To: Content-Language: fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204157 Archived-At: On 16/04/2021 20:14, Alan Third wrote: > On Fri, Apr 16, 2021 at 08:16:20AM +0200, David Ponce wrote: >> Hello, >> >> For the image :scale attribute the Elisp reference manual say that: >> >> If both ‘:scale’ and ‘:height’/‘:width’ are >> specified, the height/width will be adjusted by the specified >> scaling factor. >> >> It seems, however, that this is not true, when the :height or :width >> or both attributes of an image are specified, the :scale factor is not >> applied. > > Hmm, I'm not sure which is the more desirable behaviour, but fixing it > to match the documentation appears to be trivial. See attached. > Hi Alan, Your patch fixed the issue for me, and now the specified :scale factor is applied when the :height/:width attributes are specified. IMHO, this is the right fix to be consistent with the documentation. At least because create-image apply a default scale factor, maybe for better rendering on high resolution screens. For ex., a default scale factor of 1.2 is applied on my laptop (1920x1080). Scaling could also make sense when height/width are specified in 'em'? Thanks!