From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f) Date: Thu, 27 Jun 2013 10:08:41 -0700 (PDT) Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1372353010 14234 80.91.229.3 (27 Jun 2013 17:10:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 27 Jun 2013 17:10:10 +0000 (UTC) To: 14734@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 27 19:10:10 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UsFhx-000594-QW for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2013 19:10:10 +0200 Original-Received: from localhost ([::1]:47005 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsFhx-00087s-8u for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2013 13:10:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsFhs-00083R-Hr for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 13:10:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsFhr-0004kk-0e for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 13:10:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsFhq-0004kR-Sh for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 13:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UsFhq-0007A8-9N for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 13:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2013 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.137235294427399 (code B ref -1); Thu, 27 Jun 2013 17:10:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Jun 2013 17:09:04 +0000 Original-Received: from localhost ([127.0.0.1]:45512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UsFgu-00077h-9D for submit@debbugs.gnu.org; Thu, 27 Jun 2013 13:09:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38657) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UsFgq-00076u-8b for submit@debbugs.gnu.org; Thu, 27 Jun 2013 13:09:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsFgg-0004It-HQ for submit@debbugs.gnu.org; Thu, 27 Jun 2013 13:08:55 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:44927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsFgg-0004Io-FA for submit@debbugs.gnu.org; Thu, 27 Jun 2013 13:08:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsFgd-0007Am-52 for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 13:08:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsFgb-0004I8-WA for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 13:08:47 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:31554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsFgb-0004I1-Pi for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 13:08:45 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r5RH2OCx029726 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Jun 2013 17:02:25 GMT Original-Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5RH8g0Y016558 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 27 Jun 2013 17:08:43 GMT Original-Received: from abhmt119.oracle.com (abhmt119.oracle.com [141.146.116.71]) by userz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5RH8gQQ016546 for ; Thu, 27 Jun 2013 17:08:42 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75645 Archived-At: emacs -Q (defadvice isearch-forward (before isearch+-doc activate) " Isearch Plus =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D ...") `C-h f isearch-forward' does not show this addition to the doc string at all. In Emacs 24.3 (and prior releases) there is no such bug. Furthermore, in the dev snapshot, you see this from `C-h f': :around advice: `ad-Advice-isearch-forward' That should NOT be shown. That is internal, implementation info. It is also incorrect. The advice is :before, not :around. And besides missing the added doc string text, this text that introduces it is also missing (present in Emacs 24.3 and prior, where the first line is bright red and bold): This function is advised. Before-advice `isearch+-doc': That is user-friendly info, and it is correct (:before, not :around). In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-06-20 on ODIEONE Bzr revision: 113100 eliz@gnu.org-20130620173624-w9v620tog4yacftk Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs CFLAGS=3D-O0 -g3 LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include'