unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 14734@debbugs.gnu.org
Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)
Date: Thu, 27 Jun 2013 10:08:41 -0700 (PDT)	[thread overview]
Message-ID: <c72999d0-4210-4719-934d-e9e06f522f70@default> (raw)

emacs -Q

(defadvice isearch-forward (before isearch+-doc activate)
  "
Isearch Plus
============
...")

`C-h f isearch-forward' does not show this addition to the doc string
at all.  In Emacs 24.3 (and prior releases) there is no such bug.

Furthermore, in the dev snapshot, you see this from `C-h f':

 :around advice: `ad-Advice-isearch-forward'

That should NOT be shown.  That is internal, implementation info.  It is
also incorrect.  The advice is :before, not :around.

And besides missing the added doc string text, this text that introduces
it is also missing (present in Emacs 24.3 and prior, where the first
line is bright red and bold):

 This function is advised.

 Before-advice `isearch+-doc':

That is user-friendly info, and it is correct (:before, not :around).

In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-06-20 on ODIEONE
Bzr revision: 113100 eliz@gnu.org-20130620173624-w9v620tog4yacftk
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
 CFLAGS=-O0 -g3 LDFLAGS=-Lc:/Devel/emacs/lib
 CPPFLAGS=-Ic:/Devel/emacs/include'





             reply	other threads:[~2013-06-27 17:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 17:08 Drew Adams [this message]
2013-06-27 18:15 ` bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f) Stefan Monnier
2013-06-27 18:40   ` Drew Adams
2013-06-28 17:39     ` Drew Adams
2013-06-28 20:44       ` Dmitry Gutov
2013-06-28 21:56         ` Drew Adams
2013-06-28 22:19           ` Michael Heerdegen
2019-09-23 21:07         ` bug#13581: " Lars Ingebrigtsen
2013-06-28 22:27   ` Michael Heerdegen
2013-06-28 23:21     ` Stefan Monnier
2013-06-29  1:37       ` Drew Adams
2013-06-29  2:09         ` Stefan Monnier
2013-06-29  2:28           ` Drew Adams
2013-06-29  3:24             ` Stefan Monnier
2013-06-29 20:29               ` Juanma Barranquero
2013-06-30  1:39                 ` Stefan Monnier
2013-07-05 14:50                   ` Drew Adams
2013-07-05 14:57                     ` Juanma Barranquero
2013-07-05 22:44                     ` Stefan Monnier
2013-07-06  1:40                       ` Drew Adams
2013-07-06  9:18                         ` Stefan Monnier
2013-07-06 20:22                           ` Drew Adams
2013-10-20 23:27               ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c72999d0-4210-4719-934d-e9e06f522f70@default \
    --to=drew.adams@oracle.com \
    --cc=14734@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).