From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f) Date: Fri, 28 Jun 2013 10:39:54 -0700 (PDT) Message-ID: References: <9cf39b5d-d100-4b72-bf78-95f6cee0d8c0@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1372441278 21866 80.91.229.3 (28 Jun 2013 17:41:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Jun 2013 17:41:18 +0000 (UTC) Cc: 14734@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 28 19:41:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uscfb-00062J-O9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jun 2013 19:41:15 +0200 Original-Received: from localhost ([::1]:40366 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uscfa-0008Fv-U9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jun 2013 13:41:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UscfS-00087F-37 for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2013 13:41:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UscfO-0008AR-UO for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2013 13:41:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UscfO-0008AB-IX for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2013 13:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UscfN-0006iu-My for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2013 13:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jun 2013 17:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 14734-submit@debbugs.gnu.org id=B14734.137244120925719 (code B ref 14734); Fri, 28 Jun 2013 17:41:01 +0000 Original-Received: (at 14734) by debbugs.gnu.org; 28 Jun 2013 17:40:09 +0000 Original-Received: from localhost ([127.0.0.1]:47196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UsceW-0006gi-8B for submit@debbugs.gnu.org; Fri, 28 Jun 2013 13:40:08 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:17551) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UsceS-0006g5-Ku for 14734@debbugs.gnu.org; Fri, 28 Jun 2013 13:40:05 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r5SHdu4k005764 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Jun 2013 17:39:57 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5SHdtpk028656 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 28 Jun 2013 17:39:56 GMT Original-Received: from abhmt106.oracle.com (abhmt106.oracle.com [141.146.116.58]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5SHdtZI021482; Fri, 28 Jun 2013 17:39:55 GMT In-Reply-To: <9cf39b5d-d100-4b72-bf78-95f6cee0d8c0@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75683 Archived-At: > > If you don't want to see the internal thingy, then use the new > > advice-add rather than the old defadvice. So you introduce a regression in user-visible behavior that degrades the user interface, with the idea that that will encourage use of your new advice replacement over traditional defadvice? Is that it? Using traditional advice to add to a doc string has always worked seamlessly: a user saw a single display of help text that included both the original doc and any doc added by advice, seamlessly. The change introduced is horrible for users. Now they see only the original doc string, plus a link that will be incomprehensible to many (so skipped over by them): :around advice: `ad-Advice-isearch-forward' And if they do happen to click that uninviting link then they get an even more incomprehensible page of internal, advice-oriented code and unintelligible text: ad-Advice-isearch-forward is a Lisp function. (ad-Advice-isearch-forward AD--ADDOIT-FUNCTION &optional REGEXP-P NO-RECURSIVE-EDIT) Advice function assembled by advice.el. Before-advice `isearch+-doc': =20 Isearch Plus =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D ... What they should see for `C-h f isearch-forward', and what they have always seen in the past, is the original `isearch-forward' doc together with the added doc from advising - it is just appended: Isearch Plus =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D ... Emacs did that by design. You have broken that. Not only can Emacs do better, it always HAS. This is a real step backward for users. Intentional or not. I'm reopening the bug. I hope you will seriously consider reverting the misguided changes that introduced this regression.