bug#29215: 26.0; `dired-isearch-filter-filesnames`: be able to match prefix

bug#29215: 26.0; `dired-isearch-filter-filesnames`: be able to match prefix

[Drew Adams]

1. Typo in first line of doc string:

   Test whether the current search hit is a file name.

   It does not test whether the search hit is a file name.
   It tests whether the search hit is IN a file name.

2. Please provide a fix or enhancement that lets users match a search
   pattern at the beginning of a file name.  With
   `dired-isearch-filenames-regexp', for example, using "`\f" or "^f"
   does not match a file name that begins with "f".  It's not obvious
   how to match the beginning of a file name.



In GNU Emacs 26.0.90 (build 3, x86_64-w64-mingw32)
 of 2017-10-13
Repository revision: 906224eba147bdfc0514090064e8e8f53160f1d4
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

bug#29215: 26.0; `dired-isearch-filter-filesnames`: be able to match prefix

[Drew Adams]

> 1. Typo in first line of doc string:
> 
>    Test whether the current search hit is a file name.
> 
>    It does not test whether the search hit is a file name.
>    It tests whether the search hit is IN a file name.

Actually, even that is incorrect.  The actual behavior is
to test whether ANY PART OF the search hit is in a file
name.  That is, if the search string matches any part of
a file name then this returns non-nil.

For example, if you search for "3  h" and there is a file
name that begins with "h" and its last-modified date, as
displayed in Dired, ends with "3", then this predicate
returns non-nil and the search commands that use the
predicate successfully find that file name.

This is not obvious.

bug#29215: 26.0; `dired-isearch-filter-filesnames`: be able to match prefix

[Eli Zaretskii]

> Date: Wed, 8 Nov 2017 08:13:17 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> 
> 1. Typo in first line of doc string:
> 
>    Test whether the current search hit is a file name.
> 
>    It does not test whether the search hit is a file name.
>    It tests whether the search hit is IN a file name.
> 
> 2. Please provide a fix or enhancement that lets users match a search
>    pattern at the beginning of a file name.  With
>    `dired-isearch-filenames-regexp', for example, using "`\f" or "^f"
>    does not match a file name that begins with "f".  It's not obvious
>    how to match the beginning of a file name.

Thanks, I fixed the first item on the release branch.

(Lumping more than one issue in the same report is baaad, mmkay?)