From: Drew Adams <drew.adams@oracle.com>
To: 15047@debbugs.gnu.org
Subject: bug#15047: 24.3.50; doc string of `find-listp-find-files' etc.
Date: Wed, 7 Aug 2013 15:06:23 -0700 (PDT) [thread overview]
Message-ID: <c6ae2502-c131-4e68-a5ac-3dc6a29c32ee@default> (raw)
The doc should distinguish between the files _within_ a directory, i.e.,
descending into its subdirectories recursively, and the files in a
directory, i.e., not including in descendent directories.
Pick any terminology you like, but please make it clear.
1. `find-listp-find-files': The doc of does not at all indicate that it
in fact searches also subdirectories, recursively.
2. `find-lisp-find-files-internal': The doc says that
"DIRECTORY-PREDICATE is used to decide...", but it does not say how,
which is central to the meaning of DIRECTORY-PREDICATE. Just say that
if DIRECTORY-PREDICATE returns non-nil then descend into subdirs etc.
3. `find-lisp-find-dired-internal': The doc says "Run find...".
Please change this to "Run `find'...".
4. `find-lisp-find-dired-filter': Please replace the doc string with
something correct or useful. The command does not "change the
filter..." or anything of the kind. And please wrap function names with
`...' in doc.
5. `find-lisp-format': Add a doc string. You "lifted" this from
ls-lisp.el, but you neglected to lift the doc string along with it.
6. `find-lisp-time-index', `find-lisp-format-time': Replace the code
comments with doc strings. This is the 21st century; we can afford
the extra cost. ;-)
7. `find-lisp-find-dired-insert-file': Add a doc string.
In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
of 2013-08-02 on ODIEONE
Bzr revision: 113660 lekktu@gmail.com-20130802160313-rbi3o6322mz0m3ye
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
CFLAGS=-O0 -g3 LDFLAGS=-Lc:/Devel/emacs/lib
CPPFLAGS=-Ic:/Devel/emacs/include'
next reply other threads:[~2013-08-07 22:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 22:06 Drew Adams [this message]
2016-04-29 13:36 ` bug#15047: 24.3.50; doc string of `find-listp-find-files' etc Lars Ingebrigtsen
2016-04-29 17:19 ` Drew Adams
2016-05-01 13:46 ` Michael Heerdegen
2016-05-01 14:28 ` Drew Adams
2016-05-01 15:12 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6ae2502-c131-4e68-a5ac-3dc6a29c32ee@default \
--to=drew.adams@oracle.com \
--cc=15047@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).