From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#70577: [PATCH] New command other-project-prefix Date: Sun, 5 May 2024 21:55:15 +0300 Message-ID: References: <86le501ykg.fsf@mail.linkov.net> <86jzkhe81b.fsf@mail.linkov.net> <208c7a05-6cfe-40c2-af54-187967348686@gutov.dev> <86le4tz88d.fsf@mail.linkov.net> <865xvsjklh.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------htynviPQJi3KUwdjNWZds0im" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9141"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 70577@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 05 20:55:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3h1f-00027L-PF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 May 2024 20:55:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3h1S-0004cd-5A; Sun, 05 May 2024 14:55:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3h1P-0004cL-13 for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 14:55:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3h1O-0007qB-OF for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 14:55:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s3h1m-0005mq-6Y for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 14:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 May 2024 18:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70577-submit@debbugs.gnu.org id=B70577.171493535522236 (code B ref 70577); Sun, 05 May 2024 18:56:02 +0000 Original-Received: (at 70577) by debbugs.gnu.org; 5 May 2024 18:55:55 +0000 Original-Received: from localhost ([127.0.0.1]:33052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3h1c-0005mY-LD for submit@debbugs.gnu.org; Sun, 05 May 2024 14:55:54 -0400 Original-Received: from wfout2-smtp.messagingengine.com ([64.147.123.145]:51527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3h1X-0005mQ-Sx for 70577@debbugs.gnu.org; Sun, 05 May 2024 14:55:50 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.west.internal (Postfix) with ESMTP id 4E18A1C000D7; Sun, 5 May 2024 14:55:18 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 05 May 2024 14:55:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1714935317; x=1715021717; bh=CmZWpdZgAF pC8IDLc0b0drERaMIxTvnf3s5rqYkqgbk=; b=qEU6CcGrNOPNHC5IXvoelEhChv 7/XzqqmPCBRXxBzc91f83sDDVFFVMhrWVBbGyQLgah4lxAFW+RfTXD7Hv9L9GNcN rpGGb7OGw2ubbgYmJNEPSl8Kw1mmpN8m7CQk/jHK9ZAPFKqnpKp2N+3YSlAFlr14 NrPe/9QE8gwz7VRPNdIshPwXfzCrY/u1YwENkqSrw+w6gPG9x1aWWg8rbkc3YY65 fuNLe9iyqgVkTH41gXLYOa5uRUMXEvwojyNKV57yxZ6tkTSAjxiMQefXPoKO6shk ghNxZ9M6oz2cGoVYIRZ2RGJAM5X1HwrWWe4Wtehovki6Ue9/sxxMnnBWCZJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1714935317; x=1715021717; bh=CmZWpdZgAFpC8IDLc0b0drERaMIx Tvnf3s5rqYkqgbk=; b=WDV9rp3G6lib+D9J+pORj+bethiN5LaPuAfbHva2zXUx TNdyk/4g5ZXi6YI37wUyn92afB1DsqQEXUuf+vznkIEDoV/QoxtTmFFHG3CsHKm5 AfxbzlRAHdl3QcXHXp/hxFR8qwmIgbsZcGf83QLZm+VGVijcgrg86ciq2m+bNJIH z5wg8x+F3G6WodInLtbFH5bU9EETejIntN3l3L9TTbNvPLjLLRmP+R7HFMH1kmtS XYD1ZTCathtq7VhaZMJtSdFKntEkos/LuFk21bbRICuk2DKlfgylAHuSKXsdKRsJ 4r0wqgpbcRfH7CquXFYsBY9THmX4fvpwMrjZKN9Xpg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvgedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtkfffgggfuffvvehfhfgjsehmtderredtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepleekjeeivdfftdegjedvffffleeuleekhfdtkeejheeugfetudehgeefhfei keejnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 May 2024 14:55:16 -0400 (EDT) Content-Language: en-US In-Reply-To: <865xvsjklh.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284539 Archived-At: This is a multi-part message in MIME format. --------------htynviPQJi3KUwdjNWZds0im Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/05/2024 19:40, Juri Linkov wrote: >> We would want 'C-h' to show the regular buffer with key bindings, won't we? >> With similar output to the one that we get after 'C-x p C-h' or 'C-x >> v C-h'. The output might be weirder because of the composed keymap, but it >> could still be useful. > > Then maybe something like > > (define-key map (vector help-char) > (lambda () (interactive) (describe-bindings))) > > or > > (define-key map (vector help-char) > (lambda () (interactive) (describe-keymap (cons 'keymap (current-active-maps))))) > > or > > (define-key map (vector help-char) > (lambda () (interactive) (describe-keymap (cons 'keymap project-prefix-map)))) This actually seems unnecessary. See the attached latest version where the binding works automatically without explicit assignment. >>> However, a much bigger problem is that unfortunately many test cases from >>> https://debbugs.gnu.org/63648#203 are broken. For example, >>> 'C-x p p C-b' fails the same way as in bug#58784. >>> 'C-x p p f M-n' fails because it expects to read arguments >>> in a previous project with an old value of default-directory, etc. >> >> Thanks for noticing. Looks like the call to project-prompter can change the >> value of this-command, and that's why the subsequent check went down the >> wrong branch. See the attached v3 with the fix. > > Wow, everything works now, will test more as a primary 'C-x p p' command. Thanks, let me know if you find any other problems. --------------htynviPQJi3KUwdjNWZds0im Content-Type: text/x-patch; charset=UTF-8; name="other-project-prefix-v4.diff" Content-Disposition: attachment; filename="other-project-prefix-v4.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rl cy9wcm9qZWN0LmVsCmluZGV4IDUyZmU0ZGY5MDgwLi5lNDFhMjNmZTEzZCAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9wcm9q ZWN0LmVsCkBAIC05NjcsNiArOTY3LDQ1IEBAIHByb2plY3Qtb3RoZXItdGFiLWNvbW1hbmQK ICh3aGVuIChib3VuZC1hbmQtdHJ1ZS1wIHRhYi1wcmVmaXgtbWFwKQogICAoZGVmaW5lLWtl eSB0YWItcHJlZml4LW1hcCAicCIgIydwcm9qZWN0LW90aGVyLXRhYi1jb21tYW5kKSkKIAor Ozs7IyMjYXV0b2xvYWQKKyhkZWZ1biBvdGhlci1wcm9qZWN0LXByZWZpeCAoKQorICAiXCJT d2l0Y2hcIiB0byBhbm90aGVyIHByb2plY3QgYmVmb3JlIHJ1bm5pbmcgYW4gRW1hY3MgY29t bWFuZC4KK1RoZSBuZXh0IGNvbW1hbmQgeW91IGludm9rZSB3aWxsIHByb21wdCBmb3IgdGhl IHByb2plY3QgaW4gd2hpY2ggdG8gcnVuCit0aGUgY29tbWFuZC4iCisgIChpbnRlcmFjdGl2 ZSkKKyAgKHByZWZpeC1jb21tYW5kLXByZXNlcnZlLXN0YXRlKQorICAobGV0cmVjICgoZGVw dGggKG1pbmlidWZmZXItZGVwdGgpKQorICAgICAgICAgICAoZWNob2Z1biAobGFtYmRhICgp ICJbc3dpdGNoLXByb2plY3RdIikpCisgICAgICAgICAgIChhcm91bmQtZnVuCisgICAgICAg ICAgICAobGFtYmRhIChjb21tYW5kICZyZXN0IF9hcmdzKQorICAgICAgICAgICAgICAoaW50 ZXJhY3RpdmUpCisgICAgICAgICAgICAgIChhZHZpY2UtcmVtb3ZlIHRoaXMtY29tbWFuZCBh cm91bmQtZnVuKQorICAgICAgICAgICAgICAoaWYgKG9yIChlcSB0aGlzLWNvbW1hbmQgJ290 aGVyLXByb2plY3QtcHJlZml4KQorICAgICAgICAgICAgICAgICAgICAgICAgICAoZXEgbGFz dC1jb21tYW5kLWV2ZW50IGhlbHAtY2hhcikpCisgICAgICAgICAgICAgICAgICAoY2FsbC1p bnRlcmFjdGl2ZWx5IGNvbW1hbmQpCisgICAgICAgICAgICAgICAgKGxldCogKCh0aGlzLWNv bW1hbmQtc2F2ZWQgdGhpcy1jb21tYW5kKQorICAgICAgICAgICAgICAgICAgICAgICAocm9v dCAoZnVuY2FsbCBwcm9qZWN0LXByb21wdGVyKSkpCisgICAgICAgICAgICAgICAgICAoaWYg KG9yIChzdHJpbmctcHJlZml4LXAgInByb2plY3QtIgorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChzeW1ib2wtbmFtZSB0aGlzLWNvbW1hbmQtc2F2ZWQp KQorICAgICAgICAgICAgICAgICAgICAgICAgICAoZ2V0IHRoaXMtY29tbWFuZC1zYXZlZCAn cHJvamVjdC1hd2FyZSkpCisgICAgICAgICAgICAgICAgICAgICAgKGxldCAoKHByb2plY3Qt Y3VycmVudC1kaXJlY3Rvcnktb3ZlcnJpZGUgcm9vdCkpCisgICAgICAgICAgICAgICAgICAg ICAgICAoY2FsbC1pbnRlcmFjdGl2ZWx5IGNvbW1hbmQpKQorICAgICAgICAgICAgICAgICAg ICAobGV0ICgoZGVmYXVsdC1kaXJlY3Rvcnkgcm9vdCkpCisgICAgICAgICAgICAgICAgICAg ICAgKGNhbGwtaW50ZXJhY3RpdmVseSBjb21tYW5kKSkpKSkpKQorICAgICAgICAgICAocHJl ZnVuCisgICAgICAgICAgICAobGFtYmRhICgpCisgICAgICAgICAgICAgICh1bmxlc3MgKD4g KG1pbmlidWZmZXItZGVwdGgpIGRlcHRoKQorICAgICAgICAgICAgICAgIChyZW1vdmUtaG9v ayAncHJlLWNvbW1hbmQtaG9vayBwcmVmdW4pCisgICAgICAgICAgICAgICAgKHJlbW92ZS1o b29rICdwcmVmaXgtY29tbWFuZC1lY2hvLWtleXN0cm9rZXMtZnVuY3Rpb25zIGVjaG9mdW4p CisgICAgICAgICAgICAgICAgKHdoZW4gKGFuZCB0aGlzLWNvbW1hbmQgKHN5bWJvbHAgdGhp cy1jb21tYW5kKSkKKyAgICAgICAgICAgICAgICAgIChhZHZpY2UtYWRkIHRoaXMtY29tbWFu ZCA6YXJvdW5kIGFyb3VuZC1mdW4pKSkpKSkKKyAgICAoYWRkLWhvb2sgJ3ByZS1jb21tYW5k LWhvb2sgcHJlZnVuKQorICAgIChhZGQtaG9vayAncHJlZml4LWNvbW1hbmQtZWNoby1rZXlz dHJva2VzLWZ1bmN0aW9ucyBlY2hvZnVuKQorICAgIChzZXQtdHJhbnNpZW50LW1hcCBwcm9q ZWN0LXByZWZpeC1tYXApCisgICAgKG1lc3NhZ2UgKGNvbmNhdCAiVHlwZSAiIChwcm9qZWN0 LS1rZXltYXAtcHJvbXB0KSAiIG9yIGFueSBnbG9iYWwga2V5IikpKSkKKworOzsgKGRlZmlu ZS1rZXkgcHJvamVjdC1wcmVmaXgtbWFwIChrYmQgIlAiKSAjJ290aGVyLXByb2plY3QtcHJl Zml4KQorCiAoZGVjbGFyZS1mdW5jdGlvbiBncmVwLXJlYWQtZmlsZXMgImdyZXAiKQogKGRl Y2xhcmUtZnVuY3Rpb24geHJlZi0tZmluZC1pZ25vcmVzLWFyZ3VtZW50cyAieHJlZiIpCiAK --------------htynviPQJi3KUwdjNWZds0im--