From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#51270: 28.0.50; xref core package 1.3.0 published, breaks etags Date: Tue, 19 Oct 2021 00:40:44 +0300 Message-ID: References: <87sfwyej4f.fsf@kenko.localhost.com> <35441e56-49ed-480c-7a60-ffce7c173912@yandex.ru> <87mtn6ca0q.fsf@kenko.localhost.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7383"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 To: Ingo Lohmar , 51270@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 18 23:41:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcaNl-0001gu-AF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Oct 2021 23:41:21 +0200 Original-Received: from localhost ([::1]:48360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcaNj-0002OS-TN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Oct 2021 17:41:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcaNS-0002OC-V7 for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 17:41:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37233) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcaNS-0006eY-Lx for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 17:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mcaNS-00032r-D4 for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 17:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Oct 2021 21:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51270 X-GNU-PR-Package: emacs Original-Received: via spool by 51270-submit@debbugs.gnu.org id=B51270.163459325411685 (code B ref 51270); Mon, 18 Oct 2021 21:41:02 +0000 Original-Received: (at 51270) by debbugs.gnu.org; 18 Oct 2021 21:40:54 +0000 Original-Received: from localhost ([127.0.0.1]:48779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcaNJ-00032P-SE for submit@debbugs.gnu.org; Mon, 18 Oct 2021 17:40:54 -0400 Original-Received: from mail-lf1-f48.google.com ([209.85.167.48]:34315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcaNH-00032B-Ah for 51270@debbugs.gnu.org; Mon, 18 Oct 2021 17:40:52 -0400 Original-Received: by mail-lf1-f48.google.com with SMTP id t9so2797512lfd.1 for <51270@debbugs.gnu.org>; Mon, 18 Oct 2021 14:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DAPlMQB58lg0FZ5cnRpbvoZunvFLbQ8+yJsbQDE5dRQ=; b=OvBVhaXNnS8qzgRaUlCsJTDIGzdRakdXDt7hSgh55X8QnKpESSYhkybZlXIu0YI5Na UfRL4jp1NAxP+O1FPQDJIcfaCpUuy7yBVilTqDP3Op3301K0sf4z2YoccJ1XpLkQxIhV RkGMaBAA/XyZ6G4mrzH6+7byuCGh9EnFFWjgXVI+vc3/XM+mMpTRBkGjVJoZyJzJ6J1B 1M4sJJCV0RfMujOChN/23lsFW83MgH8szK1APMxxFNalk6qdsz7zPK19h37NQCmcC7LN OvR+7/KOYfQ/KGeA2a5EpVsOpRhh6v0zNHpXR1O0BX2/9XFZTLLjAjVjV348RbA3Fzrn otzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DAPlMQB58lg0FZ5cnRpbvoZunvFLbQ8+yJsbQDE5dRQ=; b=3vgP7n+13sW8ffL1kEwDDtV8bx+D6zpAw2IdIXZhhvQlW3U0DRZdCLKgjm65GRTDio cK3BMfFEXdNYuyJPZdgKwOcrjvIv90h1vHzLF4dz5CSQZ529ikfLRjVw/n05aDnYc4Qc Adx0eDbffTPbS8IU3TJSEKZSj7mKd3Ig7J6TBBL3t8IwZtJzyT669u5wRJai12UTm6/H 1LHEVMFKRdMsH13DYtnmzPHax9KmCjnRmhwKTwZYudciIYO09dzAJGUIk1JYG/pu74MT hHj/DiMXlA3OEsxO62dGPMEoxkQk+L41sNZgxf/Jtxy8dKVHXqnVExH6rGlGGbksRX/c qRqQ== X-Gm-Message-State: AOAM5313jXND/gAect5gUjWlBcvq9awLnt4RV6hbUn6DI2JBhsPdI0/K 6iX+fBfFBGTc89a1Q8gzqlq0ctsLfhg= X-Google-Smtp-Source: ABdhPJzxBkquEu+C1QOeJmIMthGWL5A4SlN2uLnb2ziT75p6H4jzPE9+fbZbkml2mcI/kZnLC8tQqw== X-Received: by 2002:a05:6512:b8b:: with SMTP id b11mr2152511lfv.177.1634593245244; Mon, 18 Oct 2021 14:40:45 -0700 (PDT) Original-Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id x10sm1498510lfr.72.2021.10.18.14.40.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Oct 2021 14:40:44 -0700 (PDT) In-Reply-To: <87mtn6ca0q.fsf@kenko.localhost.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217524 Archived-At: On 19.10.2021 00:12, Ingo Lohmar wrote: > On Mon, Oct 18 2021 23:38 (+0300), Dmitry Gutov wrote: > >>> The breakage happens because xref 1.3.0 has been published on GNU ELPA >>> https://elpa.gnu.org/packages/ (although the details page shows 1.2.2 as >>> the latest version, don't know why). I am using the "eglot" package, >>> which requires xref (at a lower minimum version), and when upgrading >>> packages this morning, I got xref 1.3.0. >> >> Which version of Emacs are you using? I understand Emacs 26 might have a >> problem with :noinline instructions in the new struct definitions. > > I am using the feature/pgtk branch, which is currently based on an older > master (roughly 3m ago) it seems. Ah, that's what it is! >> But as for loading eieio and defining the xref-location class, the >> top-level version check at the beginning of xref.el should supposedly >> help. It looks like: >> >> (eval-and-compile >> (when (version< emacs-version "28") >> ;; etags.el in Emacs 26 and 27 uses EIEIO, and its location type >> ;; inherits from `xref-location'. >> (require 'eieio) >> (with-no-warnings >> (defclass xref-location () () >> :documentation "...")))) > > Ah, I did not look at the 1.3.0 file. So the above will help for all > released emacs versions, but will just not run for a non-recent master > of Emacs 28, get it. Yes, an update to a more recent emacs-28 should fix it. pgtk is indeed a fair bit out of date. Perhaps we could compare the version more finely to "28.0.60", to cut off most older builds. That 3 month old version advertises itself as "28.0.50", right? > I don't have a backtrace yet, but can provide one if it's helpful for > related questions. I guess I will just manually move xref-1.3.0 out of > the way until I can update to a newer Emacs master (which will then > include the coordinated xref/etags changes). Sounds good. And pgtk might as well do a merge from master (it won't be in Emacs 28 apparently).