From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#48180: ruby-mode.el: fix font lock for puts and printf Date: Mon, 3 May 2021 13:17:48 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18857"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 To: Steve Purcell , 48180@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 03 12:18:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldVeW-0004m0-B1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 12:18:12 +0200 Original-Received: from localhost ([::1]:56660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldVeV-0007is-Dx for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 06:18:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldVeM-0007ex-0j for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 06:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34719) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldVeL-0002ZJ-Oq for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 06:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldVeL-0006R9-Jp for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 06:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 May 2021 10:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48180 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 48180-submit@debbugs.gnu.org id=B48180.162003707824737 (code B ref 48180); Mon, 03 May 2021 10:18:01 +0000 Original-Received: (at 48180) by debbugs.gnu.org; 3 May 2021 10:17:58 +0000 Original-Received: from localhost ([127.0.0.1]:46265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldVeI-0006Qv-G0 for submit@debbugs.gnu.org; Mon, 03 May 2021 06:17:58 -0400 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:44596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldVeG-0006Qp-Eu for 48180@debbugs.gnu.org; Mon, 03 May 2021 06:17:57 -0400 Original-Received: by mail-wm1-f43.google.com with SMTP id 82-20020a1c01550000b0290142562ff7c9so3207508wmb.3 for <48180@debbugs.gnu.org>; Mon, 03 May 2021 03:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Yrd4FfVKqq7GVxveaaeqzVjjD9xB2ZmqQUS4FlkhJ08=; b=FM57gs39Af7/i3xcWwjDv44N34Ye5Qg7qreiB8PsBC1f0Rf9A+OayWrr0e53sC1qzF hYjdwSMJ6TKYp4uWlD8iaWCp+nhIgt1R3/1PPp7mWCPbn0Ua2QJ8s/J0wGCWzR1cNFZa Y9uCp4DsgCEGPJBfHtp+0cRhdBFiEpclmPvcdBJpYZ/3pQiih5iJBPk9zqvnrYWJaaFD mN7Fyu8qboEQAQ2zzNA5v67mdOPMGcSKvd7rMyH4axL+DBkyDSNqtTr/Zn6plYLPaHcL YsfudYw5VWOxBAp/y83JPMhrdbo02gU2NkN/qvJbASn1cnFfI0MlAXfl1Jg89qFK/Zio KcBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Yrd4FfVKqq7GVxveaaeqzVjjD9xB2ZmqQUS4FlkhJ08=; b=raXjHXmAVCtcJxxRSMCr+CMvERhdP09Ds8s1VHtKdcukOStVdDFQfRmv46XreW9n24 T6Qr3acKW1EDpvGpz5+nVhWKYAkjbhYtO0e+N3SnZflD7LyA8X+3MplwpArLyF1ST7H0 tLFpdZGt20J5HMLB8SLGAjlafnHz27IEJEPTz7z5Xmc/zWUliiSdQFqckBTM+xOkNiF4 pS5nZkOf8uY8ybL65ngtVn47eYkcByzLVH1lFp0xspE6prjw2T/BGfOnpiQllXogkTve lh6UboZi+ZiZ1psbmYR7lH+blcKrlQzvOLzeBqLn6v9vOR5CpdfyoEWOqXynwSHNpO3H 0VxQ== X-Gm-Message-State: AOAM530ycvKQlU4gV75EWf0FlXpg7DduVpfdsguYc+8OLAh4YfObyBim jdHCNO/HubU4AH+BQ54fQa1TRywZM6A= X-Google-Smtp-Source: ABdhPJyhkSyOOuExeeabsRD/vcZm8eOEsj4cnltJU2Kex7C/FT3KvAmI12NWft4SyKyVwSO2KSR80g== X-Received: by 2002:a05:600c:4303:: with SMTP id p3mr20924297wme.166.1620037070599; Mon, 03 May 2021 03:17:50 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v20sm11212104wmj.15.2021.05.03.03.17.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 May 2021 03:17:49 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205496 Archived-At: Hi Steve, On 03.05.2021 04:01, Steve Purcell wrote: > Both these methods can be called without arguments, so the font > locking of "bare" calls to either is incorrect. The fix is to > font-lock them as for other kernel methods which accepts zero or more > arguments. Is that important? Like, is anybody likely to call either without args? font-lock is not a precise facility (that anything depends on), so we can afford to be wrong in 0.01% cases. If we institute this principle, I suppose we'll need to do this for all functions that can work without args? In my testing, that's also: p, open, loop, warn, print Also note that your title says 'printf', but the patch said 'print'.