From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67569: 29.1; ruby-mode syntax highlighting breaks with variable named "index" and "/" operator Date: Sat, 9 Dec 2023 19:38:28 +0200 Message-ID: References: <0ee4ce91-c344-4859-8b13-07de5876368d@gutov.dev> <83zfyjwiiy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------KjOLRv5WZ90ES1oslfz2bcb8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26897"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: mjh@mjhoy.com, 67569@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 09 18:40:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rC1J9-0006mW-5r for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Dec 2023 18:40:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rC1It-00011N-MA; Sat, 09 Dec 2023 12:39:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rC1Ir-00010a-G8 for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2023 12:39:49 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rC1Ir-0005oe-77 for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2023 12:39:49 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rC1J4-0000vO-1h for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2023 12:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Dec 2023 17:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67569 X-GNU-PR-Package: emacs Original-Received: via spool by 67569-submit@debbugs.gnu.org id=B67569.17021435433463 (code B ref 67569); Sat, 09 Dec 2023 17:40:02 +0000 Original-Received: (at 67569) by debbugs.gnu.org; 9 Dec 2023 17:39:03 +0000 Original-Received: from localhost ([127.0.0.1]:48857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rC1I3-0000tS-V4 for submit@debbugs.gnu.org; Sat, 09 Dec 2023 12:39:03 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:50135) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rC1Hz-0000t9-6h for 67569@debbugs.gnu.org; Sat, 09 Dec 2023 12:38:58 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5E6605C010E; Sat, 9 Dec 2023 12:38:35 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 09 Dec 2023 12:38:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1702143515; x=1702229915; bh=XR nZSVNTrQXbc8R8B+RUeLI7pGv7Uyh65l4IygjPFgg=; b=Dj1bF+zOI83VLvJXud ULhEIcQNoN2PCY2a9N/eihcOYi5Hno0boFmRayz1cxy1XUswIc9gVPh8+fHQDUpD ejt00dRsgJk90zUVSfkMhwPjhcBqp7rdvPhEQwSyqJjsTSyyCdPtVoQZZLwydu5B Eyz/7ZtPaa4D8n14kkiR0gLDqoYLWx/LzUJTLDvGQQyteISP+kTQXR7JJy9tWZlS AXvX/IR1CZz0be+pTjpjEzVXe0g4uALKu/GC5pnOCM+/j6M99Mn4HCsSivFylQrL 3aiiS0bUnCQwPSIkK9Bi25sxIh2kqLUp1rjEBAc3hqtdOqFCE8N32CidpNOdvgQ6 CLLQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1702143515; x=1702229915; bh=XRnZSVNTrQXbc 8R8B+RUeLI7pGv7Uyh65l4IygjPFgg=; b=sypG9PLIZ+r9+eP0GedohxN5tqTrU UqJi3BHBciSyTzyKDBVr/NCz9RzUeDSa8huRJRoVxyAxRnfwBDhI5H7pKQzSBghh W66BJyog+DpRZuEXALkDwTAZZ/FgWgfUvycVxRX3wWbKtBrCJKaC694dyL2X761H ZU/xY+iIw95vHyJxLBqameWlMSr7IROklfaBCCl58h2upuiR08nAH9xpZiEmqBd4 FtEDDeA75JmbytN+I7suOGqiHnW+g82XdxnvuyfvV4UQmCAZ5gBr+Ui5FhpipUai 2J3gFCvWN/yXcaMH5PWYkA6Z5ByWZLlkI/kDnmrjbaMnHq9P912K3ZwdA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekkedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtkfffgggfuffvvehfhfgjsehmtderredtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepheetkefgteeiueejuedvtddvleetffeljeetuddvfeffjeeiheehueetffev ieejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 9 Dec 2023 12:38:33 -0500 (EST) Content-Language: en-US In-Reply-To: <83zfyjwiiy.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275871 Archived-At: This is a multi-part message in MIME format. --------------KjOLRv5WZ90ES1oslfz2bcb8 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/12/2023 16:35, Eli Zaretskii wrote: >> Date: Sat, 9 Dec 2023 16:13:02 +0200 >> From: Dmitry Gutov >> >> Eli, should we put this in Emacs 29.2? It's not a regression (a fairly >> old problem), but the fix looks simple enough. > Yes, please. Very good, pushed to emacs-29. Here's a second patch on top which gets rid of the whitelist altogether (the new heuristic seems to cover the cases better anyway), though I'm on the fence whether this should go here or into master. It seems to work well with some testing, but it is more adventurous than the previous one. --------------KjOLRv5WZ90ES1oslfz2bcb8 Content-Type: text/x-patch; charset=UTF-8; name="ruby-parenless-regexp-no-whitelist.diff" Content-Disposition: attachment; filename="ruby-parenless-regexp-no-whitelist.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS5lbCBiL2xpc3AvcHJvZ21v ZGVzL3J1YnktbW9kZS5lbAppbmRleCAwZWNiMzU3OTI3OC4uODYyYWFmOGUxODIgMTAwNjQ0 Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rl cy9ydWJ5LW1vZGUuZWwKQEAgLTIxMDUsMTIgKzIxMDUsNiBAQCBydWJ5LWZpbmQtbGlicmFy eS1maWxlCiAgICAgIlxcKCVcXClbcVFyc3dXeElpXT9cXChbWzpwdW5jdDpdXVxcKSIKICAg ICAiUmVnZXhwIHRvIG1hdGNoIHRoZSBiZWdpbm5pbmcgb2YgcGVyY2VudCBsaXRlcmFsLiIp CiAKLSAgKGRlZmNvbnN0IHJ1Ynktc3ludGF4LW1ldGhvZHMtYmVmb3JlLXJlZ2V4cAotICAg ICcoImdzdWIiICJnc3ViISIgInN1YiIgInN1YiEiICJzY2FuIiAic3BsaXQiICJzcGxpdCEi ICJpbmRleCIgIm1hdGNoIgotICAgICAgImFzc2VydF9tYXRjaCIgIkdpdmVuIiAiVGhlbiIg IldoZW4iKQotICAgICJNZXRob2RzIHRoYXQgY2FuIHRha2UgcmVnZXhwIGFzIHRoZSBmaXJz dCBhcmd1bWVudC4KLUl0IHdpbGwgYmUgcHJvcGVybHkgaGlnaGxpZ2h0ZWQgZXZlbiB3aGVu IHRoZSBjYWxsIG9taXRzIHBhcmVucy4iKQotCiAgIChkZWZ2YXIgcnVieS1zeW50YXgtYmVm b3JlLXJlZ2V4cC1yZQogICAgIChjb25jYXQKICAgICAgOzsgU3BlY2lhbCB0b2tlbnMgdGhh dCBjYW4ndCBiZSBmb2xsb3dlZCBieSBhIGRpdmlzaW9uIG9wZXJhdG9yLgpAQCAtMjEyMiwx MSArMjExNiw5IEBAIHJ1YnktZmluZC1saWJyYXJ5LWZpbGUKICAgICAgIlxcfFxcKD86Xlxc fFxccyBcXCkiCiAgICAgIChyZWdleHAtb3B0ICcoImlmIiAiZWxzaWYiICJ1bmxlc3MiICJ3 aGlsZSIgInVudGlsIiAid2hlbiIgImFuZCIKICAgICAgICAgICAgICAgICAgICAib3IiICJu b3QiICImJiIgInx8IikpCi0gICAgIDs7IE1ldGhvZCBuYW1lIGZyb20gdGhlIGxpc3QuCi0g ICAgICJcXHxcXF88IgotICAgICAocmVnZXhwLW9wdCBydWJ5LXN5bnRheC1tZXRob2RzLWJl Zm9yZS1yZWdleHAgdCkKICAgICAgIlxcKVxccyAqIikKLSAgICAiUmVnZXhwIHRvIG1hdGNo IHRleHQgdGhhdCBjYW4gYmUgZm9sbG93ZWQgYnkgYSByZWd1bGFyIGV4cHJlc3Npb24uIikp CisgICAgIlJlZ2V4cCB0byBtYXRjaCB0ZXh0IHRoYXQgZGlzYW1iaWd1YXRlcyBhIHJlZ3Vs YXIgZXhwcmVzc2lvbi4KK0FueSBzbGFzaCBjaGFyYWN0ZXIgYWZ0ZXIgYW55IG9mIHRoZXNl IHNob3VsZCBiZWdpbiBhIHJlZ2V4cC4iKSkKIAogKGRlZnVuIHJ1Ynktc3ludGF4LXByb3Bl cnRpemUgKHN0YXJ0IGVuZCkKICAgIlN5bnRhY3RpYyBrZXl3b3JkcyBmb3IgUnVieSBtb2Rl LiAgU2VlIGBzeW50YXgtcHJvcGVydGl6ZS1mdW5jdGlvbicuIgpAQCAtMjE4MiwyMCArMjE3 NCwxOCBAQCBydWJ5LXN5bnRheC1wcm9wZXJ0aXplCiAgICAgICAgICh3aGVuIChzYXZlLWV4 Y3Vyc2lvbgogICAgICAgICAgICAgICAgIChmb3J3YXJkLWNoYXIgLTEpCiAgICAgICAgICAg ICAgICAgKGNsLWV2ZW5wIChza2lwLWNoYXJzLWJhY2t3YXJkICJcXFxcIikpKQotICAgICAg ICAgIChsZXQgKChzdGF0ZSAoc2F2ZS1leGN1cnNpb24gKHN5bnRheC1wcHNzIChtYXRjaC1i ZWdpbm5pbmcgMSkpKSkKLSAgICAgICAgICAgICAgICBkaXZpc2lvbi1saWtlKQorICAgICAg ICAgIChsZXQgKChzdGF0ZSAoc2F2ZS1leGN1cnNpb24gKHN5bnRheC1wcHNzIChtYXRjaC1i ZWdpbm5pbmcgMSkpKSkpCiAgICAgICAgICAgICAod2hlbiAob3IKICAgICAgICAgICAgICAg ICAgICA7OyBCZWdpbm5pbmcgb2YgYSByZWdleHAuCiAgICAgICAgICAgICAgICAgICAgKGFu ZCAobnVsbCAobnRoIDggc3RhdGUpKQotICAgICAgICAgICAgICAgICAgICAgICAgKHNhdmUt ZXhjdXJzaW9uCi0gICAgICAgICAgICAgICAgICAgICAgICAgIChzZXRxIGRpdmlzaW9uLWxp a2UKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG9yIChlcWwgKGNoYXItYWZ0 ZXIpID9ccykKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChub3QgKGVx bCAoY2hhci1iZWZvcmUgKDEtIChwb2ludCkpKSA/XHMpKSkpCi0gICAgICAgICAgICAgICAg ICAgICAgICAgIChmb3J3YXJkLWNoYXIgLTEpCi0gICAgICAgICAgICAgICAgICAgICAgICAg IChsb29raW5nLWJhY2sgcnVieS1zeW50YXgtYmVmb3JlLXJlZ2V4cC1yZQotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChsaW5lLWJlZ2lubmluZy1wb3NpdGlv bikpKQotICAgICAgICAgICAgICAgICAgICAgICAgKG5vdCAoYW5kIGRpdmlzaW9uLWxpa2UK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobWF0Y2gtYmVnaW5uaW5nIDIp KSkpCisgICAgICAgICAgICAgICAgICAgICAgICAob3IgKG5vdAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICA7OyBMb29rcyBsaWtlIGRpdmlzaW9uLgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAob3IgKGVxbCAoY2hhci1hZnRlcikgP1xzKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKG5vdCAoZXFsIChjaGFyLWJlZm9yZSAoMS0gKHBvaW50 KSkpID9ccykpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc2F2ZS1leGN1cnNp b24KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChmb3J3YXJkLWNoYXIgLTEpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobG9va2luZy1iYWNrIHJ1Ynktc3ludGF4 LWJlZm9yZS1yZWdleHAtcmUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKGxpbmUtYmVnaW5uaW5nLXBvc2l0aW9uKSkpKSkKICAgICAgICAgICAgICAg ICAgICA7OyBFbmQgb2YgcmVnZXhwLiAgV2UgZG9uJ3QgbWF0Y2ggdGhlIHdob2xlCiAgICAg ICAgICAgICAgICAgICAgOzsgcmVnZXhwIGF0IG9uY2UgYmVjYXVzZSBpdCBjYW4gaGF2ZQog ICAgICAgICAgICAgICAgICAgIDs7IHN0cmluZyBpbnRlcnBvbGF0aW9uIGluc2lkZSwgb3Ig c3BhbgpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUtcmVzb3Vy Y2VzL3J1YnkucmIgYi90ZXN0L2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS1yZXNvdXJjZXMv cnVieS5yYgppbmRleCA4MWQwZGZkNzVjOS4uYTQxMWIzOWE4ZmMgMTAwNjQ0Ci0tLSBhL3Rl c3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXJlc291cmNlcy9ydWJ5LnJiCisrKyBiL3Rl c3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXJlc291cmNlcy9ydWJ5LnJiCkBAIC0zNCwx MSArMzQsMTEgQEAgZGVmIGZvbwogIyBSZWdleHAgYWZ0ZXIgd2hpdGVsaXN0ZWQgbWV0aG9k LgogImFiYyIuc3ViIC9iLywgJ2QnCiAKLSMgRG9uJ3QgbWlzbWF0Y2ggInN1YiIgYXQgdGhl IGVuZCBvZiB3b3Jkcy4KLWEgPSBhc3ViIC8gYXNsYiArIGJzdWIgLyBic2xiOworIyBEb24n dCBtaXN0YWtlIGRpdmlzaW9uIGZvciByZWdleHAuCithID0gc3ViIC8gYXNsYiArIGJzdWIg LyBic2xiOwogCiAjIEhpZ2hsaWdodCB0aGUgcmVnZXhwIGFmdGVyICJpZiIuCi14ID0gdG90 byAvIGZvbyBpZiAvZG8gYmFyLyA9fiAiZG9iYXIiCit4ID0gdG90byAvIGZvbyBpZiAvIGRv IGJhci8gPX4gImRvYmFyIgogCiAjIFJlZ2V4cCBvcHRpb25zIGFyZSBoaWdobGlnaHRlZC4K IApkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUtdGVzdHMuZWwg Yi90ZXN0L2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS10ZXN0cy5lbAppbmRleCBhOTMxNTQx YmEzNS4uZmVhNWY1OGI5MmUgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcnVi eS1tb2RlLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXRl c3RzLmVsCkBAIC0xNjQsNyArMTY0LDcgQEAgcnVieS1zbGFzaC1ub3QtcmVnZXhwLXdoZW4t bm8tc3BhY2VzCiAgIChydWJ5LWFzc2VydC1zdGF0ZSAieCA9IGluZGV4LzMiIDMgbmlsKSkK IAogKGVydC1kZWZ0ZXN0IHJ1YnktcmVnZXhwLW5vdC1kaXZpc2lvbi13aGVuLW9ubHktc3Bh Y2UtYmVmb3JlICgpCi0gIChydWJ5LWFzc2VydC1zdGF0ZSAieCA9IGluZGV4IC8zIiAzID8v KSkKKyAgKHJ1YnktYXNzZXJ0LXN0YXRlICJ4ID0gZm9vX2luZGV4IC8zIiAzID8vKSkKIAog KGVydC1kZWZ0ZXN0IHJ1Ynktc2xhc2gtbm90LXJlZ2V4cC13aGVuLW9ubHktc3BhY2UtYWZ0 ZXIgKCkKICAgKHJ1YnktYXNzZXJ0LXN0YXRlICJ4ID0gaW5kZXgvIDMiIDMgbmlsKSkK --------------KjOLRv5WZ90ES1oslfz2bcb8--