On 2/9/23 19:46, Mauro Aranda wrote:
 > On 2/9/23 19:42, Stefan Kangas wrote:
 >  > Mauro Aranda <maurooaranda@gmail.com> writes:
 >  >
 >  >> The following user options:
 >  >> filesets-browse-dir-function
 >  >> filesets-open-file-function
 >  >> filesets-save-buffer-function
 >  >> filesets-commands
 >  >> filesets-external-viewers
 >  >>
 >  >> have overridden the default value of the function widget to the value
 >  >> nil.  That's an invalid default value.  It'd be better to just remove
 >  >> that.
 >  >
 >  > Makes sense, but you forgot to attach the patch.  ;-)
 >
 > I was writing it but then I found some other problems with the
 > defcustoms in filesets.el :-(
 >
 > I'll attach the patch trying to fix all of them (with a description of
 > the problems, of course).

OK, I found a couple of bugs.  To reproduce, with emacs -Q
(require 'filesets)
M-x customize-option RET filesets-commands
Move to the last INS button, the one that inserts a brand new command.
Hit RET:

INS DEL Definition:
             String:
             Command: Value Menu invalid (nil)
             Argument List:
             INS

invalid (nil) indicates a bad default value for the choice widget.  I
fixed that.


M-x customize-option RET filesets-external-viewers
Move to the INS button that inserts a Property for the last Definition.
Hit RET
INS DEL Definition:
             Pattern: .\.\(tiff\|xpm\|gif\|pgn\)\'
             Viewer: Value Menu Program: gqview
             Properties:
             INS DEL Choice: Value Menu :ignore-on-open-all:
                         Boolean: Toggle  on (non-nil)
             INS DEL Choice: Value Menu :ignore-on-read-text:
                         Boolean: Toggle  on (non-nil)
             INS DEL Choice: Value Menu invalid ((:constraintp))
             INS

invalid ((:constraintp)) indicates another bad default value.  I fixed
that, and other default values for the list widgets in this option.


One thing I observed is that there are lot of redundant tags in this
file, like (function :tag "Function").  But anyway, those aren't bugs,
so I didn't bothered.  I attach a patch for the emacs-29 branch.