From: Drew Adams <drew.adams@oracle.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: f92capac@gmail.com, tino.calancha@gmail.com,
9300@debbugs.gnu.org, Brief Busters <dgutov@yandex.ru>
Subject: bug#9300: 24.0.50; `bounds-of-thing-at-point' does not return nil when just after THING
Date: Mon, 20 Jun 2016 17:47:27 -0700 (PDT) [thread overview]
Message-ID: <c5565dd9-711e-43a0-972f-2a484e2c4018@default> (raw)
In-Reply-To: <CAM-tV--TAC8zLfu33Z2=9-KU2ohDXpSHY5=r5F0ZwPMD1Bau2g@mail.gmail.com>
> Isn't the safest and simplest solution to rename the current
> *-at-point to *-near-point, keep the *-at-point names as obsolete
> aliases, and add new *-precisely-at-point functions with the
> definitions from the thingatpt+ library? That way, current users of
> *-at-point who happen to be relying the on *-near-point functionality
> won't break. Only downside I can see is a slightly longer name for the
> *-precisely-at-point callers, but that doesn't seem too bad.
>
> What you do think?
That's possible (and I appreciate your trying to find a
diplomatic way to get this bug fixed), but I don't think
that is the best approach.
We should aim to have a reasonable name, not just something
that doesn't conflict. There is little sense in abandoning
the most reasonable name for this, IMO. This is what the
library is intended for: returning a thing at point.
If the name "*-at-point" is kept (for behavior that is really
at point) then the worst that will happen is that some users
might complain that they no longer get a thing that is before
point but not also at point.
And that won't even happen for distributed Emacs code, which
should replace any appropriate calls to *-at by *-near (where
appropriate means that you really do want to retrieve the
thing before point as well as the thing at point).
This is a simple off-by-one bug. It really should not require
anything to be deprecated. Just because someone might have
gotten used to the bugged behavior is not a good reason not
to fix this bug.
If going the direction you suggest is the best compromise
that can be had, I'd suggest using the name *-at-pt instead
of *-precisely-at-point. IOW, just change "point" to "pt".
That's not the fix I prefer, and it hurts discoverability
(matches against "point"), and it doesn't jibe with names
such as `find-file-at-point', but I think it's better than
something as artificial as *-precisely-at-point. That name
just makes one wonder.
next prev parent reply other threads:[~2016-06-21 0:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-14 22:36 bug#9300: 24.0.50; `bounds-of-thing-at-point' does not return nil when just after THING Drew Adams
2016-06-20 9:21 ` Tino Calancha
2016-06-20 12:53 ` Dmitry Gutov
2016-06-20 13:11 ` Tino Calancha
2016-06-20 14:48 ` Eli Zaretskii
2016-06-21 3:01 ` Tino Calancha
[not found] ` <<8337o79arh.fsf@gnu.org>
2016-06-20 17:50 ` Drew Adams
2016-06-20 18:38 ` Andreas Röhler
2016-06-20 20:04 ` Eli Zaretskii
2016-06-21 6:14 ` Andreas Röhler
2016-06-21 12:50 ` Eli Zaretskii
2016-06-21 13:07 ` Andreas Röhler
2016-06-21 15:13 ` Eli Zaretskii
2016-06-21 13:31 ` Drew Adams
2016-06-21 15:16 ` Eli Zaretskii
2016-06-21 13:25 ` Drew Adams
[not found] ` <<<8337o79arh.fsf@gnu.org>
[not found] ` <<0e2c9c67-12a2-4712-92d2-e3c204f46838@default>
[not found] ` <<83twgn7hjx.fsf@gnu.org>
2016-06-20 23:34 ` Drew Adams
2016-06-20 23:59 ` Noam Postavsky
2016-06-21 0:47 ` Drew Adams [this message]
[not found] <<B1052724B2D446C59E233FC1BD437723@us.oracle.com>
2015-07-29 1:44 ` Drew Adams
2016-01-15 13:33 ` Drew Adams
2016-02-23 1:01 ` Dmitry Gutov
2016-02-23 6:37 ` Drew Adams
2016-02-23 7:59 ` Andreas Röhler
2016-02-23 10:22 ` Dmitry Gutov
2016-02-23 16:15 ` Drew Adams
2016-02-24 0:52 ` Dmitry Gutov
2016-02-24 1:31 ` Drew Adams
2016-02-26 1:03 ` Dmitry Gutov
2016-02-26 1:44 ` Drew Adams
2016-02-26 10:15 ` Dmitry Gutov
2016-02-26 14:39 ` Drew Adams
2016-02-26 15:25 ` Dmitry Gutov
2016-02-26 17:00 ` Drew Adams
2022-04-28 11:24 ` Lars Ingebrigtsen
2022-04-28 15:49 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5565dd9-711e-43a0-972f-2a484e2c4018@default \
--to=drew.adams@oracle.com \
--cc=9300@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=f92capac@gmail.com \
--cc=npostavs@users.sourceforge.net \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).