bug#43926: 26.3; Face `header-line-highlight': inherit from `mode-line-highlight', not `highlight'

bug#43926: 26.3; Face `header-line-highlight': inherit from `mode-line-highlight', not `highlight'

[Drew Adams]

Subject line says most of it.

Face `header-line-highlight' was added in Emacs 26.  It inherits from
`highlight'.  I think it should inherit from `mode-line-highlight'.

I suspect that it was made to inherit from `highlight' to keep the
previous behavior, from before the face was added.

I'd also suggest that `mode-line-highlight' inherit from `highlight' (in
addition to its current default attribute settings).  But you can
consider that to be a separate suggestion.

The first suggestion, to have `header-mode-highlight' inherit from
`mode-line-highlight' changes the default appearance, but it makes sense
by aligning header-line with mode-line, which we otherwise do generally.

And if the second suggestion of having `mode-line-highlight' inherit
from `highlight' is accepted, that too changes the default appearance,
but it makes sense by aligning mouse-face highlighting.

(I don't suggest that all `mouse-face' highlighting in Emacs should be
aligned.  I do think the suggestions here might make sense.)

In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32)
 of 2019-08-29
Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd
Windowing system distributor `Microsoft Corp.', version 10.0.18362
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

bug#43926: 26.3; Face `header-line-highlight': inherit from `mode-line-highlight', not `highlight'

[Eli Zaretskii]

> Date: Sun, 11 Oct 2020 08:55:12 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> 
> I'd also suggest that `mode-line-highlight' inherit from `highlight' (in
> addition to its current default attribute settings).

You want to have this face display as both raised-button _and_
highlighted in color?  Which other applications do something like
that?

Where the 3D face is not available, we do inherit from 'highlight'.

bug#43926: 26.3; Face `header-line-highlight': inherit from `mode-line-highlight', not `highlight'

[Lars Ingebrigtsen]

Drew Adams <drew.adams@oracle.com> writes:

> Face `header-line-highlight' was added in Emacs 26.  It inherits from
> `highlight'.  I think it should inherit from `mode-line-highlight'.

Makes sense, since header-line inherits from mode-line.  Pushed to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#43926: 26.3; Face `header-line-highlight': inherit from `mode-line-highlight', not `highlight'

[Drew Adams]

> You want to have this face display as both raised-button _and_
> highlighted in color?  Which other applications do something like
> that?

Dunno.  Does it matter which other apps do that?

> Where the 3D face is not available, we do inherit from 'highlight'.

The real point of this particular bug is to have
header-line inherit from mode-line.  Whether they
should inherit from `highlight' is another matter
(secondary).

(And `highlight' itself could by default have the
attributes now used for mode-line constructs.)

Logically, header-line and mode-line are similar,
and inheritance of their appearances makes some
sense.  This includes `mouse-face' appearance.

Whether their `mouse-face' highlighting should
inherit from `highlight' is a different question.
But most `mouse-face' highlighting does, in fact,
use `highlight' by default.

bug#43926: 26.3; Face `header-line-highlight': inherit from `mode-line-highlight', not `highlight'

[Eli Zaretskii]

> Date: Sun, 11 Oct 2020 09:28:39 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: 43926@debbugs.gnu.org
> 
> > You want to have this face display as both raised-button _and_
> > highlighted in color?  Which other applications do something like
> > that?
> 
> Dunno.  Does it matter which other apps do that?

Yes, because I think what you suggest will look uglier than what we
have now.  It will also be unexpected.

> > Where the 3D face is not available, we do inherit from 'highlight'.
> 
> The real point of this particular bug is to have
> header-line inherit from mode-line.  Whether they
> should inherit from `highlight' is another matter
> (secondary).

I responded only to the "secondary matter".

bug#43926: 26.3; Face `header-line-highlight': inherit from `mode-line-highlight', not `highlight'

[Drew Adams]

> > > You want to have this face display as both raised-button _and_
> > > highlighted in color?  Which other applications do something like
> > > that?
> >
> > Dunno.  Does it matter which other apps do that?
> 
> Yes, because I think what you suggest will look uglier than what we
> have now.  It will also be unexpected.
> 
> > > Where the 3D face is not available, we do inherit from 'highlight'.
> >
> > The real point of this particular bug is to have
> > header-line inherit from mode-line.  Whether they
> > should inherit from `highlight' is another matter
> > (secondary).
> 
> I responded only to the "secondary matter".

OK.

None of this is a bug report - there's no bug.
I only provided some suggestions.

I'm using those suggestions myself now (just
started).  My impression so far is that it's
helpful to have the effect of face `highlight'
(whatever effect that might be for a given user
or library) included for mode-line construct
mouseovers.

For one thing, it's consistent.  (I don't argue
for consistency as a big deal.  Just sayin'.)

If I were to now sacrifice one of the parts:
(1) boxing & raising or (2) usual `highlight',
I think I'd sacrifice #1.

IOW, mouseover highlighting that everywhere
shows the same highlighted background makes
sense to me, for me.  But that's a personal
opinion.