unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 43926@debbugs.gnu.org
Subject: bug#43926: 26.3; Face `header-line-highlight': inherit from `mode-line-highlight', not `highlight'
Date: Sun, 11 Oct 2020 08:55:12 -0700 (PDT)	[thread overview]
Message-ID: <c51cdbb5-c133-4764-88dd-3bf8dd6964e0@default> (raw)

Subject line says most of it.

Face `header-line-highlight' was added in Emacs 26.  It inherits from
`highlight'.  I think it should inherit from `mode-line-highlight'.

I suspect that it was made to inherit from `highlight' to keep the
previous behavior, from before the face was added.

I'd also suggest that `mode-line-highlight' inherit from `highlight' (in
addition to its current default attribute settings).  But you can
consider that to be a separate suggestion.

The first suggestion, to have `header-mode-highlight' inherit from
`mode-line-highlight' changes the default appearance, but it makes sense
by aligning header-line with mode-line, which we otherwise do generally.

And if the second suggestion of having `mode-line-highlight' inherit
from `highlight' is accepted, that too changes the default appearance,
but it makes sense by aligning mouse-face highlighting.

(I don't suggest that all `mouse-face' highlighting in Emacs should be
aligned.  I do think the suggestions here might make sense.)

In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32)
 of 2019-08-29
Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd
Windowing system distributor `Microsoft Corp.', version 10.0.18362
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''





             reply	other threads:[~2020-10-11 15:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-11 15:55 Drew Adams [this message]
2020-10-11 16:15 ` bug#43926: 26.3; Face `header-line-highlight': inherit from `mode-line-highlight', not `highlight' Eli Zaretskii
2020-10-13  1:26 ` Lars Ingebrigtsen
     [not found] <<c51cdbb5-c133-4764-88dd-3bf8dd6964e0@default>
     [not found] ` <<83h7r04u2t.fsf@gnu.org>
2020-10-11 16:28   ` Drew Adams
2020-10-11 16:46     ` Eli Zaretskii
     [not found] <<<c51cdbb5-c133-4764-88dd-3bf8dd6964e0@default>
     [not found] ` <<<83h7r04u2t.fsf@gnu.org>
     [not found]   ` <<09b225ec-8bbb-430a-a255-99443d807cda@default>
     [not found]     ` <<83d01o4sn5.fsf@gnu.org>
2020-10-11 20:11       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c51cdbb5-c133-4764-88dd-3bf8dd6964e0@default \
    --to=drew.adams@oracle.com \
    --cc=43926@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).