From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pieter van Prooijen Newsgroups: gmane.emacs.bugs Subject: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds Date: Sat, 26 Mar 2022 16:48:30 +0100 Message-ID: References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14428"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.40.4-1ubuntu2 Cc: 54564@debbugs.gnu.org To: Po Lu , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 26 16:49:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nY8fQ-0003XI-LA for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Mar 2022 16:49:30 +0100 Original-Received: from localhost ([::1]:33976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nY8fP-0007pK-2P for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Mar 2022 11:49:27 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY8f0-0007op-KZ for bug-gnu-emacs@gnu.org; Sat, 26 Mar 2022 11:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nY8f0-0000wN-C5 for bug-gnu-emacs@gnu.org; Sat, 26 Mar 2022 11:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nY8f0-0000rf-2j for bug-gnu-emacs@gnu.org; Sat, 26 Mar 2022 11:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pieter van Prooijen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Mar 2022 15:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54564-submit@debbugs.gnu.org id=B54564.16483097223294 (code B ref 54564); Sat, 26 Mar 2022 15:49:02 +0000 Original-Received: (at 54564) by debbugs.gnu.org; 26 Mar 2022 15:48:42 +0000 Original-Received: from localhost ([127.0.0.1]:54544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY8eg-0000r3-2m for submit@debbugs.gnu.org; Sat, 26 Mar 2022 11:48:42 -0400 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:52383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nY8ed-0000qp-2R for 54564@debbugs.gnu.org; Sat, 26 Mar 2022 11:48:40 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 372DE32009F8; Sat, 26 Mar 2022 11:48:33 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 26 Mar 2022 11:48:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=teloden.nl; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=F8wPXxvX/30lOa 5NZpvR4WLaTrot8lqu39pCPEHr9pY=; b=nvJzyDUvJ5kPBNaULPHREzZTBF9epE WwD3mL6UYu1ICIYgXofrwOyra+fkuUM1kTqcIEVdR4/gTtAyiPI2SdcNp80feEw4 l0B1mC1nMWmOGvlftAAv8mCGBApoG31tcfptgDWsC95SeJ2VG/j2vAXgqWi/7U4x lD8OxqABOeDxcp0ONJ/ItgXU5h+zVJ/87a2CDUsVY4yQjpVF/aKsBvMM7Fmc4u/S Wrvu6Ej61WiygV04Jkw7ADsd7ZFDJesDIL7hjatbQU+ufPTeZUiiwHUQy7frk52B j4yo/mKPsNjSIKPOfbyFMoN7VY2pwAYevGc4SBRT5kvkJ4wenUiRnXsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=F8wPXxvX/30lOa5NZpvR4WLaTrot8lqu39pCPEHr9 pY=; b=NmHm28FFI4yRsVQVS5tqUOjNJe30D9lN+8u2vTf97x+G7hZjbjPjHZlKH ixy9b87SU10ZsZluzqXjg8gpFa18AxErBeDz25lpPKrAbtA745KMYo1aXrHhkBdb OeMNaGa7ZoJWEx6eXMcXL/R434dTvjM3K4Myh8j5rStj47TlCNfMmiJv8uLra7A9 YXo3MVwuEELagSrJ+fUthb3j35tZrgaBCfiwNV5vr8TAb2FCKjlbKlHLlSFafaWd ruQIUNzgh4eC/fzTS/vPwYNjkSD0WidaW6lDkUF9nL+PR0jo5f5fdqKp1w+jMaVE 51BtNppTRccgolVl9rpWGrKVuJpTA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehfedgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkffuhffvffgjfhgtfggggfesthekredttderjeenucfhrhhomheprfhivght vghruchvrghnucfrrhhoohhijhgvnhcuoehpihgvthgvrhdrvhgrnhdrphhrohhoihhjvg hnsehtvghlohguvghnrdhnlheqnecuggftrfgrthhtvghrnhepfeefueejvdduffehieej tdeuffdtjeffhfevkeegueegheduffeileetiedtffffnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphhivghtvghrrdhvrghnrdhprhhoohhi jhgvnhesthgvlhhouggvnhdrnhhl X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 26 Mar 2022 11:48:31 -0400 (EDT) In-Reply-To: <87v8w143h6.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228974 Archived-At: Hello All, Thanks for looking into my patch!, I'll fix the formatting issues you mentioned and narrow the changes to the HAVE_PGTK define in the various source files, so it's is only present for that build. Not sure about having this functionality controlled by a user defined variable (as is possible with using the system font), as far as I know, the current cairo X backend doesn't have this as well, it will always use the gsettings/xrdb defined parameters for rendering. Regarding the re-rendering upon a config change, I'll have a look at the options mentioned (clearing the font cache and marking each frame for redisplay), but that will probably be a separate patch. Kind Regards, Pieter On Sat, 2022-03-26 at 14:44 +0800, Po Lu wrote: > Eli Zaretskii writes: > > > Does the below fit the bill? > > > >    clear_face_cache (true); > > > > Or did you mean to do this only on a single frame (or on specific > > selected frames)?  Then looking inside clear_face_cache will tell > > you > > how to do that. > > It should be done for each frame on every display, so > clear_face_cache > probably does fit the bill.  (Though perhaps clear_font_cache on each > window system frame by itself will be enough?) > > > And one more thing: care should be taken if this is done in > > response > > to some async notification, because clearing all the faces will > > need a > > thorough redisplay.  Most probably all the affected frames need to > > be > > marked as "garbaged". > > Thanks.  Pieter, do you need any help in implementing the feature > along > those lines? > > > I don't see any references to that variable in the patch you are > > discussing.  And its name and doc string don't seem to give any > > clue > > that it's relevant to this issue.  Is this only for fixed-pitch > > fonts? > > No, this is supposed to work for all fonts. > > > Yes, I think so. > > Sure, thanks.