From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients Date: Mon, 10 Oct 2022 09:43:55 -0700 Message-ID: References: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> <83k058i4y2.fsf@gnu.org> <02eb7516-bccc-16ab-84f2-4688849bfba8@gmail.com> <83tu4cgivn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------FT1ttZEE0UrVtkPsIua64HoQ" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14227"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58404@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 10 18:46:08 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohvup-0003VP-UI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 18:46:08 +0200 Original-Received: from localhost ([::1]:49112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohvup-0007Rj-0Z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 12:46:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohvtn-0006qS-W7 for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 12:45:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50627) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohvtn-0004x5-LM for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 12:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohvtn-0001ni-Gi for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 12:45:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Oct 2022 16:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58404 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58404-submit@debbugs.gnu.org id=B58404.16654202436795 (code B ref 58404); Mon, 10 Oct 2022 16:45:03 +0000 Original-Received: (at 58404) by debbugs.gnu.org; 10 Oct 2022 16:44:03 +0000 Original-Received: from localhost ([127.0.0.1]:49695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohvsp-0001lP-4V for submit@debbugs.gnu.org; Mon, 10 Oct 2022 12:44:03 -0400 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:43649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohvsn-0001kQ-TO for 58404@debbugs.gnu.org; Mon, 10 Oct 2022 12:44:02 -0400 Original-Received: by mail-pg1-f173.google.com with SMTP id h185so3660560pgc.10 for <58404@debbugs.gnu.org>; Mon, 10 Oct 2022 09:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=GFVk1FD8zGDVrKJN3UZUGhtGDDot0mcqlJlYI3q5eOc=; b=pbFRPkfln4ifpYaKx3RHmGfc1ZoMFXbkrDa19Ui8ZIqA8uVXO6gfw8IMs4iRZuXkkQ gtDEVV8SU3yT9jRbpae6/hiT9sl3t4M0gZJ6YUOlJ+QxkglMU3cczKvLH3JEpsXjSo8v qKE1vE3/rwmCXEYRvvidpgP5cwEV0ktUg97XJwB5hcboPKab1ow155ouSHdE/W7g9Xnu lNFlrW3R8aPk14cSZSPzg6XZvhJBhLZQC/Vu2eAXVfwf5ovumMDF5hRYeqGUVtyq7akv Yzm/vL7RG18vw4iU1ZF0MDjzrbl7SimLarZleTWgw8aHVphFXW1dBkHXH7Z3bSH2r3or tN7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GFVk1FD8zGDVrKJN3UZUGhtGDDot0mcqlJlYI3q5eOc=; b=sfM/6wDHuOXcME0xUGRvu+q9gUXdZzDnnuvoiX99qXFGLj+uALSeq7xcmo8bYEV8L6 s+rf9CNJlx2FBUWzJDWDDaqb+wHl5w5SN1gdhdEGh2VmQykf9DLVnYZI+T7DVAsZKesz BBx2dyRE4ec12N5ZyW0CB4YUN3cFEn8uMpsfED3tEMTtDgd7JlQPfy8EmDSekUqbETOV cd82PBW4XDuPjxpvHnMJq/BNnpSKuZQr11rWtICv+OLjjY4j+ozYyFrrpmz7R3HSmsZC J56vZIV7fiEVg9E5KmZ0xq+Wkt7xBhk32zADsrYS1CIaEae8qJGmzdp/q44xW5uHawPF rkFQ== X-Gm-Message-State: ACrzQf3xI/L+jl9q+LnpUORJfhTasII923chNIdAwcxZGxPhOm6wA1SE k1+JR/pZphdV3Q0PWjnmG9s= X-Google-Smtp-Source: AMsMyM4DQ5aeZkis8RdjdA+HMJlzEudVkIGYjTwTG8iw3yPiAsFvCk5YFnTmtp9kr2PrpD3OtvGphQ== X-Received: by 2002:a65:5583:0:b0:461:25fe:e982 with SMTP id j3-20020a655583000000b0046125fee982mr8675397pgs.4.1665420235936; Mon, 10 Oct 2022 09:43:55 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id f13-20020a170902f38d00b00172fc5b0764sm6783355ple.270.2022.10.10.09.43.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 09:43:54 -0700 (PDT) Content-Language: en-US In-Reply-To: <83tu4cgivn.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245033 Archived-At: This is a multi-part message in MIME format. --------------FT1ttZEE0UrVtkPsIua64HoQ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/10/2022 1:53 AM, Eli Zaretskii wrote: > It is okay not to prompt when there's no need. That wasn't the part > on which I commented, AFAIU. > > You said: > >> On the other hand, I think it *would* be useful to prompt if you're in >> the last client, but there are other non-client frames. > > I'm saying that no, it will not be useful to prompt in that case: if > the only frames left are non-client frames, we should not prompt, > because we don't prompt when there are no client frames to begin with. > Apologies if I misunderstood the use case. Ah, I see. In that part of my original message, I wanted to say that this was a case where I thought the old code made sense, since it prompts the user then. However, I also thought that the prompt message could be more informative. Here's why I think prompting then makes sense: when you're in an emacsclient frame and there are other non-client frames (i.e. ones "owned" by the main Emacs process), that looks very similar to the user as when you have a second emacsclient running. In other words, I think it would be good for this function to prompt when doing this: $ emacs -Q --daemon $ emacsclient foo.txt $ emacsclient -c bar.txt ;; From either frame: M-x save-buffers-kill-emacs Or this: $ emacs -Q --daemon $ emacsclient foo.txt $ emacsclient --no-wait -c bar.txt ;; From either frame: M-x save-buffers-kill-emacs Or this: $ emacs foo.txt M-x server-start $ emacsclient -c bar.txt ;; From either frame: M-x save-buffers-kill-emacs In all of those cases, the user would have 2 (visible) frames, possibly on different displays/terminals. Since they're visually similar, I think it makes sense to have similar prompts. Next, if the user ran 'save-buffers-kill-emacs' a second time in any of those examples, it *wouldn't* prompt, since then all the remaining frames are associated with a single emacsclient (or no client at all). Since the use case for this is non-obvious (it actually took me several iterations to identify all the possible cases), I updated my patch with clearer (to me) code, plus comments explaining the reasoning. --------------FT1ttZEE0UrVtkPsIua64HoQ Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.patch" Content-Disposition: attachment; filename*0="0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAzZjA4YjEyMGE4M2IzYzA2YTc3NzgyM2FjZWU2MDRmOTRmZDQxMjEwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgOSBPY3QgMjAyMiAxNTo1MzoyNyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIERvbid0IHByb21wdCB3aGVuIGtpbGxpbmcgYW4gRW1hY3MgY2xpZW50IGlmIGl0J3Mg dGhlIGxhc3QKIGNsaWVudAoKUHJldmlvdXNseSwgdGhpcyBmdW5jdGlvbiBwcm9tcHRlZCB3 aGVuZXZlciB0aGVyZSB3YXMgYSBsaXZlIGNsaWVudCwKaW5jbHVkaW5nIHRoZSBjdXJyZW50 IG9uZS4gIE5vdywgb25seSBwcm9tcHQgaW4gb25lIG9mOgoKICAxLiBUaGVyZSBhcmUgbGl2 ZSBFbWFjcyBjbGllbnRzIG90aGVyIHRoYW4gdGhlIGN1cnJlbnQgb25lLCBvcgogIDIuIFRo ZSBjdXJyZW50IGZyYW1lIGlzIGEgY2xpZW50IGZyYW1lIGFuZCB0aGVyZSBhcmUgYWxzbyBu b24tY2xpZW50CiAgICAgZnJhbWVzIG9wZW4uCgoqIGxpc3Avc2VydmVyLmVsIChzZXJ2ZXIt a2lsbC1lbWFjcy1xdWVyeS1mdW5jdGlvbik6IFJld3JpdGUgdG8gYXZvaWQKcHJvbXB0aW5n IGFzIGFib3ZlIChidWcjNTg0MDQpLgotLS0KIGxpc3Avc2VydmVyLmVsIHwgMzIgKysrKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRp b25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avc2VydmVyLmVsIGIv bGlzcC9zZXJ2ZXIuZWwKaW5kZXggM2NhYTMzNWM0ZS4uZjc0ZjI2MjEwYSAxMDA2NDQKLS0t IGEvbGlzcC9zZXJ2ZXIuZWwKKysrIGIvbGlzcC9zZXJ2ZXIuZWwKQEAgLTE1ODksMTQgKzE1 ODksMzQgQEAgc2VydmVyLWRvbmUKICAgICAoc2VydmVyLWJ1ZmZlci1kb25lIChjdXJyZW50 LWJ1ZmZlcikpKSkKIAogKGRlZnVuIHNlcnZlci1raWxsLWVtYWNzLXF1ZXJ5LWZ1bmN0aW9u ICgpCi0gICJBc2sgYmVmb3JlIGV4aXRpbmcgRW1hY3MgaWYgaXQgaGFzIGxpdmUgY2xpZW50 cy4KKyAgIkFzayBiZWZvcmUgZXhpdGluZyBFbWFjcyBpZiBpdCBoYXMgb3RoZXIgbGl2ZSBj bGllbnRzIG9yIG5vbi1jbGllbnQgZnJhbWVzLgogQSBcImxpdmUgY2xpZW50XCIgaXMgYSBj bGllbnQgd2l0aCBhdCBsZWFzdCBvbmUgbGl2ZSBidWZmZXIKIGFzc29jaWF0ZWQgd2l0aCBp dC4iCi0gIChvciAobm90IChzZXEtc29tZSAobGFtYmRhIChwcm9jKQotICAgICAgICAgICAg ICAgICAgICAgICAoc2VxLXNvbWUgIydidWZmZXItbGl2ZS1wCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAocHJvY2Vzcy1nZXQgcHJvYyAnYnVmZmVycykpKQotICAgICAg ICAgICAgICAgICAgICAgc2VydmVyLWNsaWVudHMpKQotICAgICAgKHllcy1vci1uby1wICJU aGlzIEVtYWNzIHNlc3Npb24gaGFzIGNsaWVudHM7IGV4aXQgYW55d2F5PyAiKSkpCisgIChs ZXQgKCh0aGlzLWNsaWVudCAoZnJhbWUtcGFyYW1ldGVyIG5pbCAnY2xpZW50KSkpCisgICAg KGNvbmQKKyAgICAgOzsgQ2hlY2sgZm9yIEVtYWNzIGNsaWVudHMsIGV4Y2x1ZGluZyB0aGUg Y3VycmVudCBvbmUgKGlmIGFueSkuCisgICAgIDs7IElmIHRoZXJlIGFyZSBhbnkgb3RoZXIg Y2xpZW50cywgcHJvbXB0IHRoZSB1c2VyIGJlZm9yZSBraWxsaW5nCisgICAgIDs7IEVtYWNz LiAgT3RoZXIgY2xpZW50cyBtaWdodCBiZSBvbiBkaWZmZXJlbnQgKHBvc3NpYmx5IHJlbW90 ZSkKKyAgICAgOzsgZGlzcGxheXMsIHNvIGl0IGNhbiBiZSBoYXJkIGZvciB1c2VycyB0byB0 ZWxsIG9uIHRoZWlyIG93bi4KKyAgICAgKChzZXEtc29tZSAobGFtYmRhIChwcm9jKQorICAg ICAgICAgICAgICAgICAgKHVubGVzcyAoZXEgcHJvYyB0aGlzLWNsaWVudCkKKyAgICAgICAg ICAgICAgICAgICAgKHNlcS1zb21lICMnYnVmZmVyLWxpdmUtcAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKHByb2Nlc3MtZ2V0IHByb2MgJ2J1ZmZlcnMpKSkpCisgICAgICAg ICAgICAgICAgc2VydmVyLWNsaWVudHMpCisgICAgICAoeWVzLW9yLW5vLXAgIlRoaXMgRW1h Y3Mgc2Vzc2lvbiBoYXMgb3RoZXIgY2xpZW50czsgZXhpdCBhbnl3YXk/ICIpKQorICAgICA7 OyBJZiB0aGUgdXNlciBpcyBpbiBhIGNsaWVudCBmcmFtZSwgcHJvbXB0IGlmIHRoZXJlIGFy ZSBhbnkKKyAgICAgOzsgZnJhbWVzIGNyZWF0ZWQgYnkgdGhlIG1haW4gRW1hY3MgcHJvY2Vz cy4gIExpa2UgaW4gdGhlIGNhc2UKKyAgICAgOzsgYWJvdmUsIHRob3NlIGZyYW1lcyBtaWdo dCBiZSBvbiBkaWZmZXJlbnQgZGlzcGxheXMuCisgICAgICgoYW5kIChwcm9jZXNzcCB0aGlz LWNsaWVudCkKKyAgICAgICAgICAgOzsgRG9uJ3QgY291bnQgdGhlIGluaXRpYWwgZnJhbWUg d2hlbiBpbiBkYWVtb24gbW9kZS4KKyAgICAgICAgICAgKDwgKGlmIChkYWVtb25wKSAxIDAp CisgICAgICAgICAgICAgIChzZXEtY291bnQKKyAgICAgICAgICAgICAgIChsYW1iZGEgKGZy YW1lKQorICAgICAgICAgICAgICAgICAobm90IChwcm9jZXNzcCAoZnJhbWUtcGFyYW1ldGVy IGZyYW1lICdjbGllbnQpKSkpCisgICAgICAgICAgICAgICAoZnJhbWUtbGlzdCkpKSkKKyAg ICAgICh5ZXMtb3Itbm8tcCAiVGhpcyBFbWFjcyBzZXNzaW9uIGhhcyBub24tY2xpZW50IGZy YW1lczsgZXhpdCBhbnl3YXk/ICIpKQorICAgICA7OyBPdGhlcndpc2UsIHdlIGNhbiBraWxs IEVtYWNzIHdpdGhvdXQgcHJvbXB0aW5nLgorICAgICAodCB0KSkpKQogCiAoZGVmdW4gc2Vy dmVyLWtpbGwtYnVmZmVyICgpCiAgICJSZW1vdmUgdGhlIGN1cnJlbnQgYnVmZmVyIGZyb20g aXRzIGNsaWVudHMnIGJ1ZmZlciBsaXN0LgotLSAKMi4yNS4xCgo= --------------FT1ttZEE0UrVtkPsIua64HoQ--