From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#65631: Xref updates stack in case of error Date: Thu, 31 Aug 2023 03:50:53 +0300 Message-ID: References: <864jkg4h0i.fsf@mail.linkov.net> <83r0nkfos1.fsf@gnu.org> <86leds30yw.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------jpFog5b5AQ0yzZzeShkS3wqj" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26388"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 65631@debbugs.gnu.org To: Juri Linkov , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 31 02:52:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbVuy-0006Yy-PY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Aug 2023 02:52:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbVue-00086L-R1; Wed, 30 Aug 2023 20:51:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbVud-00086C-58 for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 20:51:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbVuc-0007UQ-FT for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 20:51:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbVuk-0003Gf-8p for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 20:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 00:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65631 X-GNU-PR-Package: emacs Original-Received: via spool by 65631-submit@debbugs.gnu.org id=B65631.169344307412486 (code B ref 65631); Thu, 31 Aug 2023 00:52:02 +0000 Original-Received: (at 65631) by debbugs.gnu.org; 31 Aug 2023 00:51:14 +0000 Original-Received: from localhost ([127.0.0.1]:54321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbVtx-0003FI-N9 for submit@debbugs.gnu.org; Wed, 30 Aug 2023 20:51:14 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:36819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbVts-0003F1-HM for 65631@debbugs.gnu.org; Wed, 30 Aug 2023 20:51:12 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 8351A5C017F; Wed, 30 Aug 2023 20:50:55 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 30 Aug 2023 20:50:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1693443055; x=1693529455; bh=1n Kldyy3ECSPlyCVnqPI0b+SkghqiFZ/AR/Nx5BvYiw=; b=GM8ROHM6V7loS77Vwg qyLg3lgfYbdPBrWtK7mboA4MdRYAwPEFEw7lHqioLWDaYpqIQLFUx6cfhWld/2oX VjTxHsjf0okAibEAk3ea4fI0SevUT670fVOMLgf8LGzADMKIY69XN2uaHaZTJxbW P8EAoCAEUkMvZhfb46C1TDShV1DjoWaqwsoOrSpA07fGJPMGXNNNAfM08WStE0EW rub/aouwTmQdtSguhG/+Bnq2zYMLrrZ5ZWVX0WP8n0yaT9iK1o3flWBLXIiBBO8s u1fFHu+FGsndks/EvUq7b0g+CNaButjatYhnwf6Gbl0DZSCkEC2wqJsg0tEuRsjX 1s2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1693443055; x=1693529455; bh=1nKldyy3ECSPl yCVnqPI0b+SkghqiFZ/AR/Nx5BvYiw=; b=z6HOS32a4VxpAQBqlmc8LqBYdxEoS LmSEuu1qUNh9V8UiTxFEvC3/giaB5WpTqZsWjppgirw0wByWdemPyfCEVgsel/mW l6V/IV9IubuSZrZK4wws3nhSb36tGq1unh3n3m0VwvtnE8iMUIsE6astuQplNQ3p r6taIIRzC327Zm7csN+oGFdoI621hkWgGFlpShfzHYUv33J0pOYbGPRoddLVvjjf 1aWdG/YqBHxGoKN/tL6oFwFI2PnUu/NgNAdEMpk6Vw9iz4unXmyr5vUMysHycuIg johf86YmXO59ZXZOX0hB6BP9I2YKbO2KBvOKXu7MPIkm02wv+nnW2UnvA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefledgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfevfhfhjgesmhdtreertdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeehteekgfetieeujeeuvddtvdelteffleejteduvdefffejieehheeuteffveei jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Aug 2023 20:50:54 -0400 (EDT) Content-Language: en-US In-Reply-To: <86leds30yw.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268769 Archived-At: This is a multi-part message in MIME format. --------------jpFog5b5AQ0yzZzeShkS3wqj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi! On 30/08/2023 20:16, Juri Linkov wrote: >>> 1. move point to any word >>> 2. type 'M-.' (xref-find-definitions) >>> 3. an error is displayed correctly "No definitions found for: This" >>> >>> But the problem is that an unrecognized word is added to the xref stack. >>> So the context menu shows "Go Back", and 'M-,' (xref-go-back) goes back >>> to that word. >> FWIW, I'm not sure this is necessarily a bug. It looks like a bug in >> your case, because you deliberately tricked Xref into using a word >> that is definitely not a program symbol. But that is not the case in >> a more reasonable situation, where point is on a symbol, but for some >> reason the symbol's definition is not found, e.g., because the TAGS >> table needs to be regenerated. > In case of error, point doesn't move. So there is no need to go back. At this point, I was kind of feeling that this is a known-but-tolerated behavior (that some might already be relying on, also known as "spacebar heater" effect), but if it's still annoying, let's see about a fix. How's the attached patch? --------------jpFog5b5AQ0yzZzeShkS3wqj Content-Type: text/x-patch; charset=UTF-8; name="xref--push-markers.diff" Content-Disposition: attachment; filename="xref--push-markers.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3hyZWYuZWwgYi9saXNwL3Byb2dtb2Rlcy94 cmVmLmVsCmluZGV4IGRiYWZhMDBjM2FkLi45YjY0ZWY0ZGUxMCAxMDA2NDQKLS0tIGEvbGlz cC9wcm9nbW9kZXMveHJlZi5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy94cmVmLmVsCkBAIC0x NDY4LDcgKzE0NjgsNiBAQCB4cmVmLXNob3cteHJlZnMKICAgKHhyZWYtLXNob3cteHJlZnMg ZmV0Y2hlciBkaXNwbGF5LWFjdGlvbikpCiAKIChkZWZ1biB4cmVmLS1zaG93LXhyZWZzIChm ZXRjaGVyIGRpc3BsYXktYWN0aW9uICZvcHRpb25hbCBfYWx3YXlzLXNob3ctbGlzdCkKLSAg KHhyZWYtLXB1c2gtbWFya2VycykKICAgKHVubGVzcyAoZnVuY3Rpb25wIGZldGNoZXIpCiAg ICAgOzsgT2xkIGNvbnZlbnRpb24uCiAgICAgKGxldCAoKHhyZWZzIGZldGNoZXIpKQpAQCAt MTQ3OSwyMSArMTQ3OCwzMCBAQCB4cmVmLS1zaG93LXhyZWZzCiAgICAgICAgICAgICAgICAg KHByb2cxCiAgICAgICAgICAgICAgICAgICAgIHhyZWZzCiAgICAgICAgICAgICAgICAgICAo c2V0cSB4cmVmcyAnY2FsbGVkLWFscmVhZHkpKSkpKSkpCi0gIChmdW5jYWxsIHhyZWYtc2hv dy14cmVmcy1mdW5jdGlvbiBmZXRjaGVyCi0gICAgICAgICAgIGAoKHdpbmRvdyAuICwoc2Vs ZWN0ZWQtd2luZG93KSkKLSAgICAgICAgICAgICAoZGlzcGxheS1hY3Rpb24gLiAsZGlzcGxh eS1hY3Rpb24pCi0gICAgICAgICAgICAgKGF1dG8tanVtcCAuICx4cmVmLWF1dG8tanVtcC10 by1maXJzdC14cmVmKSkpKQorICAobGV0ICgoY2IgKGN1cnJlbnQtYnVmZmVyKSkKKyAgICAg ICAgKHB0IChwb2ludCkpKQorICAgIChmdW5jYWxsIHhyZWYtc2hvdy14cmVmcy1mdW5jdGlv biBmZXRjaGVyCisgICAgICAgICAgICAgYCgod2luZG93IC4gLChzZWxlY3RlZC13aW5kb3cp KQorICAgICAgICAgICAgICAgKGRpc3BsYXktYWN0aW9uIC4gLGRpc3BsYXktYWN0aW9uKQor ICAgICAgICAgICAgICAgKGF1dG8tanVtcCAuICx4cmVmLWF1dG8tanVtcC10by1maXJzdC14 cmVmKSkpCisgICAgKHhyZWYtLXB1c2gtbWFya2VycyBjYiBwdCkpKQogCiAoZGVmdW4geHJl Zi0tc2hvdy1kZWZzICh4cmVmcyBkaXNwbGF5LWFjdGlvbikKLSAgKHhyZWYtLXB1c2gtbWFy a2VycykKLSAgKGZ1bmNhbGwgeHJlZi1zaG93LWRlZmluaXRpb25zLWZ1bmN0aW9uIHhyZWZz Ci0gICAgICAgICAgIGAoKHdpbmRvdyAuICwoc2VsZWN0ZWQtd2luZG93KSkKLSAgICAgICAg ICAgICAoZGlzcGxheS1hY3Rpb24gLiAsZGlzcGxheS1hY3Rpb24pCi0gICAgICAgICAgICAg KGF1dG8tanVtcCAuICx4cmVmLWF1dG8tanVtcC10by1maXJzdC1kZWZpbml0aW9uKSkpKQot Ci0oZGVmdW4geHJlZi0tcHVzaC1tYXJrZXJzICgpCi0gICh1bmxlc3MgKHJlZ2lvbi1hY3Rp dmUtcCkgKHB1c2gtbWFyayBuaWwgdCkpCi0gICh4cmVmLXB1c2gtbWFya2VyLXN0YWNrKSkK KyAgKGxldCAoKGNiIChjdXJyZW50LWJ1ZmZlcikpCisgICAgICAgIChwdCAocG9pbnQpKSkK KyAgICAoZnVuY2FsbCB4cmVmLXNob3ctZGVmaW5pdGlvbnMtZnVuY3Rpb24geHJlZnMKKyAg ICAgICAgICAgICBgKCh3aW5kb3cgLiAsKHNlbGVjdGVkLXdpbmRvdykpCisgICAgICAgICAg ICAgICAoZGlzcGxheS1hY3Rpb24gLiAsZGlzcGxheS1hY3Rpb24pCisgICAgICAgICAgICAg ICAoYXV0by1qdW1wIC4gLHhyZWYtYXV0by1qdW1wLXRvLWZpcnN0LWRlZmluaXRpb24pKSkK KyAgICAoeHJlZi0tcHVzaC1tYXJrZXJzIGNiIHB0KSkpCisKKyhkZWZ1biB4cmVmLS1wdXNo LW1hcmtlcnMgKGJ1ZiBwdCkKKyAgKHdoZW4gKGJ1ZmZlci1saXZlLXAgYnVmKQorICAgIChz YXZlLWV4Y3Vyc2lvbgorICAgICAgKHdpdGgtbm8td2FybmluZ3MgKHNldC1idWZmZXIgYnVm KSkKKyAgICAgIChnb3RvLWNoYXIgcHQpCisgICAgICAodW5sZXNzIChyZWdpb24tYWN0aXZl LXApIChwdXNoLW1hcmsgbmlsIHQpKQorICAgICAgKHhyZWYtcHVzaC1tYXJrZXItc3RhY2sp KSkpCiAKIChkZWZ1biB4cmVmLS1wcm9tcHQtcCAoY29tbWFuZCkKICAgKG9yIChlcSB4cmVm LXByb21wdC1mb3ItaWRlbnRpZmllciB0KQo= --------------jpFog5b5AQ0yzZzeShkS3wqj--