From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#30285: dired-do-chmod vs. top line of dired Date: Thu, 1 Feb 2018 14:23:00 -0800 (PST) Message-ID: References: <87mv0wg80c.fsf@jidanni.org> <87efm8snnr.fsf@gmail.com> <83efm8irac.fsf@gnu.org> <87d11sl08v.fsf@gmail.com> <87fu6lwxxu.fsf@mail.linkov.net> <87k1vwcwy1.fsf@mail.linkov.net> <5620cf82-9402-4895-bdd1-fdf5401c8172@default> <871si475qh.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1517524163 16301 195.159.176.226 (1 Feb 2018 22:29:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Feb 2018 22:29:23 +0000 (UTC) Cc: 30285@debbugs.gnu.org, Tino Calancha , jidanni@jidanni.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 01 23:29:19 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehNM4-0003m7-7D for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Feb 2018 23:29:16 +0100 Original-Received: from localhost ([::1]:40387 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehNO5-0005KY-6A for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Feb 2018 17:31:21 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehNMu-00050I-NJ for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2018 17:31:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehNH0-00079k-JY for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2018 17:25:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45001) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ehNH0-000793-18 for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2018 17:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ehNGz-0002BZ-Ng for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2018 17:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Feb 2018 22:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30285 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30285-submit@debbugs.gnu.org id=B30285.15175237918346 (code B ref 30285); Thu, 01 Feb 2018 22:24:01 +0000 Original-Received: (at 30285) by debbugs.gnu.org; 1 Feb 2018 22:23:11 +0000 Original-Received: from localhost ([127.0.0.1]:52898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehNGB-0002AY-DR for submit@debbugs.gnu.org; Thu, 01 Feb 2018 17:23:11 -0500 Original-Received: from userp2130.oracle.com ([156.151.31.86]:52136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehNG9-0002AK-7V for 30285@debbugs.gnu.org; Thu, 01 Feb 2018 17:23:09 -0500 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w11MLl8x172942; Thu, 1 Feb 2018 22:23:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=nl+ABqPHVkMbL9KQg3TtlUK9ht3rVrXc6hCgqQl79sU=; b=VcN3pfdj1dKCyWDdBDnbwL5rUkMC0k3ibZ0Ikq1NgMQqFVANKAxz3DBWYIQfpdkj2ljd hN/6YVdLFI51Yd0DnP1m9yhG5l1INR4CH3WTbAox6EoBMxhPBYVkrOBguxCJZS5noqzC enmTYGMnOZUW57hqqNuZUjr6avoEpyDRNjTAYJgFtl8TPv+KbxvTuhjgw5HEc7FUf4/r wx8JuSUAkg4UPn3vtUk53VV/mSYO8ci/dUYqC7aivwTsR/TV+0bpcINkQnqGg21dArlP QdmKyAm/G6+ZTBhftQQ7rH9SjroMF/ZI4c+k8a8pKE5TU/N0pVBrdP4j+W5TOcKceV2F aw== Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2fvaq0g7us-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 01 Feb 2018 22:23:03 +0000 Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w11MN2sK021655 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 1 Feb 2018 22:23:02 GMT Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w11MN1FF001918; Thu, 1 Feb 2018 22:23:01 GMT In-Reply-To: <871si475qh.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4639.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8792 signatures=668660 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802010269 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.0 (/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142785 Archived-At: > > Not sure how helpful or necessary that is. It's liable to > > not be helpful (that use case needs no special advertising). > > And it might even confuse things. I think it just gets in > > the way of the message, which is, "You are not on a file line." >=20 > This message is absolutely wrong, it doesn't describe the state that > causes the error message. It has a bigger scope than just file lines, > it works with marked files, etc. You're right about that. > So more correct message would be like this: >=20 > =E2=80=9CNo files selected.=E2=80=9D That's better, but it risks confusion over the notion of "selection", especially in the context of marking or using marks (a "selection" of files). This might be better: "No files specified" Or this: "No files chosen" > Oh, and I discovered that the current state is much worse than I > thought: >=20 > 1. load dired-x > 2. type =E2=80=98M-<=E2=80=99 to go to the first line > 3. type =E2=80=98!=E2=80=99 (dired-do-shell-command) >=20 > =E2=80=9CWrong type argument: stringp, nil=E2=80=9D Meme combat - same thing. The return value of `dired-get-marked-files' needs to be tested as soon as it's available. When it is nil we must not call `dired-read-shell-command' or do anything else - just raise a `user-error'. This is a general change that needs to be looked for and made wherever appropriate.