From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Harald =?UTF-8?Q?J=C3=B6rg?= Newsgroups: gmane.emacs.bugs Subject: bug#22867: cperl-mode: Commit d0ad6306 suppresses fontification of hash/array declarations Date: Fri, 4 Sep 2020 18:04:07 +0200 Message-ID: References: <87ziui3d2f.fsf@jidanni.org> <793881bc-c77d-8ddd-61b2-d20d94107eed@posteo.de> <1738df57-6707-a08d-80a2-c581808dbaef@posteo.de> <87a6y6fblw.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33191"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 Cc: Stefan Kangas , 22867@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 04 18:16:28 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEEO3-0008XT-Et for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 18:16:27 +0200 Original-Received: from localhost ([::1]:43562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEEO2-00012T-G7 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 12:16:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEED0-0000Hv-Kt for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 12:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57133) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEED0-0002r7-7t for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 12:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEED0-000870-3S for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 12:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Harald =?UTF-8?Q?J=C3=B6rg?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Sep 2020 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 22867-submit@debbugs.gnu.org id=B22867.159923545931073 (code B ref 22867); Fri, 04 Sep 2020 16:05:02 +0000 Original-Received: (at 22867) by debbugs.gnu.org; 4 Sep 2020 16:04:19 +0000 Original-Received: from localhost ([127.0.0.1]:40419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEECI-000857-61 for submit@debbugs.gnu.org; Fri, 04 Sep 2020 12:04:18 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:58700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEECG-00084s-8u for 22867@debbugs.gnu.org; Fri, 04 Sep 2020 12:04:17 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id AE4C216005F for <22867@debbugs.gnu.org>; Fri, 4 Sep 2020 18:04:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1599235449; bh=EgTvV4bPQdlGNyAbv7llgy0GCkVcrhjDRzzaU6xduNk=; h=Subject:To:Cc:From:Autocrypt:Date:From; b=qj3ELdxRlyLkA2BpuA+SSOJfBb/XFyCd0SqddxiXJBUb1h6pcTqnyQjFlDXFUfbYF z/08L8TGFJEAJNpgQje1NZ7ZXMGhSEEXFa82lCvCg1yCIPervztQQFZm+JAyzyGQfy 9rM+a9GqVbSkHIRy8JTJmoQCJibGVjLE4n7k/F9Osrnz5BEQw4721ko2PH79lJP52r 919zcMfistZIUJprCw5fgVUL005SEgiKoSOaETSrUtDae+cvQDqTugNY5HXyUc9mlT /wVQG8+hKuULYo8BGgFTuWelTQk5C+ptVuqQJ61qLevWLqcxor2HBpKoezpLhJuhcs vmLFJmvIiFtdw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BjjCr6nnNz9rxR; Fri, 4 Sep 2020 18:04:08 +0200 (CEST) Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN In-Reply-To: <87a6y6fblw.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187156 Archived-At: On 9/4/20 5:46 AM, Lars Ingebrigtsen wrote: > Harald Jörg writes: > >>> Is the fix worse than the problem? If yes, maybe it should be reverted? >> >> The fix isn't _worse_. Strings like "%s" and "%d" in the argument >> list of printf being fontified as hashes is indeed idiotic. Also, >> more than once I was annoyed by fontification in POD sections. > [...] > After poking around a bit, I came up with this patch: > > diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el > index 5dee5007e2..7a1c2e4d24 100644 > --- a/lisp/progmodes/cperl-mode.el > +++ b/lisp/progmodes/cperl-mode.el > @@ -5776,8 +5776,8 @@ cperl-init-faces > t-font-lock-keywords) > cperl-font-lock-keywords cperl-font-lock-keywords-1 > cperl-font-lock-keywords-2 (append > - cperl-font-lock-keywords-1 > - t-font-lock-keywords-1))) > + t-font-lock-keywords-1 > + cperl-font-lock-keywords-1))) > (if (fboundp 'ps-print-buffer) (cperl-ps-print-init)) > (if (or (featurep 'choose-color) (featurep 'font-lock-extra)) > (eval ; Avoid a warning > > > It seems to fix all the test cases in Harald's .pl file, and the cperl > test file still passes (but its coverage isn't, ahem, extensive). > > Does anybody see any problems with just doing fixing it like this? I > had a peek at a couple of other perl files here, and nothing immediately > looked wonky, but I'm a bit out of practice writing perl... That change is fine with me! -- Cheers, haj