From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#8724: 23.2; js-mode imenu should be more thorough Date: Thu, 11 Jan 2024 02:19:27 +0200 Message-ID: References: <4DFE5EC4.3070103@gmail.com> <87y2bselz9.fsf@gnus.org> <96de25bd-511a-67c7-9253-1e7e29b1e021@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9166"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Lars Ingebrigtsen , Daniel Colascione , dino chiesa , 8724@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 11 01:20:36 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNioE-0002CH-Ok for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jan 2024 01:20:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNinq-00085Z-Cr; Wed, 10 Jan 2024 19:20:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNink-00083y-Kf for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 19:20:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNinj-00029G-OF for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 19:20:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNini-00077j-7J for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 19:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jan 2024 00:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8724 X-GNU-PR-Package: emacs Original-Received: via spool by 8724-submit@debbugs.gnu.org id=B8724.170493238027342 (code B ref 8724); Thu, 11 Jan 2024 00:20:02 +0000 Original-Received: (at 8724) by debbugs.gnu.org; 11 Jan 2024 00:19:40 +0000 Original-Received: from localhost ([127.0.0.1]:43581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNinM-00076w-Aq for submit@debbugs.gnu.org; Wed, 10 Jan 2024 19:19:40 -0500 Original-Received: from forward500a.mail.yandex.net ([178.154.239.80]:45362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNinI-00076i-66 for 8724@debbugs.gnu.org; Wed, 10 Jan 2024 19:19:38 -0500 Original-Received: from mail-nwsmtp-smtp-production-main-74.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-74.vla.yp-c.yandex.net [IPv6:2a02:6b8:c1d:47bd:0:640:2492:0]) by forward500a.mail.yandex.net (Yandex) with ESMTP id 4A385615DA; Thu, 11 Jan 2024 03:19:34 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-74.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id VJWNAV1rCCg0-dEPMK1wO; Thu, 11 Jan 2024 03:19:33 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1704932373; bh=WRbAIijwOjH3UAObcRRsDwxrACB0qGnbzzmoE4EIt6A=; h=In-Reply-To:From:Subject:Message-ID:Cc:References:Date:To; b=nGDEr9663WE9zjD6RQHKZ9iLOgCYMgSk730YlGxiOQ84dEthI7A1HxSabkoSaDWe9 MsA/zNl2xdru4caYlESTtlERUyFL6XXk2D+gcKMVrl6X8IfWEfO7xZ/+SoD0Vhg2Ni CmXF5fx5ztJEk7L/x8v5um+kOkZDp/ByOz6GBJHQ= Authentication-Results: mail-nwsmtp-smtp-production-main-74.vla.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id 1B41C27C0061; Wed, 10 Jan 2024 19:19:30 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 10 Jan 2024 19:19:31 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeivddgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegughhuthhovheshigrnhguvgigrdhruheqnecuggftrfgrth htvghrnhepiefhjeeuveetffffvdefteffffekhfeuudejieehheeiudelgfehgffffedu ffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hguhhtohhvodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqddufeeffeelleeh hedvqddvleegjeejjeejiedqughguhhtohhvpeephigrnhguvgigrdhruhesfhgrshhtmh grihhlrdgtohhm X-ME-Proxy: Feedback-ID: ib1d9465d:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 Jan 2024 19:19:29 -0500 (EST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277853 Archived-At: On 10/01/2024 13:55, Stefan Kangas wrote: > Dmitry Gutov writes: > >> On 02.06.2021 10:58, Lars Ingebrigtsen wrote: >>> This was nine years ago -- was there any progress with this? (It sounds >>> like a good change, but I haven't looked at the code.) >> >> Someone should really work in that direction, since in these nine years JS has >> grown more ways to define a function: e.g. arrow functions, or 'const > name> = ...'. >> >> I've tried simply replacing the definition. >> >> The patch kinda works, except I'm not sure about the (top) and (bottom) items >> that it adds (we don't have any precedent for this, so I vote no), and there's >> some sort of duplication of the entries: I see both (top) and the enclosed >> function name repeated an extra time in the imenu index. > > Did you make any further progress here? Sorry, I did not. It's still marked as "todo" in my email folder, but not of high priority, so far. And in this day and year, someone might give a shot at porting js2-mode's imenu generator (quite featureful, I should say) to tree-sitter's API (in js-ts-mode).