From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#33380: 27.0.50; Emacs hangs in current-time-zone Date: Wed, 14 Nov 2018 14:26:50 -0800 Organization: UCLA Computer Science Department Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------9950E35953CECAE9DEA815EF" X-Trace: blaine.gmane.org 1542234309 7584 195.159.176.226 (14 Nov 2018 22:25:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 14 Nov 2018 22:25:09 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 Cc: 33380-done@debbugs.gnu.org To: Glenn Morris , Sam Steingold Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 14 23:25:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gN3ap-0001qE-JP for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Nov 2018 23:25:03 +0100 Original-Received: from localhost ([::1]:34437 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gN3cv-00040d-WA for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Nov 2018 17:27:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gN3cl-0003zJ-Ac for bug-gnu-emacs@gnu.org; Wed, 14 Nov 2018 17:27:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gN3ck-0006Nj-GH for bug-gnu-emacs@gnu.org; Wed, 14 Nov 2018 17:27:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48426) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gN3ck-0006Na-Bq for bug-gnu-emacs@gnu.org; Wed, 14 Nov 2018 17:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gN3ck-0006rY-2v for bug-gnu-emacs@gnu.org; Wed, 14 Nov 2018 17:27:02 -0500 Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Nov 2018 22:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 33380 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Mail-Followup-To: 33380@debbugs.gnu.org, eggert@cs.ucla.edu, sds@gnu.org Original-Received: via spool by 33380-done@debbugs.gnu.org id=D33380.154223442126369 (code D ref 33380); Wed, 14 Nov 2018 22:27:01 +0000 Original-Received: (at 33380-done) by debbugs.gnu.org; 14 Nov 2018 22:27:01 +0000 Original-Received: from localhost ([127.0.0.1]:52682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gN3ch-0006rE-On for submit@debbugs.gnu.org; Wed, 14 Nov 2018 17:27:01 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:53424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gN3cf-0006r0-JK for 33380-done@debbugs.gnu.org; Wed, 14 Nov 2018 17:26:58 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A2E9B160087; Wed, 14 Nov 2018 14:26:51 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id YPdZSUZ75obf; Wed, 14 Nov 2018 14:26:50 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 72AA51600BE; Wed, 14 Nov 2018 14:26:50 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LUC6Evq42BOf; Wed, 14 Nov 2018 14:26:50 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 429B8160087; Wed, 14 Nov 2018 14:26:50 -0800 (PST) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152398 Archived-At: This is a multi-part message in MIME format. --------------9950E35953CECAE9DEA815EF Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 11/14/18 10:49 AM, Glenn Morris wrote: > A smaller example is to evaluate: (calendar-dst-starts 1962) Thanks for the smaller example. I installed the attached patch into master to fix that and am optimistically marking this bug as done. And thanks, Sam, for reporting the original problem. --------------9950E35953CECAE9DEA815EF Content-Type: text/x-patch; name="0001-Fix-probing-for-pre-1970-DST.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-probing-for-pre-1970-DST.patch" >From 917fe0d0383eabf621f59a7314882423bc12f74a Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 14 Nov 2018 11:42:59 -0800 Subject: [PATCH] Fix probing for pre-1970 DST * lisp/calendar/cal-dst.el (calendar-next-time-zone-transition): Fix recently-introduced rounding bug when probing for DST transitions before 1970 (Bug#33380). --- lisp/calendar/cal-dst.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/calendar/cal-dst.el b/lisp/calendar/cal-dst.el index 25264bda09..8392e81b16 100644 --- a/lisp/calendar/cal-dst.el +++ b/lisp/calendar/cal-dst.el @@ -154,7 +154,7 @@ calendar-next-time-zone-transition (while ;; Set PROBE to halfway between LO and HI, rounding down. ;; If PROBE equals LO, we are done. - (not (= lo (setq probe (/ (+ lo hi) 2)))) + (not (= lo (setq probe (floor (+ lo hi) 2)))) ;; Set either LO or HI to PROBE, depending on probe results. (if (eq (car (current-time-zone probe)) hi-utc-diff) (setq hi probe) -- 2.19.1 --------------9950E35953CECAE9DEA815EF--