From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com,
monnier@iro.umontreal.ca, waah@yellowfrog.io
Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep
Date: Thu, 5 Mar 2020 02:15:21 +0200 [thread overview]
Message-ID: <c28bb3e8-6488-4908-0ca0-7b9a97ce169c@yandex.ru> (raw)
In-Reply-To: <838slhglog.fsf@gnu.org>
On 05.02.2020 16:20, Eli Zaretskii wrote:
>> And the first one makes a lot of sense (no need to invent an extra
>> variable if the way to store the necessary info is so obvious).
>
> I didn't say it didn't make sense. The only issue that worries me is
> how safe it is for the release branch. I have no issues whatsoever
> with making these changes on master.
I wouldn't say it's absolutely safe, but it would make me happier to
root out logical problems with the existing variable before the release.
>> There is some possibility of this causing a regression, but the changes
>> are relatively small. And no third-party code should be affected by this
>> change.
>
> Are you sure about third-party code? I'm worried by exactly the same
> assumptions as those which required you to do, e.g., the likes of
> this:
>
> diff --git a/lisp/icomplete.el b/lisp/icomplete.el
> index a1a67e2330..52429fdf37 100644
> --- a/lisp/icomplete.el
> +++ b/lisp/icomplete.el
> @@ -541,7 +541,7 @@ icomplete-exhibit
> (icomplete--completion-table)
> (icomplete--completion-predicate)
> (if (window-minibuffer-p)
> - (not minibuffer-completion-confirm)))))
> + (eq minibuffer-completion-confirm t)))))
> (buffer-undo-list t)
> deactivate-mark)
> ;; Do nothing if while-no-input was aborted.
The above is a simple bugfix of "why the hell not" variety: I don't
think that code worked well before that patch, i.e. it treated the
values of nil and t of REQUIRE-MATCH the same. Good thing that only
affected the choice of parens to print in the minibuffer.
> IOW, some code which just assumes that anything non-nil and
> non-confirm must be confirm-after-completion, or the other way
> around. It's an incompatible change.
I'm not arguing that is isn't. But looking at the actual uses out there,
the chief popular alternatives to completing-read-default don't seem to
be affected. And this variable is bound inside completing-read-default,
so only particular kind of code could really use it. Breakage is
possible, of course, but I'm fairly sure the affected audience would be
minimal.
Anyway, see the alternative patches in the branch 'fido-mode-fix' I just
pushed.
> Is the problem this attempts to fix really serious? Or is it just a
> minor inconvenience? It isn't the original one that started the bug
> report, right?
The patches fix both an inconvenience (one that started this bug report,
I'd say it is serious enough to make users stumped) and a bug. See my
previous message in this bug report for details.
next prev parent reply other threads:[~2020-03-05 0:15 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 17:09 bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep waah
2020-01-09 3:25 ` Dmitry Gutov
2020-01-09 7:42 ` João Távora
2020-01-09 7:49 ` waah
2020-01-09 9:54 ` João Távora
2020-01-09 10:10 ` João Távora
[not found] ` <944631362.128066.1578605073103@office.mailbox.org>
2020-01-09 22:27 ` Dmitry Gutov
2020-01-10 10:10 ` João Távora
2020-01-10 11:22 ` waah
[not found] ` <fd9ede8f-50dc-3bb4-d3b7-850e38a146ec@yandex.ru>
2020-01-11 18:59 ` João Távora
2020-01-18 1:38 ` Dmitry Gutov
2020-01-19 13:00 ` João Távora
2020-01-20 14:54 ` Dmitry Gutov
2020-01-20 14:58 ` João Távora
2020-01-20 21:42 ` Dmitry Gutov
2020-01-20 23:04 ` Stefan Monnier
2020-01-20 23:56 ` Dmitry Gutov
2020-01-21 8:12 ` João Távora
2020-01-23 22:22 ` Dmitry Gutov
2020-01-24 14:35 ` João Távora
2020-01-21 16:32 ` Stefan Monnier
2020-01-21 16:41 ` João Távora
2020-01-21 17:02 ` waah
2020-01-21 17:24 ` João Távora
2020-01-21 18:54 ` Stefan Monnier
2020-01-21 22:58 ` Dmitry Gutov
2020-01-22 0:29 ` João Távora
2020-01-22 0:32 ` Stefan Monnier
2020-01-22 12:34 ` Dmitry Gutov
2020-01-23 16:28 ` Stefan Monnier
2020-01-23 16:51 ` João Távora
2020-01-23 22:07 ` Dmitry Gutov
2020-01-24 14:11 ` Stefan Monnier
2020-01-24 14:31 ` Dmitry Gutov
2020-01-29 21:23 ` Stefan Monnier
2020-01-31 1:48 ` Dmitry Gutov
2020-01-31 13:17 ` Stefan Monnier
2020-01-31 23:18 ` Dmitry Gutov
2020-02-01 8:07 ` Eli Zaretskii
2020-02-04 23:57 ` Dmitry Gutov
2020-02-05 14:20 ` Eli Zaretskii
2020-02-05 14:27 ` João Távora
2020-02-05 17:55 ` Dmitry Gutov
2020-02-05 18:12 ` João Távora
2020-03-04 22:07 ` Dmitry Gutov
2020-03-04 22:44 ` João Távora
2020-03-05 0:01 ` Dmitry Gutov
2020-03-05 8:01 ` João Távora
2020-03-05 8:36 ` Dmitry Gutov
2020-03-05 8:46 ` João Távora
2020-03-05 9:59 ` Dmitry Gutov
2020-03-05 11:51 ` João Távora
2020-03-05 12:14 ` Dmitry Gutov
2020-03-05 12:30 ` João Távora
2020-03-05 13:40 ` Dmitry Gutov
2020-03-05 13:54 ` João Távora
2020-03-05 14:03 ` Dmitry Gutov
[not found] ` <CALDnm52HzQym7RosF3AdTNwprqXs7Kk4GBi+3UGjkJt6ZDUJWQ@mail.gmail.com>
2020-03-05 14:17 ` Dmitry Gutov
2020-03-05 14:26 ` João Távora
2020-03-05 14:40 ` João Távora
2020-03-05 14:53 ` Dmitry Gutov
2020-03-05 14:58 ` João Távora
2020-03-08 16:22 ` Stefan Monnier
2020-02-05 14:46 ` Stefan Monnier
2020-03-05 0:15 ` Dmitry Gutov [this message]
2020-03-05 6:08 ` Eli Zaretskii
2020-03-07 14:10 ` João Távora
2020-03-07 14:46 ` Eli Zaretskii
2020-03-07 16:42 ` João Távora
2020-03-07 16:47 ` Drew Adams
2020-03-07 17:42 ` Eli Zaretskii
2020-03-07 19:28 ` João Távora
2020-03-08 16:28 ` Stefan Monnier
2020-03-08 16:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c28bb3e8-6488-4908-0ca0-7b9a97ce169c@yandex.ru \
--to=dgutov@yandex.ru \
--cc=38992@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=joaotavora@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=waah@yellowfrog.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).