From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#46859: 28.0.50; [PATCH]: Add option to truncate long lines in xref.el Date: Sat, 6 Mar 2021 16:26:29 +0200 Message-ID: References: <878s74fv27.fsf@mail.linkov.net> <4119ea3055ef8f306fc0@heytings.org> <4119ea30557ef84ca190@heytings.org> <7eb7ee0f-7dba-c90d-cb58-af42c3828643@yandex.ru> <4119ea30554b406efbbf@heytings.org> <4119ea30558f1e4145b0@heytings.org> <4119ea30555e80bdcf7e@heytings.org> <1c82e582-8b90-f3c5-5391-1e88ca4e7ab2@yandex.ru> <4119ea30553e3f90ab8c@heytings.org> <87y2f42ex5.fsf@mail.linkov.net> <4119ea30552873ab9870@heytings.org> <83eegvk2u0.fsf@gnu.org> <9cff0f8894658f3b50c8@heytings.org> <83y2f3huz2.fsf@gnu.org> <9cff0f88942d4103c685@heytings.org> <83mtvjhrzj.fsf@gnu.org> <9cff0f889435d8d03313@heytings.org> <834khq266r.fsf@gnu.org> <9cff0f8894ab45713d12@heytings.org> <16ac41d4-5718-0cec-a68b-4abcc736ee4a@yandex.ru> <109276c6-30fb-b1ca-cafa-48a15710099b@yandex.ru> <7de1aeec520f4204be5b@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20521"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 46859@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 06 15:27:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIXtg-0005Di-9U for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 15:27:12 +0100 Original-Received: from localhost ([::1]:60648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIXtf-0006N9-AW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 09:27:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIXtX-0006M7-50 for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 09:27:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53009) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIXtW-0002bI-UO for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 09:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lIXtW-0004b4-RC for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 09:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Mar 2021 14:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46859-submit@debbugs.gnu.org id=B46859.161504080017628 (code B ref 46859); Sat, 06 Mar 2021 14:27:02 +0000 Original-Received: (at 46859) by debbugs.gnu.org; 6 Mar 2021 14:26:40 +0000 Original-Received: from localhost ([127.0.0.1]:36321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIXtA-0004aG-5o for submit@debbugs.gnu.org; Sat, 06 Mar 2021 09:26:40 -0500 Original-Received: from mail-ed1-f41.google.com ([209.85.208.41]:45133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIXt8-0004a1-On for 46859@debbugs.gnu.org; Sat, 06 Mar 2021 09:26:39 -0500 Original-Received: by mail-ed1-f41.google.com with SMTP id dm26so7119098edb.12 for <46859@debbugs.gnu.org>; Sat, 06 Mar 2021 06:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CRRnvrvzwQjZDkBZ3SsuP5L/Iwx8yd1cN/xXyPVJkxw=; b=CkOWwxnRIym7Tzj3/2zYINa0x+8yVNaF6crYuQq3HmZjhJVsOlsCF3n7vQcrMsYqKh Fz2JAwkyONMN3BQSOGD42GoozFCouas3hspIttnTMGDmjSZ2aX4Gx8GgdqAjTLxC7m1G ZPEtizQ3PCKZGQDSGkNr7STfu2oARbtNgOp8NyQ63bNfsK1gHgpURUrWNRM2kNibSavs sHgjRtZl4Of8yztt1G6xlRrXA1Lif23eLzVAD4u3X4imXckS1aK0u73m+zYYjfI3YLEZ firDb8epD8qo2NlvCw2v0n63MARKNpQZcvFdU771w6oMgYQcisqS5cUao2HpXnUzwihN /uPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CRRnvrvzwQjZDkBZ3SsuP5L/Iwx8yd1cN/xXyPVJkxw=; b=SHJh8RH/Hv+zMEQXBhxFvmBhndcWlCZQPlbnpMDNCCgKbP7XQc5MxKfglNrjPpW8WH FBOeCCeLs3VfG52jKOAasz2pfOT47odw+X84/1c7Cs18PpyhSivR1hoa2RGPtl+9FPyy V8opfkr1J+ApTaUjo2ZWyEh3Wk6O+3MYcYsWXXnwKzzUWsdsdYI70qXf50o3biORZFi8 /WHAtHA6qAnCWw810zLNi07ZUfoJbAh+FwG2fxuJ0CyB27Lt4ziMZLjfmjCXBxJe4ho8 Yow1seiT8M2By98k8gDc5Zd8oZV7UOA92SykE0plKlxL97n/sspyvmkxZpm2SB+7b4k3 91DA== X-Gm-Message-State: AOAM5324/GFD+6edNbANAzL6/7vNskih5/k2159K4Vp5fYGe99ChtPa4 1vERvHpofu/+utfNVAgJFg0Dm7Wy4UU= X-Google-Smtp-Source: ABdhPJzLewDD4IL41kAWCJDmGtH+5zN8z4IJx5SY4qruwGMugorFIl5BBaes6wAVm6rnRFZ1KOAx1A== X-Received: by 2002:a05:6402:499:: with SMTP id k25mr14114614edv.294.1615040793089; Sat, 06 Mar 2021 06:26:33 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m7sm3559969edp.81.2021.03.06.06.26.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Mar 2021 06:26:32 -0800 (PST) In-Reply-To: <7de1aeec520f4204be5b@heytings.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201635 Archived-At: On 06.03.2021 14:54, Gregory Heytings wrote: >> Also: grepping for that kind of regexp is noticeably slower than >> grepping for 'file'. Or even '.file'. Like 85ms vs 7ms slower. >> > > Well, the bug report mentioned delays of 3-4 seconds on files with very > long lines, so I'd guess that 85 ms is a pretty reasonable speed... We do want fast searches to remain fast, too. I got that 85ms timing when searching just one file. A project can often contain thousands of files. In my further testing, the difference is not as stark because of other Elisp overhead on file listing, serialization/deserialization/process calls/parsing output, but even with all that in my work project the difference between such searches can be 0.27s vs 0.43s. With further optimizations of project file listing logic, the difference can become even more pronounced (project-files in the same project takes 0.14s). You can benchmark it yourself with this form: (benchmark 1 '(project-find-regexp ".\\{0,100\\}file.\\{0,100\\}")) vs (benchmark 1 '(project-find-regexp "file")) (I get 9s vs 7s in the same project for this particular search).