bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)

bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)

[Clément Pit-Claudel]

[-- Attachment #1.1: Type: text/plain, Size: 820 bytes --]

X-Debbugs-CC: jeffersoncarpenter2@gmail.com

Hi all,

I think the following commit was a bit too enthusiastic, as variables like @temp are now highlighted in font-lock-type-face.

diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el
--- a/lisp/progmodes/perl-mode.el
+++ b/lisp/progmodes/perl-mode.el
@@ -181,4 +181,5 @@
      ;;
-     ;; Fontify local and my keywords as types.
-     ("\\<\\(local\\|my\\)\\>" . font-lock-type-face)
+     ;; Fontify declarators and prefixes as types.
+     ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\>" . font-lock-type-face) ; declarators
+     ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes
      ;;

Am I missing something? (I don't speak Perl, so I noticed this in a regression test)

Clément.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)

[Noam Postavsky]

unarchive 27613
notfixed 27613 26.1
quit

Clément Pit-Claudel <clement.pitclaudel@live.com> writes:

> I think the following commit was a bit too enthusiastic, as variables
> like @temp are now highlighted in font-lock-type-face.

I've reverted this from emacs-26 [1: f8cad16bb3].

> -     ("\\<\\(local\\|my\\)\\>" . font-lock-type-face)
> +     ;; Fontify declarators and prefixes as types.
> +     ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\>" . font-lock-type-face) ; declarators
> +     ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes

> Am I missing something? (I don't speak Perl, so I noticed this in a regression test)

I missed this in the originating thread, but according to what I'm
getting from web searches, most of those keywords are perl 6 specific.
I think perl-mode shouldn't support them.

[1: f8cad16bb3]: 2018-03-20 20:14:40 -0400
  Revert "Support all perl variable declarators and prefixes"
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f8cad16bb3272a8069b3008019f9d18516aef1a5>

bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)

[Clément Pit-Claudel]

[-- Attachment #1.1: Type: text/plain, Size: 689 bytes --]

>> Am I missing something? (I don't speak Perl, so I noticed this in a regression test)
> 
> I missed this in the originating thread, but according to what I'm
> getting from web searches, most of those keywords are perl 6 specific.
> I think perl-mode shouldn't support them.

Thanks.  My understanding was that these keywords could safely be highlighted, as long as care was taken to not highlight variable names (distinguishable due to the sigils).

> 
> [1: f8cad16bb3]: 2018-03-20 20:14:40 -0400
>   Revert "Support all perl variable declarators and prefixes"
>   https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f8cad16bb3272a8069b3008019f9d18516aef1a5>
> .
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)

[Lars Ingebrigtsen]

Noam Postavsky <npostavs@gmail.com> writes:

> Clément Pit-Claudel <clement.pitclaudel@live.com> writes:
>
>> I think the following commit was a bit too enthusiastic, as variables
>> like @temp are now highlighted in font-lock-type-face.
>
> I've reverted this from emacs-26 [1: f8cad16bb3].

If I understand this correctly, that means that this bug report was
fixed, so I'm closing it.  If I'm misinterpreting this, please reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no