From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxence Dutielt Newsgroups: gmane.emacs.bugs Subject: bug#52367: 27.2; lgrep and grep-files-aliases Date: Wed, 8 Dec 2021 01:54:26 +0100 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14442"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Cc: ofv@wanadoo.es To: 52367@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 08 02:12:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mulVE-0003YD-2a for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Dec 2021 02:12:12 +0100 Original-Received: from localhost ([::1]:60848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mulVC-0002aP-ED for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Dec 2021 20:12:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mulV4-0002aE-GW for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 20:12:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55749) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mulV4-00073j-9Q for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 20:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mulV4-0007sv-4z for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 20:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Maxence Dutielt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Dec 2021 01:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52367 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163892591730297 (code B ref -1); Wed, 08 Dec 2021 01:12:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Dec 2021 01:11:57 +0000 Original-Received: from localhost ([127.0.0.1]:39062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mulUy-0007sa-U1 for submit@debbugs.gnu.org; Tue, 07 Dec 2021 20:11:57 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:54006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mulE9-0007Sk-5z for submit@debbugs.gnu.org; Tue, 07 Dec 2021 19:54:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mulE8-0004G0-UI for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 19:54:32 -0500 Original-Received: from st43p00im-ztdg10073201.me.com ([17.58.63.177]:48401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mulE7-00029z-27 for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 19:54:32 -0500 Original-Received: from [192.168.1.13] (lfbn-lil-1-1030-172.w90-103.abo.wanadoo.fr [90.103.102.172]) by st43p00im-ztdg10073201.me.com (Postfix) with ESMTPSA id C09AB221DCA; Wed, 8 Dec 2021 00:54:27 +0000 (UTC) Content-Language: fr X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425, 18.0.790 definitions=2021-12-07_07:2021-12-06, 2021-12-07 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1030 mlxscore=0 mlxlogscore=919 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2009150000 definitions=main-2112080004 Received-SPF: pass client-ip=17.58.63.177; envelope-from=m@dutielt.com; helo=st43p00im-ztdg10073201.me.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, FROM_FMBLA_NEWDOM=1.499, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 07 Dec 2021 20:11:55 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221899 Archived-At: emacs -Q M-x lgrep Search for: foo Search for "foo" in files matching wildcard (default all): all In directory: ~/foobar will always output this error if you don't have any filename starting with two dots: grep: ..?*: No such file or directory Grep exited abnormally with code 2 I noticed "..?*" was introduced here: commit ref: 856cd948d1a5a016ad36721246a049d33451902f after reviewing bug #22577 (archived): https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22577 Now that Emacs is smarter at quoting shell commands (at least on 27.2), "* .[!.]* ..?*" seems overcomplicated and no longer necessary. I couldn't reproduce bug #22577 with vc-git-grep as mentioned, using both BSD and GNU grep on Linux, Windows and macOS. Since "* .*" works as expected again, and doesn't produce the error of "..?*", I think it should be reverted back into grep-files-aliases. Lastly, to avoid such messages when using lgrep: grep: foobar: Is a directory We could add the parameter --directories=skip by default, since lgrep is not for recursive search.