unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: lennart.borgman@gmail.com, 6227@debbugs.gnu.org
Subject: bug#6227: Color isearch regexp submatches differently
Date: Sun, 20 Sep 2020 21:49:26 -0700 (PDT)	[thread overview]
Message-ID: <c1b858c9-9b32-43cb-99a6-c4a80c481514@default> (raw)
In-Reply-To: <<835z87zx16.fsf@gnu.org>>

> > I'd rather go the other way, to be honest -- just leave group-1 to -3,
> > perhaps.  I think it's rather unusual to have a that many sub-groups
> > interactively...
> 
> That's true, but the problem which bothers me is that customizing
> search-highlight-submatches alone to a larger value is not enough.  I
> don't think any other customization we have requires users to create
> faces or similar objects.

FWIW, the option in Isearch+ is just a boolean, not
a max number of levels/groups.  I use it for both
Isearch and `replace-highlight'.  The use cases are
only interactive, AFAICimagine, and I don't imagine
(and haven't seen) any need for lots of levels.  I
use 8 levels, and that's already a lot.

As for the relation between your max # groups and
faces: if you really want to let users change the
max # (not needed, I think), you can just have a
fixed number of faces and recycle them.  You don't
have to imagine that users will need to both (1)
increase `search-highlight-submatches' and (2)
create corresponding new faces for the additional
groups to be matched.  It's pretty clear which
level is involved if the same color is used for,
say, level 2 and level 10.

I mentioned this recycling possibility earlier,
saying that I considered going through the 1-8
faces I have and then going through them again, for
groups 9-18, and again,...  But I've never seen any
need for that.  Your design sounds like overkill, if
the intention is just interactive use.

Just a suggestion.

Also, your option name should have "max" in it, I
think.  And if you use it only for Isearch, then
maybe use "isearch", not "search" in the name.





       reply	other threads:[~2020-09-21  4:49 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<AANLkTikUlBKGt388RPJkU8tM6A_fpMPsTkvo6cbI3D56@mail.gmail.com>
     [not found] ` <<87bpca15ja.fsf@mail.jurta.org>
     [not found]   ` <<AANLkTilV0TlRQRCC7-uAuspGAwTYhMySTbh4dOjKIDM0@mail.gmail.com>
     [not found]     ` <<87wruv1ohr.fsf@mail.jurta.org>
     [not found]       ` <<AANLkTimRAHa4K6FlX_952j3s2saDmcXMIbDOYx9xk8Fh@mail.gmail.com>
     [not found]         ` <<877hmvtn9t.fsf@mail.jurta.org>
     [not found]           ` <<AANLkTiljPa2oALTtTabtFb3_KHhPB9NNqnKzXZWIh_v4@mail.gmail.com>
     [not found]             ` <<874ohyppfs.fsf@mail.jurta.org>
     [not found]               ` <<AANLkTilPUyzW5lCEdQv-WD6_0WdVbDiofmN34UHMVLNA@mail.gmail.com>
     [not found]                 ` <<AANLkTileYK0D0RTKAePLbax_9o9JbgNlpuNXbLBzBssY@mail.gmail.com>
     [not found]                   ` <<8739ww1tjp.fsf@mail.jurta.org>
     [not found]                     ` <<AANLkTilwC3QBYmtzPg3zrDoD44deoBsD5rxxP-dNhxnH@mail.gmail.com>
     [not found]                       ` <<87d3vyaodq.fsf@mail.jurta.org>
     [not found]                         ` <<87hbla4nl4.fsf@mail.jurta.org>
     [not found]                           ` <<87mu1llak3.fsf@gnus.org>
     [not found]                             ` <<83lfh50zxa.fsf@gnu.org>
     [not found]                               ` <<87eemwss3t.fsf@gnus.org>
     [not found]                                 ` <<834kns22q2.fsf@gnu.org>
     [not found]                                   ` <<87sgbcrcgd.fsf@gnus.org>
     [not found]                                     ` <<874knso90e.fsf@gnus.org>
     [not found]                                       ` <<83pn6gzg3j.fsf@gnu.org>
     [not found]                                         ` <<87363ckza5.fsf@gnus.org>
     [not found]                                           ` <<835z87zx16.fsf@gnu.org>
2020-09-21  4:49                                             ` Drew Adams [this message]
2010-05-20 11:01 bug#6227: Color isearch regexp submatches differently Lennart Borgman
2010-05-20 13:21 ` Drew Adams
2010-05-20 13:28   ` Lennart Borgman
2010-05-20 13:33     ` Drew Adams
2010-05-20 15:02       ` Drew Adams
2010-05-21  0:07 ` Juri Linkov
2010-05-21  1:19   ` Lennart Borgman
2010-05-22 23:44     ` Juri Linkov
2010-05-23  0:51       ` Lennart Borgman
2010-05-23  0:54         ` Juri Linkov
2010-05-23 10:04           ` Lennart Borgman
2010-05-23 16:12             ` Juri Linkov
2010-05-23 16:40               ` Lennart Borgman
2010-06-08 13:37                 ` Lennart Borgman
2010-06-09  8:36                   ` Juri Linkov
2010-06-09  9:14                     ` Lennart Borgman
2010-06-10 15:28                       ` Juri Linkov
2010-06-10 15:52                         ` Lennart Borgman
2010-06-10 20:52                         ` Juri Linkov
2010-06-10 21:41                           ` Lennart Borgman
2010-06-11  0:44                             ` Stefan Monnier
2010-06-11  8:17                               ` Juri Linkov
2020-09-19 21:29                           ` Lars Ingebrigtsen
2020-09-19 22:19                             ` Drew Adams
2020-09-20  5:39                             ` Eli Zaretskii
2020-09-20  9:41                               ` Lars Ingebrigtsen
2020-09-20  9:53                                 ` Eli Zaretskii
2020-09-20 10:04                                   ` Lars Ingebrigtsen
2020-09-20 13:47                                     ` Lars Ingebrigtsen
2020-09-20 14:18                                       ` Eli Zaretskii
2020-09-20 19:45                                         ` Lars Ingebrigtsen
2020-09-20 20:25                                           ` Drew Adams
2020-09-21  2:25                                           ` Eli Zaretskii
2020-09-21 13:48                                             ` Lars Ingebrigtsen
2020-09-20 16:41                                     ` Drew Adams
2020-09-20 16:45                                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1b858c9-9b32-43cb-99a6-c4a80c481514@default \
    --to=drew.adams@oracle.com \
    --cc=6227@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=lennart.borgman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).