From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M- Date: Tue, 13 Oct 2020 22:18:05 -0700 (PDT) Message-ID: References: <<584510D2C7DE47CBAE19B5058B21B51C@us.oracle.com>> <<87eh3ba7s9.fsf@building.gnus.org>> <> <<877fhuej87.fsf@gnus.org>> <> <<87bn4t7ih6.fsf@gnus.org>> <<2493efa4-e079-446c-8926-f7ee14c04ec9@default>> <<87eg9oa7kp.fsf@gnus.org>> <> <<6b5e4737-edb3-4f0c-b4e7-252330d3436e@default>> <<8736ji3vgs.fsf@gmail.com>> <<9551e332-3baf-49d0-a6ff-4b2432457d5d@default>> <<83r2717si6.fsf@gnu.org>> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18520"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 12535@debbugs.gnu.org, larsi@gnus.org, npostavs@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 14 07:19:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSZBy-0004i3-4E for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 07:19:14 +0200 Original-Received: from localhost ([::1]:40128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSZBw-0003pF-TF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 01:19:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSZBm-0003om-81 for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 01:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38201) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSZBl-00029c-VD for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 01:19:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSZBl-0007NL-QW for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 01:19:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <584510D2C7DE47CBAE19B5058B21B51C@us.oracle.com> Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Oct 2020 05:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12535 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12535-submit@debbugs.gnu.org id=B12535.160265269928299 (code B ref 12535); Wed, 14 Oct 2020 05:19:01 +0000 Original-Received: (at 12535) by debbugs.gnu.org; 14 Oct 2020 05:18:19 +0000 Original-Received: from localhost ([127.0.0.1]:49745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSZB5-0007ML-GJ for submit@debbugs.gnu.org; Wed, 14 Oct 2020 01:18:19 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:37748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSZB2-0007M1-2q for 12535@debbugs.gnu.org; Wed, 14 Oct 2020 01:18:17 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09E4xmAh075068; Wed, 14 Oct 2020 05:18:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=lGlL82EamGjGA3XvNLnMu/h/Pta4I1EsNbNUnXbRIkE=; b=P4Dulow9xp8JbVlyHQKeTklwYogFzZeyVOWUFAP2LOBK7fE05GmJwGAGQjIKiIeWxJ/0 lyU6p5otKTjDcgajIzRJFeIHObUNL0/GSQEp76fpBaJiJWvN3ahaxma2tz7gmIlZJRJg WITQj9TDWUemEeviHc+JtGzSxi9HMY6HrtokS3ymxH+XM8q3tc1/1RKhjWNA3d8hgfMz mvHd3oOX3+0/yhhmTuumck2bV6rSV6TSbplW9yEpcDtx9zRIzT/AfVg3NXVrmaj9uaNp mpUdqtq7Y1FzpjhW5lHADY95Ckd7qGhrL9k8EgycFzK+/5sGz4s2Iy7++NxuAcEIbX5s XQ== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 343vaebtav-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 14 Oct 2020 05:18:10 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09E51G11003897; Wed, 14 Oct 2020 05:18:09 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 343puyuhvq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Oct 2020 05:18:09 +0000 Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 09E5I7KF008224; Wed, 14 Oct 2020 05:18:08 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9773 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010140035 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9773 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 clxscore=1015 impostorscore=0 phishscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010140035 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190475 Archived-At: [Trying again, after unarchiving.] This is closed, marked as "DONE". Doesn't that mean that it was fixed? (I'm not clear on what "DONE" is meant to indicate.) If so, that's incorrect - the bug is still present. Shouldn't it be tagged as "wontfix", since that was the decision? (Or perhaps "DONE" includes closures other than just fixes?) ___ BTW, in addition to adding \\|TAB where I suggested, the code could be improved slightly by changing most of the `string-match' occurrences to `string-match-p', as most of them don't need to set the match data. Just a (minor) suggestion.