From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#50867: 27.2; window-toggle-side-windows adds an extra window Date: Wed, 29 Sep 2021 11:28:02 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14942"; mail-complaints-to="usenet@ciao.gmane.io" To: Indrajeet Khandekar , 50867@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 29 11:29:38 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVVuC-0003eq-UQ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Sep 2021 11:29:36 +0200 Original-Received: from localhost ([::1]:37912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVVuB-0002Dt-S2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Sep 2021 05:29:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVVte-00026z-2o for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2021 05:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36244) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVVtd-0005tc-Pn for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2021 05:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVVtd-000463-KC for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2021 05:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Sep 2021 09:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50867 X-GNU-PR-Package: emacs Original-Received: via spool by 50867-submit@debbugs.gnu.org id=B50867.163290769415685 (code B ref 50867); Wed, 29 Sep 2021 09:29:01 +0000 Original-Received: (at 50867) by debbugs.gnu.org; 29 Sep 2021 09:28:14 +0000 Original-Received: from localhost ([127.0.0.1]:47790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVVsr-00044v-Mq for submit@debbugs.gnu.org; Wed, 29 Sep 2021 05:28:13 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:45723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVVsp-00044e-25 for 50867@debbugs.gnu.org; Wed, 29 Sep 2021 05:28:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1632907684; bh=QuqQeWLclEw2j/jBzD/wAdG7OA5aIekdxAGFCx4hhqc=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=c8Qod8ujfnIMgQsW0fjl/qBWSnnVO0VaxNlbzVdcBT7pIz/pQSxBwwUYPs+OPQ8N+ ngrmJcqCRV42GGL1aX6yjGZ7zl+a5zCvA33iFdZOWNV8YJasHhdFqnHn/PNFnEq1Aw QfQsa5q00LC8AIcfFvI9Nxc4R8k9QiACQ9d1jLBg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([213.142.96.147]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mof9F-1nBg7h18RN-00p15l; Wed, 29 Sep 2021 11:28:04 +0200 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:eqZrzigxDjQGBLhSu4bBOXHQEjGsyEqEy/aMlsahZQu4PO5gItT Cy9ng7CvP8NVpYj1ZxAL8Q8YosVazDOTiB4aci5WOp++Dcw6sWEllyd2542cBv0GVNjjMH/ +Y5lxlt6ZFcJ4kXyKqGsLPORkOdLFm0V8W58Nr7RR92iyVZlUHSo5sLrMelMCddvQsOBBMi WINsIpqdqaUL7BBHN3lkw== X-UI-Out-Filterresults: notjunk:1;V03:K0:fBVqZi62znA=:odySaSMDuFiGhmfOM0jCLy SEqfadF85vcG5y9LlrH3s6iWo+oj1fyS4L2jeT4XsDIOyaFiqZas4h/7BuHdaW1W3jxokvtrr HQimwQQsRh0of6F7nZWOu4NyfGA3m5VMAEzaAzpK4rpcVPNb/p9Y4zziFX3DS/qjk6KnTIkFW t5uNw1AYMHbhs9/qzmht860Fgvkt2t0CvgrQ9ND4CVc3rKf2R1LkaeN4etNFykq5m/HTMCVaX AO7uJ+tRtEnHFSC484UJfBtDsfe9WqZuDee2QQl/xV+Ui++xhdoxqyqtgYkeg+jMBnH1RNHuU FhNGpq2T9cY33sER+ps22NZmqY0QF3xcH9n0YhtGFhwmXfI/EOh8YWfPbT8Ci78KvqZUdxbU5 kfeNrSe0+SVuasBQ3G0Mg5rZ9p+zajPnUmljb5qrC+IiA+YjOK8pMaf3Lzpnf+Allqfj7FH2C 6uPGABKFu7pDq5AepqiHY8jQLmyqCM6hVowFdbq6JJe3jvEzoUX9ohKCdrNtuvL9I2ZQLOvSm FQrTezCleLOtCKiWMQCNfXjIMJHRVhKlp+ZT4drp/ORHldUe3wkET3i2KlVDrcmRs/LAq4Al7 DnbmrEFDAMvapslh2KCm2npFmUbUAzw1746j663nHB43vxsR61wvfGHi3csdLOb5FxMfmlSsU Zd9/EEioXDpkbo3CcArKIXHjgISuPaF/uutXYAnfdEIH/Bk6l/R+ODN086gcIpKS68p9GTdHI 12nVzoGlz2yMojTJTqT9bj0OqJXvjh9eStnxEyo0S0wL9qKwAXldE07OTvMMyKhq6XgOBQNe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215827 Archived-At: > 1. start a vanila emacs session > 2. using scratch buffer, use follow display buffer alist configuration > > (setq display-buffer-alist > '(("\\*\\(Async Shell Command\\|Shell Command Output\\)\\*" > (display-buffer-reuse-window display-buffer-in-side-window) > (window-width . 0.40) > (side . right) > (slot . 0)))) > > 3. split the window horizontally using `C-x 3` > 4. run `M-x async-shell-command ls RET` > 5. run `M-x window-toggle-side-windows` > 6. run `M-x window-toggle-side-windows` > > You will see that there is an extra, window added, to the frame. > > > > In GNU Emacs 27.2 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G95)) > of 2021-03-28 built on builder10-14.porkrind.org > Windowing system distributor 'Apple', version 10.3.2022 > System Description: macOS 11.6 Thanks for the report. I hopefully fixed this now for Emacs 28. If you want this to work for Emacs 27, please apply the patch below and either rebuild Emacs or put the definition of 'window-toggle-side-windows' into your .emacs. All the best, martin diff --git a/lisp/window.el b/lisp/window.el index b240b16f24..1b02eff17b 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -1212,7 +1216,8 @@ window-toggle-side-windows ((setq state (frame-parameter frame 'window-state)) ;; A window state was saved for FRAME. Restore it and put the ;; current root window into its main window. - (let ((main-state (window-state-get (frame-root-window frame)))) + (let ((window-combination-resize t) + (main-state (window-state-get (frame-root-window frame)))) (window-state-put state (frame-root-window frame) t) (window-state-put main-state (window-main-window frame))) (window--sides-reverse-frame frame))