From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#14724: 24.3.50; `isearch-open-necessary-overlays' handling of overlay property 'isearch-open-invisible' Date: Wed, 26 Jun 2013 09:24:53 -0700 (PDT) Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1372263971 12036 80.91.229.3 (26 Jun 2013 16:26:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Jun 2013 16:26:11 +0000 (UTC) To: 14724@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 26 18:26:11 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrsXq-0003XY-Na for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2013 18:26:10 +0200 Original-Received: from localhost ([::1]:45137 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrsXq-0002uu-7O for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2013 12:26:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrsXl-0002uZ-7N for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 12:26:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrsXj-0005iA-Eu for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 12:26:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrsXj-0005i4-BU for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 12:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UrsXi-0000xY-Mj for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 12:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2013 16:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14724 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13722639153571 (code B ref -1); Wed, 26 Jun 2013 16:26:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Jun 2013 16:25:15 +0000 Original-Received: from localhost ([127.0.0.1]:43176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrsWv-0000vU-Tw for submit@debbugs.gnu.org; Wed, 26 Jun 2013 12:25:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59163) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrsWr-0000v8-HF for submit@debbugs.gnu.org; Wed, 26 Jun 2013 12:25:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrsWk-0005Jy-6J for submit@debbugs.gnu.org; Wed, 26 Jun 2013 12:25:04 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:44380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrsWk-0005J0-1E for submit@debbugs.gnu.org; Wed, 26 Jun 2013 12:25:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrsWi-0002lE-Px for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 12:25:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrsWe-000586-Hy for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 12:25:00 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:21664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrsWe-000573-Bg for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 12:24:56 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r5QGOsRZ021632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 26 Jun 2013 16:24:55 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5QGOsrb008957 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 26 Jun 2013 16:24:54 GMT Original-Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5QGOsZh008954 for ; Wed, 26 Jun 2013 16:24:54 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75615 Archived-At: The code would be more robust if it would gracefully handle (1) an non-functional value and perhaps also (2) a functional value where invoking the function raises an error. Here is the problematic code: (funcall (overlay-get ov 'isearch-open-invisible) ov) For (1), the code could be like this: (when (functionp (overlay-get ov 'isearch-open-invisible)) (funcall (overlay-get ov 'isearch-open-invisible) ov)) For (1+2), that could be wrapped in `ignore-errors'. Dunno whether (2) is an important case to handle or whether it is really advisable to ignore such an error. Handling (1) seems to me reasonable, and with no downside. The behavior is to just do nothing additional with the overlay - e.g., leave the text invisible. Dunno know whether similar considerations apply to `isearch-open-invisible-temporary'. I'm guessing no - its value seems to be provided only by the Isearch code (whereas code far from Isearch sets the `isearch-open-invisible' overlay property). In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-06-20 on ODIEONE Bzr revision: 113100 eliz@gnu.org-20130620173624-w9v620tog4yacftk Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs CFLAGS=3D-O0 -g3 LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include'