From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Sat, 16 Nov 2019 01:50:22 +0200 Message-ID: References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <83blte7kvc.fsf@gnu.org> <838soi5xm1.fsf@gnu.org> <838soh4l4n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="65628"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: jonas@bernoul.li, 37774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 16 00:51:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVlMt-000GvV-3r for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Nov 2019 00:51:11 +0100 Original-Received: from localhost ([::1]:45792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVlMr-0005vf-IP for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2019 18:51:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36366) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVlMl-0005vV-My for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 18:51:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVlMk-0000LM-J0 for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 18:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56910) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVlMk-0000LI-Fr for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 18:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVlMk-00070r-C8 for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 18:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2019 23:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157386183626921 (code B ref 37774); Fri, 15 Nov 2019 23:51:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 15 Nov 2019 23:50:36 +0000 Original-Received: from localhost ([127.0.0.1]:37498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVlMI-000705-BF for submit@debbugs.gnu.org; Fri, 15 Nov 2019 18:50:36 -0500 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:40870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVlMG-0006zq-2o for 37774@debbugs.gnu.org; Fri, 15 Nov 2019 18:50:32 -0500 Original-Received: by mail-wr1-f44.google.com with SMTP id i10so12735682wrs.7 for <37774@debbugs.gnu.org>; Fri, 15 Nov 2019 15:50:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Tghl0dU02f3Z8bgcUVfZB1SiF1REE5gSqPpVhZlBTGo=; b=M6mTdY/MNL8ITV3zV+FIkfUlnjetSMXGcHKIHUUhZUsYhj3BpBq+lYH725drCcWAV9 LGDIe+BqIl3tgas1ys3MTCoSjXQeJ9UWju50iYpkxWsj3XDCkUh+VXA724JcQOUq+tt3 As5IDzMq+xAIOTXHqV0p5UHQJkQigfnoiTx4o12vDJeJaZcG6pqZnRHwdNfwRxDmpR/A HmtBv9pADcLQ8qAerf75o5irJTdq1Ns2B3d6lrYy+O4iqX9S/coSsw/Fjxpfz8jKd4Kr iT22YYQp5y/u2nUZZGAW6YwrXxNP/l1dov+EQCG0mwrxXJ3VEiKojS0ChydxEYxEDKvV FHpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Tghl0dU02f3Z8bgcUVfZB1SiF1REE5gSqPpVhZlBTGo=; b=lZx4k8xAwk9oyN1sUQqWmwOsUlZx5FtSq3gWuvncduvHswNAT1/ROde+n5REpk5Be1 /el+NTvLeAmCz/XFWG8QWa9yQ6+gUexSXtTvOm8cAI4ehKJxHfqsptClZCvi+r4djxER CIJJVUBpgIpeoFnxFM47geADGBR9ZD7W7IiFql7NH/ZPTX0Q65Ee6Ba1FgILKdbJQgVS 3qViiFQvGBVQPxSTDK0K7vuL8fHR8kfct8Nv6Bvm3oey3M/9R9WygK4hCRvzE4cpUCFD OHNVvQGeHDjIqRGY4YndX2NgMcK/ROJihlDS4h1RxuLcx9+fWndJool0wCYOl3fcs78Q 1+Gg== X-Gm-Message-State: APjAAAW+MgFTAgTlEcTRqKc8HUuQJs0JxxL/PdEHyoTD+u8nwlEIGyPB iHHIPVYM7V2uEYolje4uf79jgwi/CH4= X-Google-Smtp-Source: APXvYqyY/33Tl08xQtqbohZefe+Vdi4qDBKx9McELOIaIwmWuXlm7POhDoqKCTZjR0S/lFC32d1VyA== X-Received: by 2002:adf:ce05:: with SMTP id p5mr382483wrn.48.1573861825673; Fri, 15 Nov 2019 15:50:25 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id w18sm13055646wrl.2.2019.11.15.15.50.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Nov 2019 15:50:24 -0800 (PST) In-Reply-To: <838soh4l4n.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171688 Archived-At: On 15.11.2019 10:08, Eli Zaretskii wrote: >> Lots of themes out there, though. Lots of said authors. Who will have to >> do a version check and the splat-unquote thing, every one of them. I >> think that's pretty bad. > > It's not bad, because IMO most faces don't need to be changed at all. > That Jonas and others went ahead and decided to change almost all of > them is IMO a mistake. I'm not sure which faces he changed exactly, but IIUC there were at least 5 faces that need to be changed (maybe more). And that would have to happen in every theme. >>> If the backward compatibility (or, rather, transparent DWIM-ish >>> operation) is the overriding consideration, then you are actually >>> saying that any face attribute we will introduce in the future will >>> have to be treated the same? >> >> I don't know what attributes we will introduce, and whether the default >> values will be a departure from the previous behavior like this one is. > > It doesn't matter if the default face definition uses that attribute, > does it? Well, it kind of does. At least, if the default value of the new attribute is in line with the previous behavior, most faces won't have to change. They *might* (or some of them might), but that would be on the authors of that code, and the new feature would trickle down gradually, like we usually do with Emacs. >> But please note that having it a face attribute was your choice (or >> maybe Ergus's). I suggested using a symbol property instead. Though I >> was admittedly late to the party. Doing it in this way would side-step a >> number of questions like the ones you just asked. > > Using a symbol property is extremely unclean, IMO, and would > unnecessarily complicate the face-merging code. Fair enough. Another option that had been voiced is to split the value into two attributes: :extend-foreground and :extend-background. Then we can set the default values for both an immediate improvement (:extend-foreground to nil) and maximum compatibility (:extend-background to t). But that brings me to a question. I think whether the 'region' face has :extend-background to nil or not is a personal choice. Would the user have to fight and convince the author of the theme they are using to change that attribute? Or will it be easy to apply personal customization and call it a day? > I guess the best solution at this point is to require all themes to > make the appropriate changes. Or that.