From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#35390: 26.2; [PATCH] `ls-lisp--dired', like `dired', should accept nil DIR-OR-LIST argument Date: Tue, 23 Apr 2019 05:24:56 -0700 (PDT) Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="36537"; mail-complaints-to="usenet@blaine.gmane.org" To: 35390@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 23 14:28:44 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIuXT-0009N9-LV for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2019 14:28:43 +0200 Original-Received: from localhost ([127.0.0.1]:53121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIuXS-0005Yv-K6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2019 08:28:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIuUu-0003WN-Gn for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 08:26:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIuUt-0001NW-Dm for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 08:26:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39114) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIuUt-0001NE-9x for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 08:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIuUs-0005df-KR for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 08:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Apr 2019 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35390 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155602231121602 (code B ref -1); Tue, 23 Apr 2019 12:26:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Apr 2019 12:25:11 +0000 Original-Received: from localhost ([127.0.0.1]:52657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIuU3-0005cM-66 for submit@debbugs.gnu.org; Tue, 23 Apr 2019 08:25:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIuU1-0005c3-D5 for submit@debbugs.gnu.org; Tue, 23 Apr 2019 08:25:10 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:58450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hIuTw-0000fZ-6w for submit@debbugs.gnu.org; Tue, 23 Apr 2019 08:25:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIuTv-0002Sf-0l for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 08:25:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIuTt-0000eW-Ui for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 08:25:02 -0400 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:60010) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hIuTt-0000dZ-Ma for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 08:25:01 -0400 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3NCOF46005668 for ; Tue, 23 Apr 2019 12:24:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=Yb2Q+D/BdNCY6E6KEyOVfu2OYGkGwBi0Obp6sUZWM88=; b=qflQnF4Xajwe4Fk9glgI7BITpfFgVQdTEM7fhOCmcYV1FjJl3siB+3iozzqPXZA7c5Hd 0mwpbsxqpXTI0ATHJu7JRT4L79RdgcwHCtY3NsHMS6gvvzjGXoTmCDsLKKOM7h9W7Gh7 csCA9Qt9W4MCGhxoHG5pXOT/i7cnXRejXMbxtLPyEmytQIb/K2AuBI+MtgmM1DjzAB9/ VA3HGrLJbAJuODwJjtT1R/sPY7QMS1Gul9Xw9kfNyWdxIoJb7jUSdJ3jbwJjXRduvUoL T+nEelsCl+KwuSDPpuFMeyG00eWD7NnX5eabEARhiUrvnbbsfYiyCjTIE2xBRB1D36Sz JA== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 2ryrxcuyxf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 23 Apr 2019 12:24:59 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3NCOUY5040472 for ; Tue, 23 Apr 2019 12:24:58 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2s0f0vfe06-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 23 Apr 2019 12:24:58 +0000 Original-Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x3NCOvKr010061 for ; Tue, 23 Apr 2019 12:24:57 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4834.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9235 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904230086 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9235 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904230087 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158125 Archived-At: The doc of command `dired' does not define the behavior if its DIRNAME argument is not a string or a cons. `dired' just passes this arg to `dired-noselect', and `dired-noselect' starts by doing this: (or dir-or-list (setq dir-or-list default-directory)) This means that `dired', via `dired-noselect', handles a nil value for DIRNAME by using the value of `default-directory' (a string). `ls-lisp--dired' should do the same - it is a stand-in for `dired'. Currently it raises an error if passed nil as the directory. It would make sense to add this at the beginning of `ls-lisp--dired' (just after the `interactive' spec): (unless dir-or-list (setq dir-or-list default-directory)) That's the "patch" - just add that line as indicated. [BTW, the doc string of `dired' has this as its last line, which doesn't make sense - DIRNAME is either a directory name or a cons of a directory name and a list of file names: "If DIRNAME is already in a Dired buffer"... I think it's trying to say that if _the directory specified by DIRNAME_ is already shown in a Dired buffer...] In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32) of 2019-04-13 Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749 Windowing system distributor `Microsoft Corp.', version 10.0.17134 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3''