From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#47244: 28.0.50; SIGSEGV in long-runnning Emacs Date: Tue, 30 Mar 2021 09:30:30 +0200 Message-ID: References: <87im5ofp3z.fsf@md5i.com> <83czvvdw7o.fsf@gnu.org> <14e14f28-7ece-cd98-5e49-d4583a0153a0@gmx.at> <16b279ef-a1c2-cd41-b18c-69383174c72a@gmx.at> <87a6qs7z60.fsf@md5i.com> <83eeg3kawg.fsf@gnu.org> <83y2e6kp9t.fsf@gnu.org> <83tuouknpb.fsf@gnu.org> <83sg4eknh5.fsf@gnu.org> <83r1jykmt0.fsf@gnu.org> <2d0dbdc8-3678-cd21-234a-9c63bb004629@gmx.at> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------B6F9B872FF3A8C0F6407F534" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35920"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "mwd@md5i.com" , "schwab@linux-m68k.org" , "47244@debbugs.gnu.org" <47244@debbugs.gnu.org> To: Michael Welsh Duggan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 30 09:31:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lR8qG-0009HU-3J for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Mar 2021 09:31:12 +0200 Original-Received: from localhost ([::1]:34902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lR8qE-0006ce-Kw for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Mar 2021 03:31:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lR8q5-0006aP-UW for bug-gnu-emacs@gnu.org; Tue, 30 Mar 2021 03:31:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38733) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lR8q5-0006LH-LM for bug-gnu-emacs@gnu.org; Tue, 30 Mar 2021 03:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lR8q5-0002fP-Ib for bug-gnu-emacs@gnu.org; Tue, 30 Mar 2021 03:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Mar 2021 07:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47244 X-GNU-PR-Package: emacs Original-Received: via spool by 47244-submit@debbugs.gnu.org id=B47244.161708944810224 (code B ref 47244); Tue, 30 Mar 2021 07:31:01 +0000 Original-Received: (at 47244) by debbugs.gnu.org; 30 Mar 2021 07:30:48 +0000 Original-Received: from localhost ([127.0.0.1]:50278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lR8ps-0002eq-1R for submit@debbugs.gnu.org; Tue, 30 Mar 2021 03:30:48 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:41415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lR8pq-0002eZ-Cg for 47244@debbugs.gnu.org; Tue, 30 Mar 2021 03:30:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1617089433; bh=5Td7JcTolNGiwBtW3uYx9fZs9wZkApFQK4YgZD10UpA=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=PKT+x/Fi7bCTRl5Fh/Xr66DouSRIvomFymE2ys8UrjliTxjc7XIL/7XQZRMWVcvVY w9v2ctySr0IMZe8Vf2o5KLNYoCh2KKLIYgPMhdGy6vq7+HV2uG8zJ2HQ80KwzqvrVm dKNYcpRr++4cYPf9+5Mx8AvDHudcpH8zyfYXhr+Q= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.203]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N5G9t-1lb9B60bDh-011AGD; Tue, 30 Mar 2021 09:30:33 +0200 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:12t/6vRTpyAx9Q6iM4xcg5VIwv066sf2b1xzqX9ivJ7bn9icUYt GkR4bR1t6C0KIGX5xwBAYg9M14WIzVKYuKxPLCfJExJikT3OY0kiZQxUuvfmL+KFnXseRsw qXPk/OktXn7iLqCjMZcJZAy5cYpNAXB8ebyXCCiXurGF5XxQve/ekwpzs5bqlQdqxgxhlla LtYUDtYuBrprPCaQDOO/g== X-UI-Out-Filterresults: notjunk:1;V03:K0:aKSEJ0fzEmY=:F67BquwJUlmNK3oxeRigCt KDVPuk4SmuYbWgZZ+UQX27QKQFjtUbRmu2ffJm9qE5JXiqpn1bmK8ZsaXjwKdYeePAMEjfppL syKi8Ae5oXcG7XJu1sqoHohxjReuJ92VF1XO/E8kru1iJfxFc4pwbYSC7PgU5Zu7tpqMAJSNI 3n7kRfC+f4YwSPNxojdV946f3nZHE+6eIolZi4JhPD9S1pfsyD1fftCIgJ9BKBLSSquQHlM/L Re7MMgscH5qk1ZxRQ86b1w0scc3cqiGpEOUrHNOzZCbRO3jliMvF6iNKrX+9+++CJUBrI/SZi KY9cQKChikAwbvO1NtshVN1Z0Od8aHfGjM2UmVKKoPNzH2kub612wFUIHLsVw1dTFxd7DF75m sPdGc0eoieleTrHC9rwGIVqJwAoVub4vEjzNeV/D6s+1btmluDUazD+OCb/eMbz0uKT8HGS4k Rba1C9zUEoipwXvqPIMVjpmoPFt5tHhkn1NIwyzPuhIAVopx2oI6JBcYu9IqcKB95Yd5PXGHS 84qGzT11o06tMDLo+CPxcO1yKVEuNolMnmngaIvNuvGkjgd4VtSCoEpuo/J7Myy4KNChfJopE JFSy672VHa0oNZxkmFwyCUq0CZeeX3qg1jucwKem1OExksb1iIWVtXEN+ffADvS+gaJxJpSLD kO0C+RiTh+mvhLe6k+dQ4orreBJ+atqXCF4UjCwBGD5hIVJjutYSbg32vkYpg48KxkiwHg5VV smuFZtoYbnzvTG01ugvrAobfmy8tYcnMvRIKnXXjbTR4kenz+LDLsJIe7bG+FPn/pWp/0g8b X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203281 Archived-At: This is a multi-part message in MIME format. --------------B6F9B872FF3A8C0F6407F534 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > I sincerely hope that question is more addressed to Eli than to me, as I > have no idea. Don't worry, it was only a rhetoric question. > I'm more than happy to run with different breakpoints > and/or debugging code inserted. The attached is an attempt to catch the condition where the selected window's buffer is dead in a couple of strategic places. Please run with it in an unoptimized Emacs and wait till an assertion triggers. Yet another shot in the dark but I have no better idea. And if you still have the old session in the debugger, please tell us what the value of old_selected_window is. Thanks, martin --------------B6F9B872FF3A8C0F6407F534 Content-Type: text/x-patch; name="selected_window_contents.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="selected_window_contents.diff" diff --git a/src/buffer.c b/src/buffer.c index 8e33162989..9ad1e1d4d8 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -1991,6 +1991,8 @@ DEFUN ("kill-buffer", Fkill_buffer, Skill_buffer, 0= , 1, "bKill buffer: ", =20 run_buffer_list_update_hook (b); =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + return Qt; } =0C @@ -2151,6 +2153,9 @@ set_buffer_internal_1 (register struct buffer *b) =20 BUFFER_CHECK_INDIRECTION (b); =20 + if (!BUFFER_LIVE_P (b)) + error ("Selecting deleted buffer"); + old_buf =3D current_buffer; current_buffer =3D b; last_known_column_point =3D -1; /* Invalidate indentation cache. */= diff --git a/src/window.c b/src/window.c index eb16e2a433..539297c8fd 100644 --- a/src/window.c +++ b/src/window.c @@ -594,6 +594,8 @@ select_window_1 (Lisp_Object window, bool inhibit_poi= nt_swap) =20 selected_window =3D window; =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + /* Go to the point recorded in the window. This is important when the buffer is in more than one window. It also matters when @@ -3411,6 +3413,8 @@ DEFUN ("delete-other-windows-internal", Fdelete_oth= er_windows_internal, replace_buffer_in_windows (Lisp_Object buffer) { call1 (Qreplace_buffer_in_windows, buffer); + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); } =20 /* If BUFFER is shown in a window, safely replace it with some other @@ -3960,6 +3964,8 @@ run_window_change_functions (void) /* Record changes for all frames (if asked for), selected window and frame. */ unbind_to (count, Qnil); + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); } =20 /* Make WINDOW display BUFFER. RUN_HOOKS_P means it's allowed @@ -4054,6 +4060,9 @@ set_window_buffer (Lisp_Object window, Lisp_Object = buffer, if (!samebuf && !MINI_WINDOW_P (w) && !WINDOW_PSEUDO_P (w)) FRAME_WINDOW_CHANGE (XFRAME (w->frame)) =3D true; =20 + if (WINDOWP (selected_window)) + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents= ))); + unbind_to (count, Qnil); } =20 @@ -5174,6 +5183,8 @@ DEFUN ("delete-window-internal", Fdelete_window_int= ernal, Sdelete_window_interna error ("Deletion failed"); } =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + return Qnil; } =0C diff --git a/src/xdisp.c b/src/xdisp.c index cc0a689ba3..ea64e5037a 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -12980,6 +12980,8 @@ restore_selected_window (Lisp_Object window) /* Abort if we cannot find a live frame. */ emacs_abort (); } + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); } =20 /* Restore WINDOW, if live, as its frame's selected window. */ @@ -12997,6 +12999,8 @@ restore_frame_selected_window (Lisp_Object window= ) if (EQ (frame, selected_frame)) selected_window =3D window; } + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); } =20 /* Update the tab-bar item list for frame F. This has to be done @@ -13074,6 +13078,8 @@ update_tab_bar (struct frame *f, bool save_match_= data) XSETFRAME (frame, f); selected_frame =3D frame; selected_window =3D FRAME_SELECTED_WINDOW (f); + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents)= )); #endif =20 /* Build desired tab-bar items from keymaps. */ @@ -14010,6 +14016,8 @@ update_tool_bar (struct frame *f, bool save_match= _data) selected_frame =3D frame; selected_window =3D FRAME_SELECTED_WINDOW (f); =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents)= )); + /* Build desired tool-bar items from keymaps. */ new_tool_bar =3D tool_bar_items (Fcopy_sequence (f->tool_bar_items), @@ -17246,6 +17254,8 @@ run_window_scroll_functions (Lisp_Object window, = struct text_pos startp) set_buffer_internal (XBUFFER (w->contents)); } =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + return startp; } =20 @@ -25450,6 +25460,8 @@ display_mode_lines (struct window *w) =20 unbind_to (count, Qnil); =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + if (n > 0) w->must_be_updated_p =3D true; return n; --------------B6F9B872FF3A8C0F6407F534--