unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: michael_heerdegen@web.de
Cc: 11747@debbugs.gnu.org
Subject: bug#11747: 24.1.50; called-interactively-p vs. advice
Date: Sun, 24 Jun 2012 21:14:55 -0400	[thread overview]
Message-ID: <bi395kp4z4.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87lijj9n8t.fsf@web.de> (Michael Heerdegen's message of "Tue, 19 Jun 2012 20:21:06 +0200")

Michael Heerdegen wrote:

> `called-interactively-p' returns wrong values when called inside
> commands that are adviced.

Old "interactive-p" had the same issue, though maybe that mattered less.
It's to do with the way advice is implemented. It actually goes out of
its way to avoid using call-interactively unless it has to (subrs).
See comments in advice.el header.





  reply	other threads:[~2012-06-25  1:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19 18:21 bug#11747: 24.1.50; called-interactively-p vs. advice Michael Heerdegen
2012-06-25  1:14 ` Glenn Morris [this message]
2012-06-25 17:54   ` Michael Heerdegen
2012-06-25 23:40     ` Glenn Morris
2013-02-08 22:41 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bi395kp4z4.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=11747@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).