From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56682: Fix the long lines font locking related slowdowns Date: Fri, 29 Jul 2022 16:37:14 +0000 Message-ID: References: <174616cd5c33bfc14b1f@heytings.org> <837d44jr4p.fsf@gnu.org> <83bktghrn0.fsf@gnu.org> <8a3eaeef010995a5da8d@heytings.org> <837d40ds09.fsf@gnu.org> <83zggwcby5.fsf@gnu.org> <83o7xccagi.fsf@gnu.org> <831qu7daxb.fsf@gnu.org> <83sfmnb7yg.fsf@gnu.org> <837d3ybh5z.fsf@gnu.org> <136c4fe0fc74196714aa@heytings.org> <83pmhp89ov.fsf@gnu.org> <136c4fe0fc39573addc9@heytings.org> <83k07x8738.fsf@gnu.org> <136c4fe0fcdf00ef9a11@heytings.org> <83h73183r7.fsf@gnu.org> <136c4fe0fc0fceb0d752@heytings.org> <838roc8ka7.fsf@gnu.org> <83tu706obt.fsf@gnu.org> <83h7306ifa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17203"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 56682@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 29 18:38:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHT07-0004EZ-7d for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Jul 2022 18:38:11 +0200 Original-Received: from localhost ([::1]:39140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHT05-0004a3-Ml for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Jul 2022 12:38:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHSzy-0004Zo-8t for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2022 12:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43608) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oHSzy-0003Rr-0I for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2022 12:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oHSzx-0003HF-Nw for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2022 12:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Jul 2022 16:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.165911264012545 (code B ref 56682); Fri, 29 Jul 2022 16:38:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 29 Jul 2022 16:37:20 +0000 Original-Received: from localhost ([127.0.0.1]:33357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oHSzI-0003GH-9W for submit@debbugs.gnu.org; Fri, 29 Jul 2022 12:37:20 -0400 Original-Received: from heytings.org ([95.142.160.155]:57938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oHSzE-0003G6-9j for 56682@debbugs.gnu.org; Fri, 29 Jul 2022 12:37:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1659112635; bh=x1JbpoUJysdnI59M2cE4mW7FsTV0wu4qJ8yZAPjYSu4=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=giSsGB9nwFV4dZ/bk0R0J0vfQlpi3SqXM+s7jVLdOtJT2UXFqUQpyiwzhN9+LzD2z eJ1eNlOvwDC9x6DB9fymMiIznBslBZ+ndSZLHfIZjWX7lcDjWLBFqvaHJSZXi949Ge Qh+q3yu18nVLMeoqdMvQuO5hjfBKx1PARWZw3HM0PG2uww8zsuOXos7n0Hv6r9Q7JT wRl9NmMhrFxctbDWHSgzG3gez4KCfGywafvCn0wK+4/PNtvf/v+KRXFXW8kIsvpMuN xsCpPpU8WhjueY5qMmpKUs9NcCx8R8nA6ECAebSNVOtzuXTljjRUvsiyguBYDncg8V vyZ1UqY5oivwg== In-Reply-To: <83h7306ifa.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238202 Archived-At: >> At least if I do (pos-visible-in-window-p (point-max)), they are not: >> handle_fontified_prop is not even called with it at point-max. Even >> with (pos-visible-in-window-p (1+ (window-end))) >> fontification-functions are not called. > > Try with vertical-motion. Visit long-line.xml, go to position 20000, > and then do "C-u 200 C-n" or "M-: (vertical-motion 200) RET. Sooner or > later you will see that it->current in handle_fontified_prop will be > outside of the narrowing. > Thanks, I was able to reproduce the bug with that recipe. >> Should we perhaps be extra careful and add not apply the narrowing when >> IT_CHARPOS is not between narrowed_begv and narrowed_zv? > > I'd rather narrow around IT_CHARPOS in that case. That would be also > consistent with what the doc string of fontification-functions now says. > > Perhaps we should also change what init_iterator does: if the start > position with which it's called is outside of the restriction, recompute > the restriction using the start point instead of the window's point > position. WDYT? > Doing it in init_iterator is too early alas, with the above recipe at least init_iterator is called with charpos inside the narrowing bounds, after which the iterator moves outside the narrowing bounds. So I fixed the bug in handle_fontified_prop. I don't know yet if it's necessary to add another similar recomputation inside init_iterator.