From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar Date: Fri, 19 Nov 2021 10:26:52 +0100 Message-ID: References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> <83pmqwwrwj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------102B1983BFF77B68711102E7" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11916"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51794@debbugs.gnu.org To: Eli Zaretskii , Mark Kennedy Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 19 10:28:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mo0Br-0002uZ-CG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Nov 2021 10:28:15 +0100 Original-Received: from localhost ([::1]:54064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mo0Bq-0004Wo-87 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Nov 2021 04:28:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo0Be-0004RP-Rv for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 04:28:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mo0Be-0007JY-Il for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 04:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mo0Be-0008Nf-AY for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 04:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Nov 2021 09:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51794 X-GNU-PR-Package: emacs Original-Received: via spool by 51794-submit@debbugs.gnu.org id=B51794.163731402332090 (code B ref 51794); Fri, 19 Nov 2021 09:28:02 +0000 Original-Received: (at 51794) by debbugs.gnu.org; 19 Nov 2021 09:27:03 +0000 Original-Received: from localhost ([127.0.0.1]:38021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo0Ah-0008LW-Be for submit@debbugs.gnu.org; Fri, 19 Nov 2021 04:27:03 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:48097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo0Ae-0008L0-LL for 51794@debbugs.gnu.org; Fri, 19 Nov 2021 04:27:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1637314014; bh=IV0SUYxdJqTxkdT3WT34u8ye6G7w4lK+4cD9tFAOAc4=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=QtMPdeZxU/6NkQ0pDJW1zzY/uybmTf+7M0ZGbqZQab1kQIgkcMurZDyosCbmKKgHz lvOmGMNmD77+mlHO2HMTNwl0S9aTl+sK/svErRycSihFUaJ7b7Z5hnWmFMUOgevR/I XJZraWrU2ixszMqZ0/vlz4GzRvR5y45q8YlwH1n4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([213.142.96.197]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MkHQh-1mPcaF0bs1-00khgK; Fri, 19 Nov 2021 10:26:54 +0100 In-Reply-To: <83pmqwwrwj.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:HFFHmgj7ikvdbUC21ZpoGTy/manipBpju8Ug2zkWwQA0kgCLgEn t/oVm9VseCmf6MuJLVfNqJOFlKYKviPwka+FasEDLor7FIqMVssySu9PsWNETk05MhDcd5u ZlO+swr4HYiGeUJxOZLAsowA1Ytkm7ne2vXQVT9fNGXxGeBvP8hYKgU+Y+5co4AsDFI72LA m3Uoqsjefjb1Sti9QBkng== X-UI-Out-Filterresults: notjunk:1;V03:K0:jN1AGXCQfOM=:PZXUXlOP2d1mEpf+V5dmVe vNvqYN1+BuODnjXog27bwMxhnkXIgPxgoHcBVKaz0LpjUXL7OrHSW3QLj9CV7QJDtPfUbYMdy 6G9SqNgmJwtFHDC4e4HKimeo1z2KpI/2KYFpOxze9nRkavUKqLUQnDdwwXI4+JXpA2KVCEocO MziVmDPkxtFq6rvNwZJfzwqsJtRLWhfQHZJsjHHuQBamGSbuy/NEUNlPfd5y25kRU0k1idppv tPkfyHLvGLrNrOtvnI6O2kForspZx/2tqX93kEPkfdPP2RkWB1j08JMcZoBfJZOKgaZoutWw0 u9uc2mbBczLqzTOnFeQGXnGvWeu2YKzXoE8OoSl5umGO2Ngoj7WtsU5V0HmyyFBxK6zE4BZIr 3HDv67WJRpap9ER56m76D66bjLUOj3yn+lFZXq8oimBzq3Q+cgl8cgqC+8OfqTeAGyjeailRN DnJKOYHU4vY0xnsC7Y3gjzoaM2pMovKQ1fc1IwXsNSui2P3xK7zgYw0Jxo3K1l/GVwQ28rTp5 CNT3LFSttd/f1c/Aibt+22XUaxhz7K+yL90SNPXqYUGn1+za97CZFSV6yGNova/ZswWrghZWc J7R2Kx5nySsZPnYD4rMIF6rmUAtQclzMYbcs/OF4GADGbUjjnHiVy4F4cFw950qKD//ZJtUFG z7Ny3n23X8ztHqSEmHVtEUKlc3xr5JpBjYp9OHj4iH63rYVZFhCToK4B/4jY85x/VFTpT3EF1 3/T2mMp6nsY1lKULocMWvpXrhAQ2dlk8Zfzt18sbWxWUCVXX71K0ZlnjySwNa5m65toK7Hrd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220400 Archived-At: This is a multi-part message in MIME format. --------------102B1983BFF77B68711102E7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit >> bug fix #50993 is the bug. it made make_lispy_position skip setting >> posn to the tab_bar if track_mouse is non-nil. why track_mouse is nil >> for some frames and not for others i didn't look into. >> thoughts/comments? > > Please do look into that last part, because we need to understand the > situations in which this happens well enough to devise a solution. We > don't want to revert that fix because it will re-introduce a larger > problem. Specifically, why does this happen to you only under those > customizations and not in "emacs -Q"? > > Martin, any suggestions? Maybe the attached patch helps. martin --------------102B1983BFF77B68711102E7 Content-Type: text/x-patch; name="track-mouse.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="track-mouse.diff" diff --git a/lisp/mouse-drag.el b/lisp/mouse-drag.el index ecfb359b36..98e18a5c86 100644 =2D-- a/lisp/mouse-drag.el +++ b/lisp/mouse-drag.el @@ -282,6 +282,7 @@ mouse-drag-drag (setq window-last-row (- (window-height) 2) window-last-col (- (window-width) 2)) (track-mouse + (setq track-mouse 'drag-dragging) (while (progn (setq event (read--potential-mouse-event) end (event-end event) diff --git a/lisp/mouse.el b/lisp/mouse.el index 7bac6dd07b..c94862d01b 100644 =2D-- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -1615,7 +1615,7 @@ mouse-drag-track (goto-char (nth 1 range))) (setf (terminal-parameter nil 'mouse-drag-start) start-event) - (setq track-mouse t) + (setq track-mouse 'drag-tracking) (setq auto-hscroll-mode nil) (set-transient-map diff --git a/src/keyboard.c b/src/keyboard.c index a99d14cb4c..abd9635a92 100644 =2D-- a/src/keyboard.c +++ b/src/keyboard.c @@ -5136,7 +5136,7 @@ make_lispy_position (struct frame *f, Lisp_Object x,= Lisp_Object y, This issue should be properly handled by 'mouse-drag-track' and friends, so the below is only a temporary workaround. */ - if (NILP (track_mouse)) + if (NILP (track_mouse) || EQ (track_mouse, Qt)) posn =3D EQ (window_or_frame, f->tab_bar_window) ? Qtab_bar : Qtool_bar; /* Kludge alert: for mouse events on the tab bar and tool bar, keyboard.c wants the frame, not the special-purpose window --------------102B1983BFF77B68711102E7--