From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Date: Sat, 24 Nov 2018 19:14:17 -0800 (PST) Message-ID: References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1543115591 19856 195.159.176.226 (25 Nov 2018 03:13:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Nov 2018 03:13:11 +0000 (UTC) Cc: 15839@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 25 04:13:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQkr2-0004zZ-OE for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Nov 2018 04:13:05 +0100 Original-Received: from localhost ([::1]:58534 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQkt9-0007pT-25 for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Nov 2018 22:15:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQkt0-0007p4-Sw for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 22:15:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQksw-0006At-UX for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 22:15:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41720) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gQksw-00068R-Qi for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 22:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gQksw-0003nE-Bx for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 22:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Nov 2018 03:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15839-submit@debbugs.gnu.org id=B15839.154311567014530 (code B ref 15839); Sun, 25 Nov 2018 03:15:02 +0000 Original-Received: (at 15839) by debbugs.gnu.org; 25 Nov 2018 03:14:30 +0000 Original-Received: from localhost ([127.0.0.1]:45978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQksQ-0003mI-HF for submit@debbugs.gnu.org; Sat, 24 Nov 2018 22:14:30 -0500 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:50644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQksO-0003m5-Ol for 15839@debbugs.gnu.org; Sat, 24 Nov 2018 22:14:29 -0500 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAP3EJnT036195; Sun, 25 Nov 2018 03:14:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=9OktFUrnceql8yPinmHLSAqt98E6bGxnMhFfKsa2RmI=; b=BYB2infRVtYs6hkqcBVroUvMv2Jt33HMNS8YKDYH0dx5oa6Ym3BciaWluqZfx7X9tylw CN3+uqL6EvLqG1FnOegCgAJK+OCr2wGgrEosVZGEvMSa/Kxhv7+HciQTSD+xBhBt4Czy Nfir6xRGo5Hv6W5FWu11w3k2bKhoJBSvTk8wrQpadvnaIv98dNpovRbTh1/FfqAC4ERi pwHjSF13KqFxcutfM/9r6HVsHW31tR2RvpynVfbPk28A03yT80QYoFdoD7opWVSvnGh2 DnC3f6t8uf1oWKTz1QOHGsxRFdrwbkaLjrMzC8K6F/VfjEQI8+26hfAuwsHaCIouq39z SA== Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2nxxkq1hhd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 25 Nov 2018 03:14:21 +0000 Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wAP3EJ8I018167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 25 Nov 2018 03:14:20 GMT Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wAP3EI5n005832; Sun, 25 Nov 2018 03:14:18 GMT In-Reply-To: <8736rqgk6f.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9087 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811250029 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152750 Archived-At: > > 2. What's more, the lazy highlighting of search hits is even more > > limited currently. When you scroll to the current limit, there can be > > lots of search hits that are not highlighted. > > > > One of the reasons for scrolling is to see what search hits lie beyond > > the currently shown text. This is already partly defeated, in that > > even when you scroll some of the hits are not highlighted. This seems > > more like a bug, but if the enhancement of #1 is done then it should > > (it needs to) take care of #2 as well: Whatever text is shown should > > have all of its search hits highlighted with lazy highlighting. >=20 > Drew, do you agree that this your request is implemented now > with lazy-highlight-buffer, so bug#15839 could be closed? Not as far as I understand. That #2 is only one point (one part) of several making up the bug report. If scrolling forward and backward always shows all search hits lazy-highlighted, then that one part of the bug would seem to be fixed. But that fixed behavior is (needs to be) anyway independent of any customization of `lazy-highlight-buffer'. So no, the addition of option `lazy-highlight-buffer' in no way fixes this bug. Perhaps some infrastructure that has been added now provides for a way to fix part of this bug - dunno. By that I mean only that now Isearch has ways of highlighting more than just a windowful of the buffer. Dunno whether that is helpful here. And as I said in the bug report, even for this one part of it (all visible search hits are not necessarily lazy-highlighted), the lazy-highlighting needed for scrolling could be limited to what is actually made visible by scrolling - not the whole buffer. Dunno whether that is a good optimization to make or not. What counts is the user perspective: scrolling should show all hits highlighted, no matter how far you scroll and no matter which directions. And to get that behavior a user should not need to change option `lazy-highlight-buffer'. That option should have no effect on this behavior, and vice versa.