From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#63469: 29.0.90; project.el doesn't add menu-bar entries Date: Tue, 23 May 2023 00:30:00 +0300 Message-ID: References: <83o7mkz2ap.fsf@gnu.org> <83sfbvxkj3.fsf@gnu.org> <3d97111e-794d-eeef-73b0-ee3f6f5f15d5@gutov.dev> <83jzx6w2bg.fsf@gnu.org> <6a3eed52-3248-74f9-bcaf-bf12660ae0ed@gutov.dev> <83h6savsz4.fsf@gnu.org> <83mt21vfgl.fsf@gnu.org> <86mt211vk3.fsf@mail.linkov.net> <0ce4532f-03aa-6afe-bd8f-8ef1df6615de@gutov.dev> <86ilco7qbs.fsf@mail.linkov.net> <83r0rctxbc.fsf@gnu.org> <867ct4b4ds.fsf@mail.linkov.net> <835y8otbub.fsf@gnu.org> <86o7mccl5z.fsf@mail.linkov.net> <83lehgp6s6.fsf@gnu.org> <9b95edb4-ce9e-9dfe-4ad8-24d08422a5ae@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25113"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: Eli Zaretskii , Juri Linkov , 63469@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 22 23:31:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1D7f-0006Mt-Ae for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 May 2023 23:31:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1D7U-0004yS-Hn; Mon, 22 May 2023 17:31:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1D7Q-0004xV-7f for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 17:31:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1D7Q-0008SV-0T for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 17:31:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q1D7O-0001MT-Cx for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 17:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 May 2023 21:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63469 X-GNU-PR-Package: emacs Original-Received: via spool by 63469-submit@debbugs.gnu.org id=B63469.16847910135165 (code B ref 63469); Mon, 22 May 2023 21:31:02 +0000 Original-Received: (at 63469) by debbugs.gnu.org; 22 May 2023 21:30:13 +0000 Original-Received: from localhost ([127.0.0.1]:36975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1D6a-0001LE-NO for submit@debbugs.gnu.org; Mon, 22 May 2023 17:30:13 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:36953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1D6X-0001Js-1b for 63469@debbugs.gnu.org; Mon, 22 May 2023 17:30:10 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DBE645C012C; Mon, 22 May 2023 17:30:03 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 22 May 2023 17:30:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1684791003; x=1684877403; bh=wMGYVpDC93uuhIv2z0Viqt+4kucuyw6QXBq LARBLe7c=; b=PkxiEqLBv2X2zFfYEy6QOs82IfeYDKfnSk+3gPxthjRQud4z8pR DZtXwoZKywvfjOlvO8xawemzZEL8ccX5rAO78ln4SEd7sKDmym08iChgl12/44GK MMPrtBG+4QrTfRvCWxNNzAvY8nYUxwLetpparjRqkv2xSlywdJCCJxa1am2jRAGD MfA4Csbc9kGLnZ6AIPuuKGUma+iMio6MtmJ91umLTMhM9Xf+gTUZXNJPhAuhI7yF yuSNjdATZyXN4RMStm9eUNu4rAYlKqnElyNbYSLpgxXWJWbB4Q1A9eUep/CFEKCS RgUtcyZN5vdC96u8dH3VVAM1u1UTkzjaKmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684791003; x=1684877403; bh=wMGYVpDC93uuhIv2z0Viqt+4kucuyw6QXBq LARBLe7c=; b=EWqicx/KvLCAXu2zg1gVZF/hcTwfxkfUWegcHxvdNzi1SvgY64/ n/Iad1VBYucnoQahzN9oHW4iDLHz+Tonoc3SVr8YBAkEd3ETnxStBxtBvhxUu1aJ jsFBJ2c4jMV9EMIAAhdz4P6S7ArYGSuIYZaXwAu038G2/emrtlkkQ74buHSXwSyX ejEy0McVRMSl0IZNjuT1sD1EIUkq5Lw3J2XEO2QDdC2G6KHhkVdMVOz2XrVSUDGM k0hcXz1itNYBNY/NAQY2MEHqOaVAajjNf7vBACs/pTmiU2l8oeULbVoz5mzuE93x haXlFNlSm3KA5O/SIOdbaaNfTBp4Ne7nPNA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejuddgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeev ledvveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 May 2023 17:30:02 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262193 Archived-At: On 23/05/2023 00:20, Spencer Baugh wrote: >> The VC project backend is not the only backend out there. Others' >> performance characteristics may well be different. >> >> Further, its root-finding logic is different from VC. We also cannot >> simply see which backend the current file is registered at because >> project-vc has different options which affect how the root is >> determined. >> >> Long story short, we won't be able to simply reuse VC's cached info. > > I assume you've already considered this thoroughly, but could we just > get rid of all those differences/merge them into vc? For example, I > wonder if we could teach vc to have an option like > project-vc-merge-submodules... or at least, teach vc to discover the > parent project. That could maybe be useful in vc... I haven't spent much time on that question, to be honest. But offhand I could say that those options won't necessarily make sense for VC. What would it mean for it to "discover parent project"? VC doesn't deal with projects, it deals with repositories. And altering what repository root it finds (or making the logic customizable) can have adverse effects. E.g. we have an option like project-vc-merge-submodules which moves the project root to the top repository. But as far as VC goes, it needs to be able to check in changes inside submodules. One of the steps in vc-git-checkin is to change default-directory to the return value of vc-git-root, to have the command called there. Similarly, I'm not sure what kind of effect would be appropriate for project-vc-extra-root-markers to have on VC functionality. >>> (I personally agree that this should be always on, with perhaps a user >> option to turn it off.) >> >> I'm fairly sure not everybody will like the additional delay when >> visiting files over Tramp. > > We could simply not run it automatically for files on TRAMP. Do we run > the vc find-file hook for files on TRAMP? Maybe we shouldn't... I thought there was some advice for vc-refresh-state somewhere, but I can't find it now. If you have time, you're welcome to look around. Tramp often disables certain costly features (or Emacs packages provide options disable such features, when used remotely). This will need to be taken into account somehow.