From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Harald =?UTF-8?Q?J=C3=B6rg?= Newsgroups: gmane.emacs.bugs Subject: bug#10483: [PATCH] cperl-mode: Avoid endless loop Date: Mon, 31 Aug 2020 20:08:06 +0200 Message-ID: References: <83o8mqwwx2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40682"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 Cc: 10483@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 31 20:09:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCoEw-000ARZ-Cm for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 Aug 2020 20:09:10 +0200 Original-Received: from localhost ([::1]:46862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCoEv-0000JF-6b for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 Aug 2020 14:09:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCoEo-0000J5-Uf for bug-gnu-emacs@gnu.org; Mon, 31 Aug 2020 14:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42096) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCoEo-0003is-LP for bug-gnu-emacs@gnu.org; Mon, 31 Aug 2020 14:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCoEo-0007gp-HA for bug-gnu-emacs@gnu.org; Mon, 31 Aug 2020 14:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Harald =?UTF-8?Q?J=C3=B6rg?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Aug 2020 18:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10483 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 10483-submit@debbugs.gnu.org id=B10483.159889729829508 (code B ref 10483); Mon, 31 Aug 2020 18:09:02 +0000 Original-Received: (at 10483) by debbugs.gnu.org; 31 Aug 2020 18:08:18 +0000 Original-Received: from localhost ([127.0.0.1]:53642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCoE6-0007fs-07 for submit@debbugs.gnu.org; Mon, 31 Aug 2020 14:08:18 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:44731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCoE2-0007fd-W5 for 10483@debbugs.gnu.org; Mon, 31 Aug 2020 14:08:16 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 8F6112400FD for <10483@debbugs.gnu.org>; Mon, 31 Aug 2020 20:08:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1598897288; bh=em5XHz8pgV+J/Q6LRDBe58fUJtHuTkLVp2hee8FoDQc=; h=Subject:To:Cc:From:Autocrypt:Date:From; b=exQOXUpZcpZj+uJACNgIou2ZX6atzk7jDV+mgEp32fXxcCgXzcGVqheg0wiiRMBHp fTOzipJmEbCOc1d7byLtWAoca3ctiKzxUD5dyIbfy4a47tVDuyvuZzy9IbA6q1P06K 6JjA6/cpyVbJssgnLkKXFs+RTykYnxe45g/YyWFwNagIgOGeLheKt8aOlzU3PzVPPO bJ5oXFd2eK+chYNvfKOA61pMJq9gmxaYLyM9S2atLTt4dJx2dfLsDfcwyXKUkRzOih lPP2SmFbtMkPAbkA6AAaSDD5Soi4qtyDNFneHuo2WP8mXb/lpZGOIlLHt37yTJNLTJ tPf+ezK54lUtg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BgJ8l5l6Yz6tm6; Mon, 31 Aug 2020 20:08:07 +0200 (CEST) Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN In-Reply-To: <83o8mqwwx2.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186786 Archived-At: On 8/31/20 7:24 PM, Eli Zaretskii wrote: >> From: Harald Jörg >> Date: Mon, 31 Aug 2020 19:06:08 +0200 >> >> That bug has a few more manifestations. An endless loop >> occurred whenever a statement ended in a closing paren, and >> the statement was not terminated on the same line. > > Thanks, but could we please also have a test for this issue, so that > the bug never happens again? Sure... I can prepare another patch. The test also ought to verify that terminating the while loop didn't damage cperl-mode's ability to indent the compound statements it handles in this section of code. I was hesitating in this particular case because _if_ this issue ever happens again, then the test just hangs forever. Is there a safeguard against this? -- Cheers, haj