From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#51883: 29.0.50; Command to get accidentally deleted frames back Date: Tue, 25 Jan 2022 10:28:29 +0100 Message-ID: References: <87czn1gfb1.fsf@web.de> <838rxo0zk7.fsf@gnu.org> <86lez73auf.fsf@mail.linkov.net> <86y236vlfm.fsf@mail.linkov.net> <86zgnms469.fsf@mail.linkov.net> <8635ld0zq7.fsf@mail.linkov.net> <838rv5j87a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11365"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, gregory@heytings.org, monnier@iro.umontreal.ca, 51883@debbugs.gnu.org To: Eli Zaretskii , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 25 10:29:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCI8k-0002nZ-4N for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jan 2022 10:29:26 +0100 Original-Received: from localhost ([::1]:42952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCI8i-0002jC-Sr for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jan 2022 04:29:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCI8N-0002ij-QF for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 04:29:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nCI8L-0004YW-TH for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 04:29:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nCI8L-0008BH-Hg for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 04:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jan 2022 09:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51883-submit@debbugs.gnu.org id=B51883.164310292431421 (code B ref 51883); Tue, 25 Jan 2022 09:29:01 +0000 Original-Received: (at 51883) by debbugs.gnu.org; 25 Jan 2022 09:28:44 +0000 Original-Received: from localhost ([127.0.0.1]:46884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCI83-0008Aj-NP for submit@debbugs.gnu.org; Tue, 25 Jan 2022 04:28:43 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:46085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCI82-0008AU-1g for 51883@debbugs.gnu.org; Tue, 25 Jan 2022 04:28:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1643102912; bh=/gwx4CjDVJz1PhBguZHvjlbHiWg177q6FNP2HXRit9E=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=YBQiCtwB3JaiLwkS4fmf3/e5szSWHXH4md5zEzJt/YI3mEYKb6oB6aUxKCjlK4eGU qhjYAUlSbZ6du0wkayItWX9QJNz1CZsK0eL1vLAxfKms99ZDkISj2wV/I5xm81+5hp CtPGXeH0fwPfOV/kOft84EOiX41RR91nrdjjgiiA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([212.95.5.20]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mi2Nv-1mh6AY46lt-00e2qQ; Tue, 25 Jan 2022 10:28:32 +0100 In-Reply-To: <838rv5j87a.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:bnE/YWJFPy4+hcelWvktkKtWRAF40Ij2MwnEap9Xv5lQJcvAjxd YvPphgtBE9X0X9a4aDLJ9I7AXfWR4rTc6y+n4tLlSQyXyOe3n69MhH+Z9aDevm8lvlsUgn6 LxsSxkrG6JRtHUoM1pMd9OT2NR8g1IPkvtPYDLFf2r//PLE+HM5mlur7NvDfpgAyukqO5fD oz8VzulYFVbgR3ZQJV/FA== X-UI-Out-Filterresults: notjunk:1;V03:K0:c5L1apLzO0o=:AucSCo6igNiC9qGwvJvTC4 JNCYv2mlSu37zhhAKmdyEG9t3gPk6Y+5wrGb6VkTlSjrb4BWB5OQcXQ1APGm9txmrcJCHMCKa 99nzJCVRVrot8FFmVjNfFdbEWj1fw2zf0xymDKO6hZnR5KbZFqL9YB3DNFXvOUTgNA9uD992n TDvgL70m5YQi1sq7SNi6U98EQN4VYH0ecgtcwgd8stRCchlezq/gTuyexNUAZzRnHlvXkC+W8 mgDVfTBHM9gBeL3eELmVefY6/yOvqWYj9bNnTsvDD/qpi5hK08ajI08G1fBe2tiS9Jj/5JSwY RQR53gDzr4YU8MIBy2r/dgwhQ0ZKcxsB4wOcTfDBsGRC8YSuis52LejDbYZW5XCutJrP9nbzo +YgM6DoxZ1IlwYCPduokEL2MFAa7MUNhAAVe+wf8Pc6tKWklyOUKrCO5dyjX6H74uFFqmqKhF zO6BiJiC+2SfDHJ31btcM7KOGAfr7ttp8UmfkSzP3dt0v8md6mf3TdfiXvt7QK9vr+tWh7+KG yHpWyKF0rriMABi2rb96D29Zat6lS/u+bt6B+WnkQyMxHJirOovpdtLa1LKjpW90bkGZ28Zj5 zl5bVrrfeHfE6f5fmN1rQwxRccc9wGcASYWoAX4m4Y0gqkr3WQ6VAnRWzS80rxxNZZ9geil3L B5AyF6P7ZaPGFs30uup5RHrAUWOK5xa43HOt+iK1fyXPwk26lSMiwFQH76lClZfT5G0M7Dlbl oExLemJ388a/HixTEdjXsgrVwaEqhUXjYj2ynIIaRGAwSLCL09dk6vQimSm2p0c9z7XaB4Y+ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225152 Archived-At: > I don't yet understand the change. I could understand why window-id > should be removed, but why parent-id, for example? > > Martin, any comments on this change? The problematic part _is_ parent-id which makes the clone an "embedded" frame, one for which FRAME_X_EMBEDDED_P (f) holds and one which Emacs doesn't try to make visible in 'x-create-frame' because However, with explicit parent, Emacs cannot control visibility, so don't try. Subsequent attempts to make that frame visible fail here in xterm.c #ifdef USE_GTK gtk_widget_show_all (FRAME_GTK_OUTER_WIDGET (f)); gtk_window_deiconify (GTK_WINDOW (FRAME_GTK_OUTER_WIDGET (f))); #else if (FRAME_X_EMBEDDED_P (f)) xembed_set_info (f, XEMBED_MAPPED); else XMapRaised (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f)); #endif /* not USE_GTK */ which also explains why on GTK the frame does become visible. So it suffices to remove only parent-id from the parameters passed to 'make-frame' (and I won't comment the idea to bind 'default-frame-alist' when making the frame and the whole idea of 'clone-frame' - the value returned by 'frame-parameters' is IMHO strictly not intended for feeding it into 'make-frame' calls "just like that"). martin