From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#53935: 27.2; [PATCH] ecomplete.el: Auto-select when there is only a single option Date: Sat, 12 Feb 2022 23:27:31 +1300 Message-ID: References: <1d908e97443d75dcb94e1e7c9fdcfb79@webmail.orcon.net.nz> <87o83d6hlg.fsf@gnus.org> <1800d942d3cdf963c15cd970ba64bd37@webmail.orcon.net.nz> <87k0e060lk.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8460"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail Cc: 53935@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 12 11:28:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIpdY-00021K-3g for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Feb 2022 11:28:16 +0100 Original-Received: from localhost ([::1]:41008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIpdW-00016E-Ha for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Feb 2022 05:28:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIpdK-00013y-DP for bug-gnu-emacs@gnu.org; Sat, 12 Feb 2022 05:28:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nIpdK-0000OC-3b for bug-gnu-emacs@gnu.org; Sat, 12 Feb 2022 05:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nIpdJ-0008ED-Rm for bug-gnu-emacs@gnu.org; Sat, 12 Feb 2022 05:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Feb 2022 10:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53935-submit@debbugs.gnu.org id=B53935.164466165431574 (code B ref 53935); Sat, 12 Feb 2022 10:28:01 +0000 Original-Received: (at 53935) by debbugs.gnu.org; 12 Feb 2022 10:27:34 +0000 Original-Received: from localhost ([127.0.0.1]:33555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIpcs-0008DC-Dl for submit@debbugs.gnu.org; Sat, 12 Feb 2022 05:27:34 -0500 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:39493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIpcq-0008D2-UG for 53935@debbugs.gnu.org; Sat, 12 Feb 2022 05:27:33 -0500 Original-Received: from [10.253.37.70] (port=56882 helo=webmail.orcon.net.nz) by smtp-3.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1nIpcp-0005lb-3m; Sat, 12 Feb 2022 23:27:31 +1300 Original-Received: from ip-139-180-65-103.kinect.net.nz ([139.180.65.103]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Sat, 12 Feb 2022 23:27:31 +1300 In-Reply-To: <87k0e060lk.fsf@gnus.org> X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226718 Archived-At: On 2022-02-12 19:49, Lars Ingebrigtsen wrote: > Ah, I see. Well, that's a lot better. But... it seems like a lot > of stuff to just not have to hit RET when choosing an email address. I thought that it was a small amount of stuff to prevent a noticeable irritation. I can see that you don't find the current behaviour to be irritating, but "why can't I complete a singlular match with a single command?" was one of my first questions upon trying ecomplete, so I'd be awfully surprised if I was alone in that. > And it makes the action of `M-n' less predicable -- sometimes it'll > choose a name, and sometimes not. I feel this is mitigated by the fact that the user sees in advance what it's going to do (based on whether there's one match, or more than one match, displayed in the echo area at the time). > So I'm still not sure whether this makes sense for Emacs. Having it as a user option is appropriate then, I think. I'm in favour of enabling the patched behaviour by default, but I don't mind if it's opt-in. I probably didn't pick a good name for the option, though. In hindsight something like `ecomplete-display-matches-auto-choose' is probably better. Or `ecomplete-display-matches-choose-dwim', given that it's a DWIM-ish behaviour? -Phil