From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks Date: Thu, 21 Jan 2021 05:08:05 +0200 Message-ID: References: <875z3suun0.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17654"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 13692@debbugs.gnu.org To: Lars Ingebrigtsen , Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 21 04:09:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2QLO-0004SD-7C for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jan 2021 04:09:10 +0100 Original-Received: from localhost ([::1]:35372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2QLN-00032E-8d for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Jan 2021 22:09:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2QLG-00031s-1k for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2021 22:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44986) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2QLF-0005r0-QF for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2021 22:09:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l2QLF-0002DZ-Kw for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2021 22:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jan 2021 03:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13692 X-GNU-PR-Package: emacs Original-Received: via spool by 13692-submit@debbugs.gnu.org id=B13692.16111984968459 (code B ref 13692); Thu, 21 Jan 2021 03:09:01 +0000 Original-Received: (at 13692) by debbugs.gnu.org; 21 Jan 2021 03:08:16 +0000 Original-Received: from localhost ([127.0.0.1]:56532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2QKV-0002CN-Sm for submit@debbugs.gnu.org; Wed, 20 Jan 2021 22:08:16 -0500 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:34808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2QKU-0002C3-1F for 13692@debbugs.gnu.org; Wed, 20 Jan 2021 22:08:14 -0500 Original-Received: by mail-wr1-f41.google.com with SMTP id g10so335682wrx.1 for <13692@debbugs.gnu.org>; Wed, 20 Jan 2021 19:08:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=y4N1eK5MuDaRNqxcVs9X0YzVKE/eo3F0+5T9GmR8G3Y=; b=PRfc1eK46y9063834JEprTbsh0wMQthZLe/TW4Ga+DU2LaVIaf+tO0V+/1Gcy99U+G 2449NqncsPEr7+pHB7zHJXtuZxFB9oNrjnAcK86s778+44TObEg2wTUG7kAXiwGg9rgP I+zx0bSH3cDnNR99zAnkbxiV4AEpyonOyWBl3bsce5sfoMbyg6HDvDNL9U7uf43e/JIY 7sFNfs4uv3bHq5Jb64DHXzAUhK77j62D+hHHT6AqgogJ0Gk4ZjermtkXhx7DumSbyLWH jyjQFJlI3vNkJXJ8/l+v1LCJptudpKmfBtPtqDR048V2SjnOxPyj6EVIZQk/3Six/uu2 lUCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y4N1eK5MuDaRNqxcVs9X0YzVKE/eo3F0+5T9GmR8G3Y=; b=fb5XBnCJor+2DiDLnrhcyLjbVu6nM5T2bMXHlk9yevcT3dQThR+k+Cp8aUr/mLxdzT lFDLRh8EyWI7R1zVoUie8XQaWwJsiC1XyhSGl4ND1yMlL149PCN3EnZ4EFAMg/JzhVPT AkblBF86FIihQRQH98LJYJ0yURfveVCk/WAzaSxoG6hHV+YgDBMxZf2Wim4RuiuyqIR2 W8NsH3M9S34O8eUBb7+HAZmoxU6QB7C3XVtN8IgSLJr/Foi14ftFCEw4IGayeqjxsWMp x+Hdpw/fxqTaEWzNnJjykB0N1L7K0fDaTdKFe64mZ432hsqyQbfmn/gRGBgUPZ9JJYhK YMXg== X-Gm-Message-State: AOAM530prvqrmTLUidjZfknOMk8/C7S6m1FW43y1QgZxxmmDV2O3Od/y wElvlA7jIxshC6kL2HZyaQHtknJ2L2k= X-Google-Smtp-Source: ABdhPJxkJ49UP0uWeWOwH2+AQu3uz0jQul4kb2l5aLFB2Wp6AC6Mhwe+xtxkarcuCY7+MJnxz9BqWQ== X-Received: by 2002:adf:eb4e:: with SMTP id u14mr12080200wrn.99.1611198488037; Wed, 20 Jan 2021 19:08:08 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j2sm6463799wrh.78.2021.01.20.19.08.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jan 2021 19:08:07 -0800 (PST) In-Reply-To: <875z3suun0.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198307 Archived-At: On 20.01.2021 05:58, Lars Ingebrigtsen wrote: > So the suggestion is to remove the `[mouse-2]' binding in > `vc-dir-mode'. I'm not sure, actually. Perhaps the complaint is about the mouse-1 effect on status buttons. But the rest of my email is on the assumption that we're talking about the mouse-2 binding. > I've never used the functionality myself, but I can see > that somebody might find this useful, but if we're going to have it, > perhaps the clickable area should be extended to the mark character, > too? I've never noticed this functionality in almost a decade of using Emacs. And working on VC for a number of years. > (I think removing the binding after more than a decade in existence > would be confusing.) I don't have a strong opinion about this feature, but it seems like it was designed almost with the main goal of being non-discoverable. As such, I don't think it has many users. It only works when you click on an empty space; if you click on a file or directory name (which are highlighted as buttons and thus invite you to click on them), using mouse-1 or mouse-2, you get to visit the file instead. Only the "status" buttons work for that. If the binding still causes problems (Glenn can tell us), perhaps we'd better remove it. We can still keep the toggle effect on the status buttons, so not much in the way of functionality would be missed.