From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de
Subject: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails
Date: Sat, 8 Feb 2020 04:20:26 +0300 [thread overview]
Message-ID: <bc84b777-b3fb-34b9-5d26-feea335535bc@yandex.ru> (raw)
In-Reply-To: <83v9oiebu3.fsf@gnu.org>
On 07.02.2020 17:00, Eli Zaretskii wrote:
>> Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de
>> From: Dmitry Gutov <dgutov@yandex.ru>
>> Date: Fri, 7 Feb 2020 14:03:21 +0300
>>
>> On 07.02.2020 12:53, Eli Zaretskii wrote:
>>> I'll have to ask you to walk me through the change and explain how it
>>> solves the original issue.
>>
>> There are two changes:
>>
>> 1. Having the returned file names relative to the working dir instead of
>> the repository root. For that, we change 'hg status' to 'hg status re:'.
>
> Why do we want the file names to be relative? If default-directory of
> the buffer is set correctly, that shouldn't be necessary, and if the
> file names are absolute, then the default-directory doesn't even
> matter much.
They are already relative, but against the repository root.
And people want to open vc-dir buffers in any directory, not just in
repository roots.
We could force the file names to be absolute, and then pipe them through
file-relative-name, but that's just extra work.
>> 2. Only including the files inside the working dir in the output. That
>> happens by adding '-I .' to the arguments. Otherwise, Mercurial adds, in
>> the presented scenario, an entry like '../sub2/x', which is extraneous.
>
> This change should be in NEWS, IMO.
It's a bugfix for an older, unintended change. It's not a new behavior.
>>> the Mercurial documentation I've read seems
>>> to contradict what you are doing (e.g., it says "re:" should be
>>> immediately followed by a regexp).
>>
>> You can search the manual for "hg status re:".
>
> Which only finds a single example, where this notation is not
> explained at all (and which I already saw).
Not my fault.
>> I agree it's a bit unclear (it also mentions "hg help patterns" for some
>> reason), but here's an SO answer that got me this far:
>> https://stackoverflow.com/a/46743585/615245
>
> Isn't it disturbing that we are using a feature that doesn't seem to
> be documented?
It's been there for enough years, and it's the best choice I've found so
far.
> But to get to the issue at hand: you are saying that "C-x v d" in a
> subdirectory of the root of a Mercurial repository became broken in
> Emacs 25.1?
>
> Also, is DIR guaranteed to be the directory where FILES live?
Yes, see the description of dir-status-files in the top commentary in vc.el.
next prev parent reply other threads:[~2020-02-08 1:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 0:13 bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails Wolfgang Scherer
2020-02-01 7:20 ` Dmitry Gutov
2020-02-02 22:35 ` Wolfgang Scherer
2020-02-03 13:11 ` Dmitry Gutov
2020-02-04 16:04 ` Wolfgang Scherer
2020-02-05 15:56 ` Dmitry Gutov
2020-02-06 13:25 ` Wolfgang Scherer
2020-02-06 13:38 ` Dmitry Gutov
2020-02-07 9:53 ` Eli Zaretskii
2020-02-07 11:03 ` Dmitry Gutov
2020-02-07 14:00 ` Eli Zaretskii
2020-02-08 1:20 ` Dmitry Gutov [this message]
2020-02-08 8:04 ` Eli Zaretskii
2020-02-08 9:36 ` Dmitry Gutov
2020-02-08 10:11 ` Eli Zaretskii
2020-02-11 22:36 ` Dmitry Gutov
2020-02-01 7:20 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc84b777-b3fb-34b9-5d26-feea335535bc@yandex.ru \
--to=dgutov@yandex.ru \
--cc=39380@debbugs.gnu.org \
--cc=Wolfgang.Scherer@gmx.de \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).