From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#50499: 28.0.50; project.el: Root of current project Date: Fri, 10 Sep 2021 15:16:56 +0300 Message-ID: References: <87v939ypa1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4627"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 To: Augusto Stoffel , 50499@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 10 14:18:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOfTw-0000wZ-VO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Sep 2021 14:18:12 +0200 Original-Received: from localhost ([::1]:36388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOfTu-0004Rj-WE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Sep 2021 08:18:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOfTm-0004QY-CO for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 08:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mOfTm-0004eR-4d for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 08:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mOfTl-0005AU-SU for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 08:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Sep 2021 12:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50499 X-GNU-PR-Package: emacs Original-Received: via spool by 50499-submit@debbugs.gnu.org id=B50499.163127622619793 (code B ref 50499); Fri, 10 Sep 2021 12:18:01 +0000 Original-Received: (at 50499) by debbugs.gnu.org; 10 Sep 2021 12:17:06 +0000 Original-Received: from localhost ([127.0.0.1]:37161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOfSr-00059B-Mr for submit@debbugs.gnu.org; Fri, 10 Sep 2021 08:17:05 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:42694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOfSq-00058c-DL for 50499@debbugs.gnu.org; Fri, 10 Sep 2021 08:17:04 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id q11so2329122wrr.9 for <50499@debbugs.gnu.org>; Fri, 10 Sep 2021 05:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TwBbDLhE9WCxHOpuZA0B01gf4gflwVCNYbMrwqjhbBo=; b=IqSxNUPfsqvcozeFPmrQK0rWQ22NXVyvwkOhKCuT+n1aYWq44g0Fpn/0hBlaWXhkMe OD6pXgzk39QtFPPNl5mwfnNOkmnpV7YTJic2kErZ4mUsSgbzyFEQ2Of6UzvSAuba2GxT 3N/dhSd4hgMH9BFVM/tIF0V82d/iMeqHsr6MNEMaHbsS0F6+Xu5dZMVwA7LDK++djZak +cENHclpzii3XrqBID1b2UbMUsO72vU5avGFwdhlWgKFOn2dCcR/730I2zJ+EIOWfzeL jE+MB5BjmEnYaJXxMAUkl6u0I2GckuBeS7nVtS/xATcCUeMPDFoH46cMojMkaggwy0Vh FNwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TwBbDLhE9WCxHOpuZA0B01gf4gflwVCNYbMrwqjhbBo=; b=myOdRKYrWB4tfxc6pn+gD6mzqohtbyNG690vRR/id4KXDTLfIlfc0bLDN8/MfQsRMY 7ddYM2cDetq8Vzifwn1BsHFaTIy5do8OnUDDskZ+Zmo93Z7oxSiD4MiKL3+eQZnkctsl KkJQdGYHrjgcGnGI/GS+oRjLkJZAU2mg1BDx+9SfK96q9lPFeEZspiNRV/KTMQKbGfBm 5SAF7lZ8IHXChcGOG6gfkWK9n5tFBLqB6sabEWPrK2ovazlwqZh06z6hrG2/nsO8tQZ4 AY613kTkpSyM85tu0rV6/kj89+75j6JGHDHj1/MqZenDeh58l0WsJGbsxUtftKjRrY6/ KFLQ== X-Gm-Message-State: AOAM532XA6mRWIC8nuVYWOVQ38lgYAeXHlnXO77ZWnA2MAf2tMnpWKPL WCfEGGTPF+Yfpnn/MIxxWDaUy2MS8Ck= X-Google-Smtp-Source: ABdhPJwe/wQuvWL8UfBD7khTjFvnW6VyRqISEPOZCL+NxeQGoXEUiTk3iKo6nC7SqRUjUZSBZ9yghw== X-Received: by 2002:a05:6000:1287:: with SMTP id f7mr9637414wrx.221.1631276218567; Fri, 10 Sep 2021 05:16:58 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l10sm5027493wrg.50.2021.09.10.05.16.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Sep 2021 05:16:58 -0700 (PDT) In-Reply-To: <87v939ypa1.fsf@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213997 Archived-At: On 10.09.2021 08:26, Augusto Stoffel wrote: > I guess most uses of `project-root' will be of the form > > (when-let ((p (project-current))) > (project-root p)) > > Or at least this is true in the case of an user who is quickly defining > a shortcut command in their config. > > Wouldn't it make sense to make the PROJECT argument of `project-root' > optional, giving the above result when omitted? Given the way it this works, it would need to be a helper function. IIUC cl-defmethod does not support default values for arguments, and if it did, we'd have to have an implementation of project-root, etc, for nil argument. Which is a bad idea because someone else might not want to simply do nothing when there is no project found, and our type system would then fail to help them notice that. I don't mind adding said helper (naming suggestions welcome), but the way things work now seems fine to me already. Either you have: (project-root (project-current t)) where there is no risk of returning nil, and thus no need for when-let, or you call (project-current) first, check it for nil, and then _probably_ use some other fallbacks. If you don't have fallbacks, then the other approach seems better, no?