From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#21559: 25.0.50; auto-revert-mode breaks git rebase Date: Wed, 21 Feb 2018 00:28:33 +0200 Message-ID: References: <5d7808ef-d61f-534d-53b3-bc1227b4c3b1@yandex.ru> <87fu5w2jnh.fsf@gmx.de> <40817863-9c34-9745-6fff-4357d623de20@yandex.ru> <87po4z512z.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1519165634 29984 195.159.176.226 (20 Feb 2018 22:27:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Feb 2018 22:27:14 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 Cc: 21559@debbugs.gnu.org, Alexei Khlebnikov To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 20 23:27:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoGNR-0007E2-33 for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Feb 2018 23:27:09 +0100 Original-Received: from localhost ([::1]:58082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoGPT-0006gH-BU for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Feb 2018 17:29:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoGPJ-0006eq-U1 for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2018 17:29:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoGPG-0007a4-RM for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2018 17:29:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45463) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eoGPG-0007Zu-KM for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2018 17:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eoGPG-0006J5-A3 for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2018 17:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Feb 2018 22:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21559-submit@debbugs.gnu.org id=B21559.151916572624219 (code B ref 21559); Tue, 20 Feb 2018 22:29:02 +0000 Original-Received: (at 21559) by debbugs.gnu.org; 20 Feb 2018 22:28:46 +0000 Original-Received: from localhost ([127.0.0.1]:53360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoGOz-0006IZ-OP for submit@debbugs.gnu.org; Tue, 20 Feb 2018 17:28:45 -0500 Original-Received: from mail-wr0-f169.google.com ([209.85.128.169]:34864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoGOy-0006IK-C8 for 21559@debbugs.gnu.org; Tue, 20 Feb 2018 17:28:44 -0500 Original-Received: by mail-wr0-f169.google.com with SMTP id l43so18803708wrc.2 for <21559@debbugs.gnu.org>; Tue, 20 Feb 2018 14:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DeJ8amUwROJ2jehAmIyS7r7kcrRbGUpu7F2GCs5BmXw=; b=btXqCIenFO+RnK/WLe8dVD1FmvCiK+bCGJfIr3bRdj98WSsxI+oaGOBGBkd+tHJ+Gh HHhyhB8zklwMmuE59vWEUbyzzh/U+9HkkCS4EOPNGKckolibaDYkwZdpvjXes6/ojfkr /Vb+MJYRiYvc4rX2yPlZHkaYjxOe6egNm8zeDXr3Z75Qm7LUi6TT/RkHgCYs/SVqWqto iPzF1BqWD8ykhQ/hVYihry23Fn0IGzhahV0mwqAPFiFkkUURHuyp4rtzlHNP8UKe4N/E Ebv9g7C3gKUN2pGd90BoAd4dA04u0muoCr5TRVb9p7Kld8lMwqN1W9bsuQaj0GZ0GrbX h66Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DeJ8amUwROJ2jehAmIyS7r7kcrRbGUpu7F2GCs5BmXw=; b=En9jgs5I5muKyBFJF3vwzuZA58BNhWWvzKJwa3WS/DgIrcrW6GbzZmory60orQ56in hGFHbBlRNw5rumY85s+1s5pwS/O/Y9urlp+fH/uPh4iqHiuXvF8lYw4D1ko/hJa6vLz4 XKfsBgGh416xOx+WQcT/vNcpQ2n21aGARDdCflteieGYvZW7OI2oEFm6xgFuDvSytnz3 xqKJHK40Hly5rQuDuAo4FW+03ZIzrwv9dVj8W6uCD2LVeeG3TH7GwxdryRtfiHUj8yCT hgimMlLzqrV/AI2m+ySlyng9qNn0takoDkTsVa3akZBTfYvkUpqh/XU/2si1B9dgHdBF TupQ== X-Gm-Message-State: APf1xPCmVJNETd2cvYvhA9rkR4qT4WiCLIWKmZv8xZ0wQUmGxiBr+0Uv PTdugJVTaGmJ9tXhRceZUnQ= X-Google-Smtp-Source: AH8x2264B1JWGLaIcMiLysWWU5+y/FQcLcgGdVePIroaZ/BSB6tvTdKoXSV7yotiV/nAEmr6gnlt3A== X-Received: by 10.223.196.250 with SMTP id o55mr1036678wrf.200.1519165718456; Tue, 20 Feb 2018 14:28:38 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id v191sm20585378wmf.25.2018.02.20.14.28.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Feb 2018 14:28:35 -0800 (PST) In-Reply-To: <87po4z512z.fsf@gmx.de> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143520 Archived-At: On 2/20/18 1:53 PM, Michael Albinus wrote: > A dependency nightmare counts much more, IMHO. A nightmare isn't going to arrive overnight. >> And using a variable would make more sense if we determine that other >> facilities, not just autorevert, make VC calls that we want to >> consider "background". > > autorevert wouldn't care who uses this variable. In a broader sense, it > could let-bind it for the whole auto-revert-handler body. I meant that if there's going to be more places that are going to *bind* this variable. In that case, moving the relevant code into vc/* would be unavoidable. >> We could do that in vc-git-command, I suppose... > > Perhaps. autorevert shouldn't know anything about vc-git, it should just > let-bind the variable, and let other packages decide whether they use > it. All right, so you just want to move the responsibility. > FWIW, I'm also not so enthusiastic, that aut-revert-handler calls > vc-refresh-state directly. This would be better organized by a hook. On the other hand, since it already has this direct call, an extra let binding isn't going to change much. Anyway, it's your choice here. Do you want to show an alternative patch?