From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#65459: completing-read INITIAL-VALUE unaware of COLLECTION and REQUIRE-MATCH Date: Thu, 24 Aug 2023 12:30:51 +0000 Message-ID: References: <83jztmro8z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31285"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Heime , Eli Zaretskii , 65459@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 24 14:31:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZ9UX-0007tr-CZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Aug 2023 14:31:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZ9UM-0001sW-U3; Thu, 24 Aug 2023 08:31:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ9UK-0001lH-K0 for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 08:31:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZ9UI-00018Q-N4 for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 08:31:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZ9UM-0004Fc-E5 for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 08:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 12:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65459 X-GNU-PR-Package: emacs Original-Received: via spool by 65459-submit@debbugs.gnu.org id=B65459.169288025816329 (code B ref 65459); Thu, 24 Aug 2023 12:31:02 +0000 Original-Received: (at 65459) by debbugs.gnu.org; 24 Aug 2023 12:30:58 +0000 Original-Received: from localhost ([127.0.0.1]:36320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ9UI-0004FJ-22 for submit@debbugs.gnu.org; Thu, 24 Aug 2023 08:30:58 -0400 Original-Received: from heytings.org ([95.142.160.155]:51958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ9UG-0004FA-Pd for 65459@debbugs.gnu.org; Thu, 24 Aug 2023 08:30:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1692880251; bh=/rizmZeixiBsei1i7uDXdlsYv9kCXOHHFJkd+wHQnwo=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=iMQiLHlF9qMoAwdANf+wBWZt7cMymDsz+xppxvhZnzRHFkEgiUKVFvRk8Ur+JJxcU kdexrMizgo7ipC1ry0cf33BNWIHvajp8xz9zgpaQIGN2jueti2jOgylOXhc8OGv2yB OPbaq/DscnYWH9pJuOsfwu5FLZjYJftVSMNzg5aB9631+HrVgRngkLJtX9oATPSvYm lZjR7qpEfkvR3nygqWcO3NKF4mz1fjnTGR7wKdIOun0FKrlK3BNGvCZAezilE5lNnD r5hLX4o2MkZDH+GZE6FcGbB+H8b0POsBJFWZoGlELg2zQkz2rpun3sxSkbDCWHk3mh jKYgGPJAI6sMg== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268330 Archived-At: >> (defun my-completing-read (prompt collection start) >> (minibuffer-with-setup-hook >> (:append >> (lambda () >> (setq-local actual-minibuffer-default-add-function >> minibuffer-default-add-function) >> (setq-local minibuffer-default-add-function >> '(lambda () (setq minibuffer-default-add-done nil) >> (funcall actual-minibuffer-default-add-function))) > > Why use ' on `lambda`? > I think my finger slipped. > > BTW, rather than the above two `setq-local`s, I think you can write: > > (add-function :before (local 'minibuffer-default-add-function) > (lambda () (setq minibuffer-default-add-done nil))) > Right. I was writing that function as it if were for minibuffer.el, and was therefore avoiding advices. But now I see that there are a couple of add-function in core anyway (it's not clear to me where the dividing line is). So here's the final version: (defun my-completing-read (prompt collection start) (minibuffer-with-setup-hook (:append (lambda () (add-function :before (local 'minibuffer-default-add-function) (lambda () (setq minibuffer-default-add-done nil))) (next-history-element start) (move-end-of-line nil))) (completing-read (format-prompt prompt nil) collection nil t))) (my-completing-read "Grapheme" '("alpha" "beta" "gamma" "delta" "epsilon" "zeta" "eta") 1) Heime, can you try that and tell us if it solves your problem?