From: Gregory Heytings <gregory@heytings.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>,
45474@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#45474: Icomplete exhibiting in recursive minibuffer when it shouldn’t
Date: Mon, 19 Apr 2021 12:14:18 +0000 [thread overview]
Message-ID: <bb7c6f5fc9d3118de394@heytings.org> (raw)
In-Reply-To: <jwvtuo3xejk.fsf-monnier+emacs@gnu.org>
>> It would be possible to use whitelisting instead by renaming the
>> current read-from-minibuffer to internal-read-from-minibuffer, which
>> would be wrapped in a macro read-from-minibuffer.
>
> Indeed. I think we need more data in order to figure out which of the
> two options breaks less/more code out there.
>
Here is some (hopefully useful) data:
There are 213 calls to read-from-minibuffer in Emacs core. AFAICS, the
only call that uses minibuffer-completion-table is the one inside
completing-read-default. There's another one inside ido-read-internal,
but it doesn't seem to use minibuffer-completion-table, AFAIU it replaces
completing-read with its own processing in ido-exhibit.
There are 76 calls to read-from-minibuffer on ELPA. AFAICS, the only call
that uses minibuffer-completion-table is the one iside ivy-read.
There are 903 calls to read-from-minibuffer on MELPA. AFAICS, only a
handful of them (yatex, gams-mode, python-django, magit) use
minibuffer-completion-table. The case of Magit is interesting: it solves
the current problem by defining two functions,
magit-completing-read-multiple that let-binds minibuffer-completion-table
to the appropriate value, and magit-read-string that let-binds
minibuffer-completion-table to nil.
>
> I was working under the assumption that the only calls to
> `read-from-minibuffer` which need the minibuffer to have a
> `minibuffer-completion-table` are those coming from
> `completing-read-default` (in which case the whitelisting is the better
> approach since it requires a change only in `completing-read-default`),
> but the fact that there's a `completing-read-function` is a strong hint
> that this assumption is probably wrong.
>
I believe your assumption is mostly correct. There are apparently only
very few occurrences of read-from-minibuffer that use
minibuffer-completion-table, and my understanding is that those who set
completing-read-function to another value do not use
minibuffer-completion-table anymore.
>> The change would be transparent, except for those places (e.g.
>> completing-read-default) where what we actually want is to use
>> internal-read-from-minibuffer. But this change would be slightly more
>> invasive than what follows.
>
> Actually, probably not very much, and it would be a lot cleaner.
>
I agree.
>>> Just like your approach, I think this is only a temporary fix until we
>>> can solve the problem for real by making `minibuffer-completion-table`
>>> buffer-local
>>
>> I'm not sure I fully understand why this is necessary, but is
>> "Fmake_variable_buffer_local (Qminibuffer_completion_table);" just
>> after "if ... specbind (Qminibuffer_completion_table, Qnil);" not
>> enough for this?
>
> No, I meant that instead of using let-binding to set the var, we'd use
> `setq-local`. This requires the code to run from within the minibuffer,
> contrary to the current situation where the let-binding takes place
> outside of the minibuffer.
>
Yes, I understood this, but the effect of let-binding the var and make it
buffer-local after the minibuffer has been created but before the
minibuffer-setup-hook is executed is the same. Or am I missing something?
If not, this would solve the problem without breaking anything (as the
global value of minibuffer-completion-table would not change).
next prev parent reply other threads:[~2021-04-19 12:14 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 17:44 bug#45474: Icomplete exhibiting in recursive minibuffer when it shouldn’t Dario Gjorgjevski
2021-04-15 17:40 ` Gregory Heytings
2021-04-15 21:11 ` Juri Linkov
2021-04-15 22:34 ` Gregory Heytings
2021-04-16 0:03 ` Gregory Heytings
2021-04-16 16:34 ` Juri Linkov
2021-04-16 16:55 ` Gregory Heytings
2021-04-17 20:49 ` Juri Linkov
2021-04-17 21:35 ` Gregory Heytings
2021-04-17 21:58 ` Stefan Monnier
2021-04-17 22:16 ` Gregory Heytings
2021-04-18 14:44 ` Stefan Monnier
2021-04-18 22:23 ` Gregory Heytings
2021-04-19 1:26 ` Stefan Monnier
2021-04-19 12:14 ` Gregory Heytings [this message]
2021-04-19 15:57 ` Stefan Monnier
2021-04-19 20:20 ` Gregory Heytings
2021-04-17 23:21 ` bug#45474: [External] : " Drew Adams
2021-04-18 3:59 ` Stefan Monnier
2021-04-18 4:04 ` Drew Adams
2021-04-18 5:08 ` Stefan Monnier
2021-04-18 15:42 ` Drew Adams
2021-04-18 18:35 ` Stefan Monnier
2021-04-18 20:11 ` Drew Adams
2021-04-18 20:53 ` Stefan Monnier
2021-04-18 23:46 ` Drew Adams
2021-04-22 15:03 ` Stefan Monnier
2021-04-19 18:16 ` Juri Linkov
2021-04-19 21:42 ` Stefan Monnier
2021-04-20 19:00 ` Gregory Heytings
2021-04-22 13:56 ` Stefan Monnier
2021-04-22 14:08 ` Gregory Heytings
2021-04-20 19:01 ` Juri Linkov
2021-04-22 13:54 ` Stefan Monnier
2021-04-22 14:13 ` Stefan Monnier
2021-04-22 14:18 ` Gregory Heytings
2021-04-22 15:18 ` Gregory Heytings
2021-04-22 18:36 ` Stefan Monnier
2021-04-22 19:04 ` Gregory Heytings
2021-04-22 19:59 ` Gregory Heytings
2021-04-22 20:57 ` Gregory Heytings
2021-04-22 23:24 ` Stefan Monnier
2021-04-23 6:06 ` Eli Zaretskii
2021-04-23 13:12 ` Stefan Monnier
2021-04-23 13:19 ` Eli Zaretskii
2021-04-23 15:18 ` Stefan Monnier
2021-04-23 17:37 ` Eli Zaretskii
2021-04-23 6:59 ` Gregory Heytings
2021-04-23 13:21 ` Stefan Monnier
2021-04-23 13:45 ` Gregory Heytings
2021-04-23 15:35 ` Stefan Monnier
2021-04-23 15:58 ` Gregory Heytings
2021-04-23 16:36 ` Juri Linkov
2021-04-23 16:55 ` Stefan Monnier
2021-04-23 18:13 ` Gregory Heytings
2021-04-23 20:24 ` Stefan Monnier
2021-04-23 21:36 ` Gregory Heytings
2021-04-23 21:54 ` Stefan Monnier
2021-04-24 8:44 ` Gregory Heytings
2021-05-01 19:34 ` Stefan Monnier
2021-05-03 8:40 ` Gregory Heytings
2022-06-07 12:04 ` Lars Ingebrigtsen
2021-04-22 21:57 ` Juri Linkov
2021-04-23 15:53 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb7c6f5fc9d3118de394@heytings.org \
--to=gregory@heytings.org \
--cc=45474@debbugs.gnu.org \
--cc=dario.gjorgjevski@gmail.com \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).