From: Yuan Fu <casouri@gmail.com>
To: Dmitry Gutov <dmitry@gutov.dev>, JD Smith <jdtsmith@gmail.com>,
Eli Zaretskii <eliz@gnu.org>
Cc: 67262@debbugs.gnu.org
Subject: bug#67262: python-ts-mode cannot identify triple-quoted-strings
Date: Tue, 12 Dec 2023 00:32:09 -0800 [thread overview]
Message-ID: <bb5f649d-4c7a-4fbd-a593-1ae9f872756b@gmail.com> (raw)
In-Reply-To: <a6119652-a44c-f7d4-2e2b-cd56a53d0b51@gutov.dev>
On 11/26/23 4:05 PM, Dmitry Gutov wrote:
> On 27/11/2023 01:43, Yuan Fu wrote:
>>
>> On 11/26/23 6:58 AM, Dmitry Gutov wrote:
>>> On 26/11/2023 04:04, Dmitry Gutov wrote:
>>>> As for what to do about this one -- probably something involving
>>>> syntax-propertize-extend-region-functions, adding an entry which
>>>> would initialize the parser, but not call syntax-ppss-flush-cache
>>>> directly (or at least not just that). It would signal the earlier
>>>> position to extend to through some dynamic variable. This is
>>>> getting tricky enough to move from the individual major modes into
>>>> treesit.el proper, I think.
>>>
>>> Alternatively, we'd trigger updates eagerly from within
>>> treesit_record_change -- that would make it slower, invalidating the
>>> comment above it. Not sure by how much, though.
>>
>> It seems to me that what we need is to force a re-parse at the
>> beginning of syntax-propertize or in syntax-ppss-flush-cache; the
>> re-parse would cause the notifier to run, which runs
>> python--treesit-parser-after-change.
>
> syntax-ppss-flush-cache is called by edits (and by the re-parse). It
> seems like it will be odd to have execution the other way around
> and/or add some hook into it which would call the re-parse and extend
> the region to be invalidated.
>
> syntax-propertize could have another hook added, yes. Or an advice.
>
> But it seems better to reuse some of the existing hooks, such as
> syntax-propertize-extend-region-functions. It treesit.c provided a way
> to fetch the newly-invalidated region, the treesit-major-mode-setup
> could add a new function to syntax-propertize-extend-region-functions
> which would invoke that feature. But even now it can instantiate the
> parse, which would call treesit-force-reparse internally, and then
> collect the info from the callbacks.
syntax-propertize-extend-region-functions looks perfect. We just need to
force a reparse in it and the notifier will do the rest.
>
> And yet another way - is to extend the region to be propertized from
> inside the major mode's syntax-propertize-function, invalidating some
> earlier entries too. The main problem with that, I think, is that
> every ts mode will have to repeat that trick. And that authors would
> have to know to do that. How to make that easier and more obvious, is
> a question.
>
> Finally, if I'm right that bug#66732 has a similar cause, then a
> shared solution that can be reused by syntax and font-lock (or
> preferably just fix both in the same place) would be ideal.
>
>> I'm not quite sure about how do we cause this re-parse. The
>> straightforward approach would be calling treesit-force-reparse[1] in
>> syntax-propertize/syntax-ppss-flush-cache. But ideally I'd like to
>> keep tree-sitter transparent for syntax.el. Maybe we can add a hook
>> in syntax-propertize/syntax-ppss-flush-cache.
>>
>> [1] This function doesn't exist yet, but it's easy to define in lisp.
>
> treesit-parser-root-node calls it anyway and does little else, so we
> could get by with just using it.
>
Yep.
Yuan
next prev parent reply other threads:[~2023-12-12 8:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 15:52 bug#67262: python-ts-mode cannot identify triple-quoted-strings JD Smith
2023-11-18 16:29 ` Eli Zaretskii
2023-11-18 17:18 ` JD Smith
2023-11-18 22:52 ` Dmitry Gutov
2023-11-25 10:01 ` Eli Zaretskii
2023-11-25 14:42 ` JD Smith
2023-11-26 2:04 ` Dmitry Gutov
2023-11-26 14:58 ` Dmitry Gutov
2023-11-26 23:43 ` Yuan Fu
2023-11-27 0:05 ` Dmitry Gutov
2023-12-12 8:32 ` Yuan Fu [this message]
2023-12-12 21:55 ` Dmitry Gutov
2023-12-16 12:47 ` Eli Zaretskii
2023-12-16 13:37 ` Dmitry Gutov
2023-12-16 13:59 ` Eli Zaretskii
2023-12-16 15:11 ` JD Smith
2023-12-16 15:21 ` Dmitry Gutov
2023-12-16 15:57 ` Eli Zaretskii
2023-12-16 23:36 ` Yuan Fu
2023-12-17 13:46 ` Dmitry Gutov
2023-12-23 9:52 ` Eli Zaretskii
2023-12-23 18:03 ` Yuan Fu
2023-12-23 21:01 ` Dmitry Gutov
2023-12-23 23:51 ` Yuan Fu
2023-12-24 0:45 ` Dmitry Gutov
2023-12-24 3:10 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb5f649d-4c7a-4fbd-a593-1ae9f872756b@gmail.com \
--to=casouri@gmail.com \
--cc=67262@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=jdtsmith@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).