From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#50646: 28.0.50; narrow-to-defun sometimes narrows to wrong defun Date: Sun, 19 Sep 2021 22:04:13 +1200 Message-ID: References: <3a6fa91859db00e5c382752ddedfbdd0@webmail.orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19666"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail Cc: 50646@debbugs.gnu.org To: Arthur Miller Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 19 12:05:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRthQ-0004vI-EP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Sep 2021 12:05:28 +0200 Original-Received: from localhost ([::1]:41986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRthO-0005TT-UN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Sep 2021 06:05:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRth1-0005T7-6X for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 06:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54191) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRth0-0004xw-UF for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 06:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRth0-0008QE-D9 for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 06:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Sep 2021 10:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50646 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 50646-submit@debbugs.gnu.org id=B50646.163204585832312 (code B ref 50646); Sun, 19 Sep 2021 10:05:02 +0000 Original-Received: (at 50646) by debbugs.gnu.org; 19 Sep 2021 10:04:18 +0000 Original-Received: from localhost ([127.0.0.1]:37504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRtgH-0008P5-L5 for submit@debbugs.gnu.org; Sun, 19 Sep 2021 06:04:17 -0400 Original-Received: from smtp-2.orcon.net.nz ([60.234.4.43]:41455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRtgF-0008Ov-Kr for 50646@debbugs.gnu.org; Sun, 19 Sep 2021 06:04:16 -0400 Original-Received: from [10.253.37.70] (port=14680 helo=webmail.orcon.net.nz) by smtp-2.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1mRtgD-0008Pd-LU; Sun, 19 Sep 2021 22:04:13 +1200 Original-Received: from ip-203-94-48-127.kinect.net.nz ([203.94.48.127]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Sun, 19 Sep 2021 22:04:13 +1200 In-Reply-To: X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214697 Archived-At: On 2021-09-19 20:33, Arthur Miller wrote: > (with-temp-buffer > (insert-file-contents-literally (expand-file-name file > source-directory)) > > It is the utf-8. When I use `insert-file-contents' instead, it works as > intended. > > I guess insert-file-contents-literally does not preserve same coding as > what I > have in the temp-buffer by deafault, so things get messed-up. I don't > know if I > explain it well, but that seems to be the problem. Yes, all of the following things from `insert-file-contents' are NOT done by `insert-file-contents-literally': "This function does code conversion according to the value of ‘coding-system-for-read’ or ‘file-coding-system-alist’, and sets the variable ‘last-coding-system-used’ to the coding system actually used. In addition, this function decodes the inserted text from known formats by calling ‘format-decode’, which see. I don't believe you would typically use *-literally unless you specifically wanted to avoid all of those things (or some of the things, and were happy to take care of the others in your own code). I do also think that the docstring for `insert-file-contents-literally' can be made clearer, firstly just with a newline so that the context for the final sentence does not begin in the middle of a paragraph, and secondly so that when users are reading this for the first time it's more obvious (before reaching that final sentence) that the list of "modifications" are things which do NOT happen if you use this function. How does this look? (defun insert-file-contents-literally (filename &optional visit beg end replace) "Like `insert-file-contents', but only reads in the file literally. See `insert-file-contents' for an explanation of the parameters. -A buffer may be modified in several ways after reading into the buffer, -due to Emacs features such as format decoding, character code -conversion, `find-file-hook', automatic uncompression, etc. + +In other circumstances a buffer may be modified in several ways after +reading into the buffer, due to Emacs features such as format decoding, +character code conversion, `find-file-hook', automatic uncompression, etc. This function ensures that none of these modifications will take place." (let ((format-alist nil)